feat: stream swap quotes using server-sent events #6760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Warning MetaMask internal reviewing guidelines:
|
|
@metamaskbot publish-preview |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
micaelae
force-pushed
the
swaps3025-quote-streaming
branch
2 times, most recently
from
45b6fbd to
cfbd89b
Compare
micaelae
force-pushed
the
swaps3025-quote-streaming
branch
from
cfbd89b to
f3be855
Compare
micaelae
changed the title
micaelae
force-pushed
the
swaps3025-quote-streaming
branch
from
1e904bd to
6ae7634
Compare
micaelae
force-pushed
the
swaps3025-quote-streaming
branch
from
6ae7634 to
bcf5a41
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@SocketSecurity @microsoft/[email protected] |
micaelae
force-pushed
the
swaps3025-quote-streaming
branch
from
0eaa63a to
9ee0ebb
Compare
|
@metamaskbot publish-preview |
micaelae
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
SteP-n-s
approved these changes
Oct 13, 2025
| ); | ||
| expect(bridgeController.state.quotesLastFetched).toBeNull(); | ||
| expect(bridgeController.state.quotesLastFetched).toBeCloseTo( | ||
| Date.now() - 1000, |
There was a problem hiding this comment.
Are the 1000, 500, and 10000 values set arbitrarily, and could they affect the output of these test cases?
There was a problem hiding this comment.
They're not arbitrary and can affect some of the tests. Most of the tests advance to the next timer (ignores the number of seconds). But some tests that check for intermediate and loading states advance to specific timestamps, which depend on the timeouts set when mocking the server
ghgoodreau
approved these changes
Oct 13, 2025
| serverEventHandlers.onValidQuoteReceived(quoteResponse).then((v) => { | ||
| return v; | ||
| }); | ||
| } catch (error) { |
There was a problem hiding this comment.
Bug: SSE Handler Fails on Malformed JSON and Unhandled Promises
The fetchBridgeQuoteStream's onMessage handler has two issues. JSON.parse(event.data) lacks error handling, which can crash the SSE connection with malformed JSON. Additionally, the async serverEventHandlers.onValidQuoteReceived call is not awaited or caught, leading to unhandled promise rejections and potential silent failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR introduces server‑sent events quote streaming and integrates incremental quote updates into the bridge controller polling flow using the
@microsoft/fetch-event-sourcelibraryhandleQuoteStreaminghandler that callsgetQuoteStreamwhen thesseEnabledflag is enabled in LaunchDarklyNote: clients need to patch the
@microsoft/fetch-event-sourcedependency such that it rejects instead of resolving when the quote request is cancelled. This preserves the controller's expected request cancellation behaviorOther changes
Client integration PRs
References
Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-3026
Related to https://github.com/consensys-vertical-apps/va-mmcx-bridge-api/pull/517
Checklist
Note
Introduce server‑sent events quote streaming with incremental updates, refactor fee/sorting logic, tighten error/abort handling, and adjust fetch interfaces; add @microsoft/fetch-event-source.
sseEnabled; integrate into polling with incrementalonmessagehandling viafetchBridgeQuoteStreamand earlyquotesInitialLoadTimeupdate.quoteson new streams; setquotesLastFetchedat start; incrementquotesRefreshCountpost-process; improved error messages and abort handling;resetState(reason).AbortSignalto asset price fetches; guard balance checks with try/catch; keep Solana min-balance fetch async.utils/quote-fees.appendFeesToQuotesand sorting toutils/quote.sortQuotes.utils/snaps.getMinimumBalanceForRentExemptionInLamports.utils/fetch: factorformatQueryParams; addfetchBridgeQuoteStream; drop client-specific cache options forgetQuoteand spot-prices; allowFetchFunction(RequestInfo|URL|string).sseEnabledtoPlatformConfigSchema; enhanceBridgeControllerStatedocs; minor type imports (e.g.,InternalAccount,BridgeClientId).@microsoft/fetch-event-source@^2.0.1; includetestsintsconfig.Written by Cursor Bugbot for commit d35699b. This will update automatically on new commits. Configure here.