feat(core-backend): update websocket behavior #6819
+904
−812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kriys94
force-pushed
the
feature/updateCoreBackend
branch
3 times, most recently
from
61d7fa7 to
1a6bf0c
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Kriys94
changed the title
bergarces
previously approved these changes
Oct 13, 2025
Kriys94
force-pushed
the
feature/updateCoreBackend
branch
from
8f51798 to
e7dac94
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Kriys94
force-pushed
the
feature/updateCoreBackend
branch
from
e7dac94 to
0189b42
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
bergarces
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Current State & Motivation
The
core-backendpackage had several architectural issues that needed to be addressed:Inflexible Chain Management:
AccountActivityServicewas proactively fetching supported chains from the Accounts API (/v2/supportedNetworks) with a hardcoded fallback list. This approach was:Incomplete Connection Management:
BackendWebSocketServiceonly subscribed toAuthenticationController:stateChangeevents but didn't directly respond to wallet lock/unlock events fromKeyringController. This created a dependency where connection management relied solely on authentication state changes.Reconnection Logic Based on Close Codes: The service used WebSocket close codes to determine reconnection behavior, which was fragile and didn't properly distinguish between manual disconnects (user action) and unexpected disconnects (network issues).
Type Mismatches: The
TransactionandAssettypes didn't match the backend API contract, causing potential integration issues.No Performance Monitoring: There was no way to trace WebSocket operations for performance analysis in production environments.
Solution
1. System Notification-Driven Chain Tracking (
AccountActivityService)Before: Client proactively fetches and caches supported chains
After: Client reacts to backend system notifications
Benefits:
Flow:
{chainIds: ['eip155:1', 'eip155:137'], status: 'up'}2. Simplified Reconnection Logic (
BackendWebSocketService)Before: Reconnection based on close codes
After: Reconnection based on manual disconnect flag
Benefits:
3. KeyringController Event Integration
Added direct subscriptions to wallet lock state:
Connection Requirements (all must be true):
isEnabled()callback)AuthenticationController.isSignedIn)KeyringControllerstate)4. Type Alignment with Backend API
Transaction.hash→Transaction.id(matches backend field name)Assetnow requiresdecimals: number(needed for proper token formatting)5. Performance Tracing Integration
Added optional
traceFnparameter to enable performance monitoring:Benefits:
Integration:
tracefromshared/lib/trace.ts(Sentry-backed)tracefromapp/util/trace.ts(Sentry-backed)Example usage:
Breaking Changes Impact
For
AccountActivityServiceconsumers:getSupportedChains()method - consumers should subscribe toAccountActivityService:statusChangedevents insteadFor type definitions:
Transactionobjects must useidinstead ofhashAssetobjects must includedecimalsfieldTesting Updates
nockdependency (no longer fetching from external API)References
Checklist
Note
Revamps WebSocket lifecycle and reconnection with lock/unlock integration and tracing, replaces API-based chain support with system-notification tracking, and aligns types (Transaction.id, Asset.decimals).
traceFnfor performance tracing; trace connection, disconnect, notifications.KeyringController:lock/unlockevents; idempotentconnect()/disconnect().#manualDisconnectflag; always auto-reconnect on unexpected closes.timestamphandling; exposechannelType; refineconnectedAt/state.#chainsUpset.down; resubscribe on reconnect.statusChangedwith optionaltimestamp; passchannelTypeon subscribe.Transaction.hash→Transaction.id.Assetadds requireddecimals.@metamask/keyring-controller(dev/peer); TS references updated.TokenBalancesController.test.tsto includeasset.decimalsin balance updates.Written by Cursor Bugbot for commit 0189b42. This will update automatically on new commits. Configure here.