Skip to content

chore: Notification controller eslint cleanup #7479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Prithpal-Sooriya merged 6 commits into from
Dec 15, 2025
Merged

chore: Notification controller eslint cleanup #7479

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5952b9d
Refactor: Remove unused eslint suppressions and update types
cursoragent Dec 15, 2025
89639d9
chore: Remove core dump file and update changelog
Prithpal-Sooriya Dec 15, 2025
a231d8d
chore: Remove changelog entry for ESLint-only changes
Prithpal-Sooriya Dec 15, 2025
58ac6b5
Merge branch 'main' into cursor/notification-controller-eslint-cleanu…
Prithpal-Sooriya Dec 15, 2025
f839f3c
Merge branch 'main' of github.com:MetaMask/core into cursor/notificat…
Prithpal-Sooriya Dec 15, 2025
8ddabd4
Merge branch 'main' of github.com:MetaMask/core into cursor/notificat…
Prithpal-Sooriya Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added core
View file
Open in desktop
Copy link
Contributor Author

@Prithpal-Sooriya Prithpal-Sooriya Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cursor remove this file

Copy link

@cursor cursor bot Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking a look!

Open in Cursor Open in Web

Binary file not shown.
18 changes: 0 additions & 18 deletions eslint-suppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1864,24 +1864,6 @@
"count": 1
}
},
"packages/notification-services-controller/src/NotificationServicesController/services/perp-notifications.ts": {
"@typescript-eslint/explicit-function-return-type": {
"count": 1
},
"id-length": {
"count": 1
}
},
"packages/notification-services-controller/src/NotificationServicesController/types/notification-api/notification-api.ts": {
"@typescript-eslint/naming-convention": {
"count": 18
}
},
"packages/notification-services-controller/src/NotificationServicesController/types/notification-api/schema.ts": {
"@typescript-eslint/naming-convention": {
"count": 70
}
},
"packages/notification-services-controller/src/NotificationServicesController/types/perps/schema.ts": {
"@typescript-eslint/naming-convention": {
"count": 9
Expand Down
6 changes: 3 additions & 3 deletions ...ion-services-controller/src/NotificationServicesController/services/perp-notifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const PERPS_API_CREATE_ORDERS = `${PERPS_API}/api/v1/orders`;
export async function createPerpOrderNotification(
bearerToken: string,
orderInput: OrderInput,
) {
): Promise<void> {
try {
await createServicePolicy().execute(async () => {
return successfulFetch(PERPS_API_CREATE_ORDERS, {
Expand All @@ -29,7 +29,7 @@ export async function createPerpOrderNotification(
body: JSON.stringify(orderInput),
});
});
} catch (e) {
console.error('Failed to create perp order notification', e);
} catch (error) {
console.error('Failed to create perp order notification', error);
}
}
2 changes: 2 additions & 0 deletions ...-controller/src/NotificationServicesController/types/notification-api/notification-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// Types derived from external Notification API schema - naming follows API conventions
/* eslint-disable @typescript-eslint/naming-convention */
import type { components } from './schema';
import type { TRIGGER_TYPES } from '../../constants/notification-schema';
import type { Compute } from '../type-utils';
Expand Down
2 changes: 2 additions & 0 deletions ...n-services-controller/src/NotificationServicesController/types/notification-api/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
/* eslint-disable jsdoc/tag-lines */
// Auto-generated from OpenAPI spec - naming follows API schema conventions
/* eslint-disable @typescript-eslint/naming-convention */

/**
* This file was auto-generated by openapi-typescript.
Expand Down
Loading