Skip to content

feat: added 'updatedAt' field to claimDraft #7523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lwin-kyaw merged 3 commits into from
Dec 17, 2025
+20 −10
Merged

feat: added 'updatedAt' field to claimDraft #7523

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1748ab
feat: added 'updatedAt' field to claimDraft
lwin-kyaw Dec 17, 2025
998a0a9
chore: updated ChangeLog
lwin-kyaw Dec 17, 2025
23cae10
fix: saveOrUpdateClaimDraft return value
lwin-kyaw Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/claims-controller/src/ClaimsController.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,7 @@ describe('ClaimsController', () => {
impactedTxHash: '0x123',
reimbursementWalletAddress: '0x456',
description: 'test description',
updatedAt: '2025-12-17T06:10:32.213Z',
};
const MOCK_CLAIM_DRAFTS: ClaimDraft[] = [
{
Expand All @@ -275,6 +276,7 @@ describe('ClaimsController', () => {
impactedTxHash: '0x123',
reimbursementWalletAddress: '0x456',
description: 'test description',
updatedAt: '2025-12-17T06:10:32.213Z',
},
{
draftId: 'mock-draft-2',
Expand All @@ -284,6 +286,7 @@ describe('ClaimsController', () => {
impactedTxHash: '0x789',
reimbursementWalletAddress: '0x012',
description: 'test description 2',
updatedAt: '2025-12-17T06:10:32.213Z',
},
];

Expand All @@ -295,7 +298,10 @@ describe('ClaimsController', () => {
expect(updatedState).not.toBe(initialState);
expect(updatedState.drafts).toHaveLength(1);
expect(updatedState.drafts[0].draftId).toBeDefined();
expect(updatedState.drafts[0]).toMatchObject(MOCK_DRAFT);
expect(updatedState.drafts[0]).toMatchObject({
...MOCK_DRAFT,
updatedAt: expect.any(String),
});
expect(updatedState.drafts[0].draftId).toBeDefined();
});
});
Expand Down
7 changes: 6 additions & 1 deletion packages/claims-controller/src/ClaimsController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,11 @@ export class ClaimsController extends BaseController<
this.update((state) => {
state.drafts = state.drafts.map((existingDraft) =>
existingDraft.draftId === draft.draftId
? { ...existingDraft, ...draft }
? {
...existingDraft,
...draft,
updatedAt: new Date().toISOString(),
}
: existingDraft,
);
});
Expand All @@ -248,6 +252,7 @@ export class ClaimsController extends BaseController<
const newDraft: ClaimDraft = {
...draft,
draftId,
updatedAt: new Date().toISOString(),
};

this.update((state) => {
Expand Down
8 changes: 1 addition & 7 deletions packages/claims-controller/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,7 @@ export type Claim = {
export type ClaimDraft = Partial<
Omit<
Claim,
| 'id'
| 'shortId'
| 'createdAt'
| 'updatedAt'
| 'intercomId'
| 'status'
| 'attachments'
'id' | 'shortId' | 'createdAt' | 'intercomId' | 'status' | 'attachments'
>
> & {
/**
Expand Down
Loading