-
-
Notifications
You must be signed in to change notification settings - Fork 3
Update templates #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update templates #80
Conversation
mj-kiwi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue 1: Incomplete Branding Update (14 missed references)
This PR only updates the CLI intro/outro files, but several other references to “Delegation Toolkit” were missed and should also be updated.
Page titles (2 files):
examples/smart-accounts/signers/dynamic/src/app/layout.tsx:18
–"Delegation Toolkit Starter App"packages/create-gator-app/templates/nextjs/delegation-starter/src/app/layout.tsx:19
–"Delegation Toolkit Starter App"
Documentation links (11 references across 6 files):
examples/smart-accounts/signers/dynamic/src/components/Footer.tsx:7packages/create-gator-app/templates/nextjs/delegation-starter/src/components/Steps.tsx
– 5 instances (lines 100, 113, 130, 140, 172)packages/create-gator-app/templates/nextjs/farcaster-starter/src/components/Steps.tsx
– 5 instancespackages/create-gator-app/templates/nextjs/advanced-permissions-starter/src/components/Steps.tsx:87packages/create-gator-app/templates/vite-react/delegation-starter/src/components/Steps.tsx
– 5 instancespackages/create-gator-app/templates/vite-react/delegation-starter/src/components/Footer.tsx:8
Changelog (1 file):
packages/create-gator-app/CHANGELOG.md:59
Issue 2: Missed Version Updates in the Examples Directory
The following file was not updated and still contains outdated dependency versions:
File:
examples/smart-accounts/signers/dynamic/package.json
Outdated dependencies:
@metamask/smart-accounts-kit:^0.1.0→ should be^0.3.0next:15.3.4→ should be15.4.10eslint-config-next:15.3.4→ should be15.4.10
|
I have not included Dynamic changes, as I'm moving examples to a different repo. https://github.com/MetaMask/smart-accounts-kit-examples I have a PR raised for updating Dynamic example, will push those changes there. MetaMask/smart-accounts-kit-examples#1
I don't think we should update Changelog, as it's for older version which is factually correct. |
jeffsmale90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
Update next js version for templates
Note
Upgrade dependencies and rebrand references
@metamask/smart-accounts-kitto^0.3.0andnext/eslint-config-nextto15.4.10across Next.js and Vite templatesDocs and copy updates
docs.metamask.io/delegation-toolkitlinks withdocs.metamask.io/smart-accounts-kitequivalents inSteps.tsxcomponents and footerWritten by Cursor Bugbot for commit 13aab1e. This will update automatically on new commits. Configure here.