ed25519/x25519: simplify key implementation, add tests#7
Merged
MichaelMure merged 1 commit intomasterfrom Jun 18, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request simplifies the key implementation for ed25519/x25519 conversions and adds comprehensive tests to ensure correctness and a round trip for multibase encoding. Key changes include the introduction of new tests for key generation and conversion, updates to the key conversion functions to leverage internal multibase helper functions, and corresponding updates to the ed25519 module for consistency.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| verifications/x25519/key_test.go | Adds tests for key generation, multibase round trip, and ed25519-to-x25519 conversion |
| verifications/x25519/key.go | Refactors key conversion logic and integrates multibase helper functions |
| verifications/internal/multibase.go | Introduces helper functions to encode and decode multibase public keys |
| verifications/ed25519/key_test.go | Adds tests for ed25519 key generation and multibase round trip |
| verifications/ed25519/key.go | Updates multibase functionality to use the new helper functions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also add the ed25519->x25519 conversion for private keys, notably to make sure that it matches with the conversion for public keys.