Skip to content

ed25519/x25519: simplify key implementation, add tests#7

Merged
MichaelMure merged 1 commit intomasterfrom
key-test
Jun 18, 2025
Merged

ed25519/x25519: simplify key implementation, add tests#7
MichaelMure merged 1 commit intomasterfrom
key-test

Conversation

@MichaelMure
Copy link
Collaborator

This also add the ed25519->x25519 conversion for private keys, notably to make sure that it matches with the conversion for public keys.

@MichaelMure MichaelMure requested review from Copilot and smoyer64 June 18, 2025 10:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request simplifies the key implementation for ed25519/x25519 conversions and adds comprehensive tests to ensure correctness and a round trip for multibase encoding. Key changes include the introduction of new tests for key generation and conversion, updates to the key conversion functions to leverage internal multibase helper functions, and corresponding updates to the ed25519 module for consistency.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
verifications/x25519/key_test.go Adds tests for key generation, multibase round trip, and ed25519-to-x25519 conversion
verifications/x25519/key.go Refactors key conversion logic and integrates multibase helper functions
verifications/internal/multibase.go Introduces helper functions to encode and decode multibase public keys
verifications/ed25519/key_test.go Adds tests for ed25519 key generation and multibase round trip
verifications/ed25519/key.go Updates multibase functionality to use the new helper functions

@MichaelMure MichaelMure merged commit 6bd03b4 into master Jun 18, 2025
4 checks passed
@MichaelMure MichaelMure deleted the key-test branch June 18, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants