Skip to content

fix: compatability with metamask app#1793

Merged
Jwhiles merged 9 commits intomainfrom
try-new-version-of-package
Jan 27, 2025
Merged

fix: compatability with metamask app#1793
Jwhiles merged 9 commits intomainfrom
try-new-version-of-package

Conversation

@Jwhiles
Copy link
Contributor

@Jwhiles Jwhiles commented Jan 7, 2025

Description

Uses a custom auth provider in order to allow faucet to connect to mobile apps.

Additionally this makes some UI changes, to avoid showing misleading CTAs when the mobile app is detected.

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

@Jwhiles Jwhiles requested a review from a team as a code owner January 7, 2025 10:53
@vercel
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 9:57am

@socket-security
Copy link

socket-security bot commented Jan 7, 2025

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/profile-sync-controller@4.1.1 🔁 npm/@metamask/profile-sync-controller@4.1.0 Transitive: environment, eval, filesystem, shell, unsafe +281 66.3 MB danfinlay, gudahtt, kumavis, ...6 more

View full report↗︎

@socket-security
Copy link

socket-security bot commented Jan 7, 2025

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
High CVE npm/http-proxy-middleware@2.0.6 🚫
High CVE npm/mermaid@10.9.1 🚫
Low CVE npm/elliptic@6.5.7 ⚠︎
Medium CVE npm/path-to-regexp@0.1.10 ⚠︎

View full report↗︎

Next steps

What is a CVE?

Contains a high severity Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

What is a mild CVE?

Contains a low severity Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known low severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

What is a medium CVE?

Contains a medium severity Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known medium severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/http-proxy-middleware@2.0.6
  • @SocketSecurity ignore npm/mermaid@10.9.1
  • @SocketSecurity ignore npm/elliptic@6.5.7
  • @SocketSecurity ignore npm/path-to-regexp@0.1.10

@Jwhiles Jwhiles force-pushed the try-new-version-of-package branch from a2106c3 to af08274 Compare January 7, 2025 11:00
@Jwhiles Jwhiles force-pushed the try-new-version-of-package branch from 26f5382 to ef17829 Compare January 23, 2025 15:30
@Jwhiles Jwhiles requested review from a team as code owners January 23, 2025 15:30
@AndyMBridges AndyMBridges removed the request for review from a team January 23, 2025 15:34
@Jwhiles Jwhiles force-pushed the try-new-version-of-package branch from 7e51653 to 65f2e68 Compare January 23, 2025 16:47
@Jwhiles Jwhiles changed the title chore: add custom provider for profile sync fix: compatability with metamask app Jan 24, 2025
@Jwhiles Jwhiles force-pushed the try-new-version-of-package branch 2 times, most recently from e47a579 to 3d83e6e Compare January 24, 2025 16:06
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Jwhiles Jwhiles force-pushed the try-new-version-of-package branch from 3d83e6e to 7c1e794 Compare January 24, 2025 16:08
@Jwhiles Jwhiles merged commit e918e75 into main Jan 27, 2025
19 of 21 checks passed
@Jwhiles Jwhiles deleted the try-new-version-of-package branch January 27, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants