Update SDK provider in Dynamic setup#2027
Merged
alexandratran merged 5 commits intomainfrom May 28, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
EdouardBougon
previously approved these changes
May 15, 2025
Contributor
EdouardBougon
left a comment
EdouardBougon
left a comment
There was a problem hiding this comment.
LGTM.
Thanks @alexandratran :)
shahbaz17
requested changes
May 28, 2025
Member
shahbaz17
left a comment
shahbaz17
left a comment
There was a problem hiding this comment.
We may wanna address - Dual SDK integration - Seamlessly combine MetaMask and Dynamic SDKs. part, as MM SDK is now integrated within Dynamic SDK.
- MetaMask SDK built into Dynamic - Use MetaMask SDK features directly within the Dynamic SDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the Dynamic SDK manual setup example, remove the
useEffecthook containing the MM SDK configuration, because MM SDK is now directly integrated into the Dynamic SDK.Preview
https://metamask-docs-3406ugzfr-consensys-ddffed67.vercel.app/sdk/quickstart/javascript-dynamic/#2-configure-providers
Checklist
Complete this checklist before merging your PR: