Merged
Conversation
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
A concise description of the purpose of the PR, followed by summarized bullets of changes
- Introduce links and promotional styling for the new Embedded Wallets SDK across the docs site
- Add a homepage feature card and welcome page tip for Embedded Wallets
- Configure a persistent announcement bar and corresponding SCSS for styling
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/scss/custom.scss | Add styles for the Docusaurus announcement bar and link states |
| src/pages/index.tsx | Insert new “Embedded Wallets” feature card on the homepage |
| sdk/introduction/welcome.md | Add a tip block promoting the Embedded Wallets SDK |
| docusaurus.config.js | Configure a non-closeable announcementBar with Embedded Wallets link |
Comments suppressed due to low confidence (2)
docusaurus.config.js:416
- [nitpick] The announcementBar ID 'support_us' is generic and may collide with other bars. Consider renaming it to something more descriptive, like 'embedded_wallets_announcement'.
id: 'support_us',
src/pages/index.tsx:32
- Indentation of the new feature object is inconsistent with the surrounding array entries. Align the braces and properties to match existing items for readability.
{
| announcementBar: { | ||
| id: 'support_us', | ||
| content: | ||
| '<span style="font-weight: 600">NEW!</span> Build embedded wallets with MetaMask using the <a target="_blank" rel="noopener noreferrer" href="https://web3auth.io/docs">Embedded Wallets SDK</a>. Instantly onboard users with social logins, passkeys, and more.', |
There was a problem hiding this comment.
[nitpick] Avoid inline styles in the announcementBar content string. Extract the bold styling into a CSS class in custom.scss to maintain separation of concerns.
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
alexandratran
approved these changes
Jun 2, 2025
bgravenorst
added a commit
that referenced
this pull request
Jun 4, 2025
* Add embedded wallets. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Stylesheet updates. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Apply feedback. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> --------- Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
alexandratran
added a commit
that referenced
this pull request
Jun 10, 2025
* Migrate gator docs * fixes * swizzle desktop sidebar * update codeowners * Add initial dropdown component. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Add front page. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Fix category sections. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Inital dropdown style changes. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Update dropdown behaviour. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Add link to Embedded wallets (#2069) * Add embedded wallets. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Stylesheet updates. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Apply feedback. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> --------- Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Minor update. (#2070) Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Update react-native.md (#2068) * Update react-native.md Expo Demo repo had been deleted and was a broken link. * Update sdk/quickstart/react-native.md Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com> * Update sdk/quickstart/react-native.md Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com> * Update react-native.md --------- Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com> * chore(deps): bump tar-fs from 1.16.4 to 1.16.5 in the npm_and_yarn group (#2072) Bumps the npm_and_yarn group with 1 update: [tar-fs](https://github.com/mafintosh/tar-fs). Updates `tar-fs` from 1.16.4 to 1.16.5 - [Commits](https://github.com/mafintosh/tar-fs/commits) --- updated-dependencies: - dependency-name: tar-fs dependency-version: 1.16.5 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com> * fixes * Add front page. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Remove dup. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * add api reference docs and fix links * minor adjustments * change file names (delegation-toolkit) and fix links * fix lint error * fix version ordering and color mode --------- Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: bgravenorst <byron.gravenorst@consensys.net> Co-authored-by: Byron Gravenorst <50852695+bgravenorst@users.noreply.github.com> Co-authored-by: RobItu <74835755+RobItu@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
alexandratran
added a commit
that referenced
this pull request
Jun 13, 2025
* Migrate gator docs * fixes * swizzle desktop sidebar * update codeowners * Add initial dropdown component. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Add front page. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Update SDK connect guides * Fix category sections. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Inital dropdown style changes. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Update dropdown behaviour. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Add link to Embedded wallets (#2069) * Add embedded wallets. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Stylesheet updates. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Apply feedback. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> --------- Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Minor update. (#2070) Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Update react-native.md (#2068) * Update react-native.md Expo Demo repo had been deleted and was a broken link. * Update sdk/quickstart/react-native.md Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com> * Update sdk/quickstart/react-native.md Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com> * Update react-native.md --------- Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com> * chore(deps): bump tar-fs from 1.16.4 to 1.16.5 in the npm_and_yarn group (#2072) Bumps the npm_and_yarn group with 1 update: [tar-fs](https://github.com/mafintosh/tar-fs). Updates `tar-fs` from 1.16.4 to 1.16.5 - [Commits](https://github.com/mafintosh/tar-fs/commits) --- updated-dependencies: - dependency-name: tar-fs dependency-version: 1.16.5 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com> * fixes * Add front page. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * Remove dup. Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> * High-level navigation changes * add get started button * updates to sdk intro + redirects * add api reference docs and fix links * minor adjustments * address feedback * move llm prompt and update copy * change file names (delegation-toolkit) and fix links * fix lint error * Add product banner * update icons * minor fix * fix version ordering and color mode * hide top nav + enhancements * fix embedded wallets sdk dropdown * fix sidebar bug * address reviewer feedback --------- Signed-off-by: bgravenorst <byron.gravenorst@consensys.net> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: bgravenorst <byron.gravenorst@consensys.net> Co-authored-by: Byron Gravenorst <50852695+bgravenorst@users.noreply.github.com> Co-authored-by: RobItu <74835755+RobItu@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add links to the Embedded Wallets SDK.
Checklist
Complete this checklist before merging your PR: