Conversation
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
Adds the npm2yarn remark plugin to automatically generate Yarn equivalents of npm commands across the docs.
- Adds
@docusaurus/remark-plugin-npm2yarnto dependencies. - Enables the plugin in each docs instance in
docusaurus.config.js. - Simplifies the Delegation Toolkit install guide by replacing manual Tabs UI with a single code fence annotated for npm2yarn.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Add @docusaurus/remark-plugin-npm2yarn dependency |
| docusaurus.config.js | Import and configure remark-plugin-npm2yarn in docs |
| delegation-toolkit/get-started/install.md | Replace Tabs-based install instructions with fenced block |
Comments suppressed due to low confidence (2)
delegation-toolkit/get-started/install.md:7
- Remove the now-unused imports
TabsandTabItemsince the tabbed UI was removed, and delete or separate import statements according to project style.
import Tabs from "@theme/Tabs"; import TabItem from "@theme/TabItem";
docusaurus.config.js:76
- The
remarkPluginssetting for npm2yarn is duplicated across multiple docs instances; consider extracting it into a shared default or applying it globally to reduce repetition.
remarkPlugins: [npm2yarnPlugin],
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
AyushBherwani1998
approved these changes
Jun 30, 2025
Member
AyushBherwani1998
left a comment
There was a problem hiding this comment.
LGTM.
There are other instances where we manually manage. Maybe another PR to clean up is fine. https://docs.metamask.io/sdk/connect/javascript/#1-install-the-sdk
alexandratran
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the npm2yarn plugin.
Preview
Checklist
Complete this checklist before merging your PR: