2483d embedded wallets pass #2603
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution MetaMask internal reviewing guidelines:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| The client then assembles these shares and reconstructs the users key in the front-end. | ||
| The client then assembles these shares and reconstructs the user's key in the frontend. | ||
|
|
||
| <!-- The phrase "reconstructs the user's key in the frontend" sounds incorrect and potentially misleading. In an MPC/TSS design, the private key should never be reconstructed client-side. Should this instead say something like: "The client combines the required shares as part of a threshold signing protocol, ensuring that the full private key is never reconstructed or exposed"? Also, can we clarify whether "frontend" refers to the dApp client or a Torus-controlled client environment? --> |
There was a problem hiding this comment.
Review comment accidentally committed to documentation
An HTML comment containing a developer review note was left in the documentation. The comment questions whether the preceding text about reconstructing the user's key in the frontend is accurate for an MPC/TSS design, and suggests alternative wording. While HTML comments are hidden from rendered output, this internal review note with suggested rewrites should not be in the committed documentation.
| label: "Compliance, Audits and Trust", | ||
| href: "https://trust.web3auth.io", | ||
| label: "Compliance, Audits and Trust", | ||
| href: "https://trust.web3auth.io", // needs proofing (landing page missing stop) |
There was a problem hiding this comment.
Internal review comment left in production code
An internal review note // needs proofing (landing page missing stop) was left in the sidebar configuration. This comment appears to be a TODO or review reminder that should have been addressed before committing, not left in the codebase.
There was a problem hiding this comment.
indeed -- this note need to become actionable item elsewhere, hence "do not merge" label on this PR
| @@ -0,0 +1,14 @@ | |||
| --- | |||
There was a problem hiding this comment.
This PR has "do not merge" label because vercel wont like meta in the single sourced mdx --> need to finalize this ahead of final review
There was a problem hiding this comment.
MPC is only supported in MPC Core Kit SDK, which is not documented here due to enterprise plan issues.
There was a problem hiding this comment.
It has a different document, just for integration for particular customers.
There was a problem hiding this comment.
Yeah, I had run the issue down that far. So, to use this table and make clear for end users -- I would need to know if all the same platforms are supported my this "MPC Core Kit SDK" -- in which case, the platforms column is redundant and can go
| This document provides an in-depth exploration of the technical architecture of the Multi-Party Computation (MPC)-based SDK, this includes the MPC Core Kit SDK. | ||
|
|
||
| The only difference between the SSS-based SDKs and MPC SDKs are that during usage/login MPC SDKs do not reconstruct user private keys. | ||
| <!-- This deserves link to the SDK: which of these docs pages covers the Core Kit SDK? Alt is this is enterprise grade option only, in which case consider importing ./_partials/_sdk-key-model-table.mdx--> |
There was a problem hiding this comment.
comments still in play, hence "do not merge" label on this PR
Description
Simplification how the cryptography is presented
Proofs
Applies docs style
DOES NOT - touch images
Issue(s) fixed
Partial fix for 2483 #
Preview
Checklist
External contributor checklist
Note
Updates and streamlines the Embedded Wallets cryptography documentation and enables proper math rendering.
_sdk-key-model-table.mdxand embeds it ininfrastructure/README.mdxinfrastructure/README,mpc-architecture.mdx,sss-architecture.mdx,nodes-and-dkg.mdx, andglossary.mdxto clarify terminology, flows, security assumptions, and protocolsdocusaurus.config.jsand bumpskatexdependency (and lockfile) to support math notationew-sidebar.jsWritten by Cursor Bugbot for commit 13e7748. This will update automatically on new commits. Configure here.