Fix missing await in gas estimation#2642
Merged
bgravenorst merged 1 commit intoMetaMask:mainfrom Jan 26, 2026
Merged
Conversation
|
@binarycryptodev is attempting to deploy a commit to the Consensys Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bgravenorst
approved these changes
Jan 26, 2026
Contributor
bgravenorst
left a comment
bgravenorst
left a comment
There was a problem hiding this comment.
lgtm. Thanks for the contribution @binarycryptodev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where provider.estimateGas() was used without await, causing the transaction code to fail at runtime. The gas estimation now resolves correctly and works as intended.
Note
Fixes the ethers.js tutorial snippet to correctly await
provider.estimateGaswhen derivinggasLimit, ensuring the example runs without runtime errors.send-a-transaction-ethers.md: changeprovider.estimateGas({...})toawait provider.estimateGas({...})in the optional fine-tuning exampleWritten by Cursor Bugbot for commit 2d11460. This will update automatically on new commits. Configure here.