Skip to content

Commit 54b2394

Browse files
NidhiKJhaameliejyc
andauthored
fix: cp-13.10.4 removed sidepanel from chrome manifest files (#38242)
This PR is to remove sidepanel api support ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry:null ## **Related issues** Fixes: ## **Manual testing steps** 1. Click on MM icon. check no open sidepanel button should show ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** NA ### **After** https://github.com/user-attachments/assets/a94058ec-44eb-4723-ac89-f25065b2a93c ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Removes Chrome Side Panel support by deleting manifest config and permission, and sets IS_SIDEPANEL=false for main/beta/flask builds. > > - **Manifests**: > - Remove `side_panel` config from `app/manifest/v3/chrome.json`. > - Drop `sidePanel` permission from `app/manifest/v3/_base.json`. > - **Builds**: > - Set `IS_SIDEPANEL` to `false` for `main`, `beta`, and `flask` in `builds.yml`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 9d8e488. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Amélie <[email protected]>
1 parent 087b3c2 commit 54b2394

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

app/manifest/v3/_base.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@
8888
"webRequest",
8989
"offscreen",
9090
"identity",
91-
"sidePanel",
9291
"contextMenus"
9392
],
9493
"sandbox": {

app/manifest/v3/chrome.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,5 @@
1010
"matches": ["http://*/*", "https://*/*"],
1111
"ids": ["*"]
1212
},
13-
"minimum_chrome_version": "115",
14-
"side_panel": {
15-
"default_path": "sidepanel.html"
16-
}
13+
"minimum_chrome_version": "115"
1714
}

builds.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ buildTypes:
3434
- REJECT_INVALID_SNAPS_PLATFORM_VERSION: true
3535
- IFRAME_EXECUTION_ENVIRONMENT_URL: https://execution.metamask.io/iframe/10.2.3/index.html
3636
- ACCOUNT_SNAPS_DIRECTORY_URL: https://snaps.metamask.io/account-management
37-
- IS_SIDEPANEL: true
37+
- IS_SIDEPANEL: false
3838
# for seedless onboarding (social login)
3939
- GOOGLE_PROD_CLIENT_ID
4040
- APPLE_PROD_CLIENT_ID
@@ -68,7 +68,7 @@ buildTypes:
6868
- REJECT_INVALID_SNAPS_PLATFORM_VERSION: true
6969
- IFRAME_EXECUTION_ENVIRONMENT_URL: https://execution.metamask.io/iframe/10.2.3/index.html
7070
- ACCOUNT_SNAPS_DIRECTORY_URL: https://snaps.metamask.io/account-management
71-
- IS_SIDEPANEL: true
71+
- IS_SIDEPANEL: false
7272
# for seedless onboarding (social login)
7373
- GOOGLE_BETA_CLIENT_ID
7474
- APPLE_BETA_CLIENT_ID
@@ -137,7 +137,7 @@ buildTypes:
137137
- SEGMENT_WRITE_KEY_REF: SEGMENT_FLASK_WRITE_KEY
138138
- ACCOUNT_SNAPS_DIRECTORY_URL: https://metamask.github.io/snaps-directory-staging/main/account-management
139139
- EIP_4337_ENTRYPOINT: '0x5FF137D4b0FDCD49DcA30c7CF57E578a026d2789'
140-
- IS_SIDEPANEL: true
140+
- IS_SIDEPANEL: false
141141
# for seedless onboarding (social login)
142142
- GOOGLE_FLASK_CLIENT_ID
143143
- APPLE_FLASK_CLIENT_ID

0 commit comments

Comments
 (0)