Commit fb60f40
release(runway): cherry-pick fix: Remove
- fix: Remove `tabs` permission to avoid new warnings cp-13.10.1
(#38075)
## **Description**
The recent addition of the `tabs` permission will result in new
permission warnings upon update, which is extremely disruptive and is
something we'd never do except as a last resort.
The permission wasn't actually needed, and has been removed. This
removal uncovered a bug in our Webpack build (the `tabs` permission was
erroneously only added for MV2 test builds, but we need it for MV3 test
builds as well), which has been fixed.
[](https://codespaces.new/MetaMask/metamask-extension/pull/38075?quickstart=1)
## **Changelog**
CHANGELOG entry: Remove unnecessary extension permission
## **Related issues**
N/A
## **Manual testing steps**
Test that the sidepanel still works in general. Particularly with dapp
confirmations, and the "Connected status" indicator, and current
selected dapp.
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> Removes the `tabs` permission from the MV3 base manifest.
>
> - **Manifest (MV3)**:
> - Update `app/manifest/v3/_base.json` to remove `permissions` entry
`tabs`.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
7778231. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
[bba4201](bba4201)
Co-authored-by: Mark Stacey <[email protected]>tabs permission to avoid new warnings cp-13.10.1 (#38146)1 parent e97c9f7 commit fb60f40
1 file changed
+0
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
81 | 80 | | |
82 | 81 | | |
83 | 82 | | |
| |||
0 commit comments