Skip to content

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 24, 2024

Description

  • Bump @babel/core and @babel/runtime to latest
  • Fix: replace previous usage of unpatched @babel/runtime with consistent usage of patched version
    • The unpatched version was inadvertently used by @metamask/smart-transactions-controller

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Oct 24, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] unsafe +2 232 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 33.3 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 4.05 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 13.5 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 441 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 26.7 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] unsafe 0 221 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 54.7 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 6.67 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 12 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 9.71 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 43.3 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 6 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 15.8 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 11.9 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 10.8 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/plugin-bugfix-safari-id-destructuring-collision-in-function-expression@7.25.9 None 0 7.71 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 10.6 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 25.7 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 5.14 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 6.03 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 4.14 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 7.04 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 5.55 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 20.3 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 8 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 7.17 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 88.4 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 5.03 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 10.2 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 91.2 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 22.7 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 85.4 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 4.13 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 9.11 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 5.34 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 6.13 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 4.98 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 7.99 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 44.6 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 7.12 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 5.74 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 4.63 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 8.47 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 4.94 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 20.9 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 42.5 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 66.6 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 25.5 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 4.86 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 10.2 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 8.99 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 5.29 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 72.5 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 9.22 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 4.72 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 37.7 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 65.1 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 4.87 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 19.8 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 4.72 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 12.4 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 3.37 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 80 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 8.3 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 6.82 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 4.24 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 7.11 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 23.4 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 4.64 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 15.8 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 10.4 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 135 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 13.9 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 5.03 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 3.93 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 4.92 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] environment 0 153 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 12.2 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 21.4 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 59.7 kB existentialism, hzoo, jlhwung, ...1 more
npm/[email protected] None 0 81.5 kB nicolo-ribaudo
npm/[email protected] None +1 946 kB nicolo-ribaudo
npm/[email protected] None 0 9.74 kB nicolo-ribaudo
npm/[email protected] None 0 602 kB google-wombot
npm/[email protected] None 0 55.8 kB google-wombot
npm/[email protected] None 0 15 kB bnjmnt4n
npm/[email protected] None 0 69.4 kB jviereck

🚮 Removed packages: npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/plugin-bugfix-safari-id-destructuring-collision-in-function-expression@7.22.15, npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team labels Oct 24, 2024
@legobeat legobeat changed the title fix(devDeps): [email protected]>7.25.9 fix(devDeps): [email protected]>7.25.9 Oct 24, 2024
@legobeat legobeat marked this pull request as ready for review October 24, 2024 10:48
@legobeat legobeat requested review from a team as code owners October 24, 2024 10:48
- replaces previous usage of unpatched @babel/runtime with consistent
  usage of patched version
@hjetpoluru hjetpoluru self-requested a review October 25, 2024 17:03
Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjetpoluru hjetpoluru added this pull request to the merge queue Oct 25, 2024
Merged via the queue into MetaMask:develop with commit 440a0fa Oct 25, 2024
76 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file team-application-security Application security team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants