fix: sanitize sensitive items from UI state #35003

matthiasgeihs · 2025-08-11T16:13:06Z

Description

This PR ensures that several sensitive items are removed from the flat state that is made available to the frontend.

Changelog

CHANGELOG entry: tbd

Related issues

Fixes: no issue logged so far

Manual testing steps

Open extension settings.
Go to "Advanced" and click "Download state logs".
Check whether sensitive fields have been sanitized.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-08-11T16:13:15Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-08-11T16:38:28Z

Builds ready [6f64c26]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1188 ± 90 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1188	1019	1570	90	1254	1337
			load	1013	872	1342	84	1082	1147
			domContentLoaded	1006	867	1321	83	1076	1139
			domInteractive	17	13	41	5	17	27
			firstPaint	655	126	1332	406	1019	1131
			backgroundConnect	217	205	249	8	221	232
			firstReactRender	19	14	33	4	22	26
			getState	11	5	89	10	12	27
			initialActions	3	0	14	3	3	11
			loadScripts	796	661	1109	81	863	928
			setupStore	7	4	27	3	8	12
	Webpack	Home	uiStartup	2290	1705	2794	207	2408	2644
			load	1710	1245	2026	180	1787	1965
			domContentLoaded	1703	1240	2009	179	1782	1957
			domInteractive	19	12	97	16	15	73
			firstPaint	180	64	412	62	212	314
			backgroundConnect	28	16	94	13	30	59
			firstReactRender	207	95	400	99	311	390
			getState	37	4	318	81	14	280
			initialActions	6	2	26	4	7	14
			loadScripts	1699	1237	1996	178	1780	1945
			setupStore	25	7	301	56	16	177
Firefox	Browserify	Home	uiStartup	1445	1234	1963	125	1494	1717
			load	1238	1074	1507	84	1292	1377
			domContentLoaded	1238	1073	1506	84	1292	1377
			domInteractive	110	36	332	54	118	239
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	21	136	18	36	63
			firstReactRender	26	22	62	5	27	31
			getState	8	3	177	19	6	19
			initialActions	6	0	189	20	3	20
			loadScripts	1214	1055	1478	82	1272	1354
			setupStore	11	3	220	23	7	36
	Webpack	Home	uiStartup	1616	1404	2142	144	1697	1865
			load	1337	1146	1635	107	1404	1557
			domContentLoaded	1337	1145	1635	107	1404	1557
			domInteractive	94	32	272	47	96	255
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	20	126	18	36	85
			firstReactRender	57	42	76	8	63	68
			getState	10	4	80	11	9	29
			initialActions	7	0	220	25	4	17
			loadScripts	1312	1122	1567	104	1383	1514
			setupStore	10	4	71	10	9	24

Benchmark value 218 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 232 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2291 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 38 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2644 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 73 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 390 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 280 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 177 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1446 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1717 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 239 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 20 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1617 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 35 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 57 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 255 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 85 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 68 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 17 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 412ms | Sum of p95 exceeds: 949.8ms
Sum of all benchmark exceeds: 1361.8ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 236 Bytes (0%)
ui: 1.77 KiB (0.03%)
common: -71.04 KiB (-0.94%)

metamaskbot · 2025-08-12T14:12:45Z

Builds ready [8256aa4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1172 ± 66 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1172	1055	1370	66	1218	1282
			load	996	882	1132	63	1049	1103
			domContentLoaded	989	870	1128	63	1041	1089
			domInteractive	16	13	35	4	16	31
			firstPaint	704	83	1116	387	1021	1091
			backgroundConnect	215	204	244	7	218	231
			firstReactRender	20	12	54	6	21	34
			getState	12	4	86	12	13	28
			initialActions	3	0	50	7	2	12
			loadScripts	781	664	899	62	834	882
			setupStore	7	4	24	2	8	11
	Webpack	Home	uiStartup	2240	1663	2684	216	2355	2538
			load	1686	1194	1995	169	1770	1913
			domContentLoaded	1679	1190	1971	166	1763	1899
			domInteractive	17	11	80	13	14	47
			firstPaint	175	64	464	66	212	286
			backgroundConnect	36	13	346	47	33	83
			firstReactRender	205	91	416	111	337	393
			getState	30	4	307	71	13	283
			initialActions	5	2	13	2	6	9
			loadScripts	1674	1188	1958	165	1757	1890
			setupStore	17	6	289	32	15	26
Firefox	Browserify	Home	uiStartup	1322	1137	1736	93	1373	1476
			load	1142	997	1363	75	1194	1273
			domContentLoaded	1141	997	1363	75	1194	1272
			domInteractive	99	33	275	46	103	219
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	16	91	13	31	59
			firstReactRender	24	20	55	7	23	50
			getState	6	2	45	8	5	29
			initialActions	3	0	52	6	2	11
			loadScripts	1121	983	1340	74	1174	1242
			setupStore	8	3	53	9	6	31
	Webpack	Home	uiStartup	1633	1399	2088	140	1700	1904
			load	1361	1157	1643	114	1435	1598
			domContentLoaded	1360	1157	1643	114	1434	1597
			domInteractive	96	35	299	45	98	249
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	19	116	14	37	62
			firstReactRender	55	42	72	6	60	65
			getState	9	4	48	7	10	25
			initialActions	4	1	22	4	3	15
			loadScripts	1336	1134	1622	113	1411	1576
			setupStore	11	5	184	19	9	28

Benchmark value 216 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 231 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2240 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2538 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 393 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 283 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 219 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 31 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1634 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 56 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 249 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 62 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 312ms | Sum of p95 exceeds: 596.8ms
Sum of all benchmark exceeds: 908.8ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -1 KiB (-0.02%)
ui: 1.78 KiB (0.03%)
common: -68.68 KiB (-0.91%)

metamaskbot · 2025-08-12T16:04:12Z

Builds ready [ee2a368]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1171 ± 68 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1171	1045	1437	68	1198	1314
			load	991	891	1202	58	1025	1099
			domContentLoaded	984	879	1193	58	1016	1093
			domInteractive	18	13	42	6	17	32
			firstPaint	627	82	1201	395	1002	1080
			backgroundConnect	218	205	250	8	224	234
			firstReactRender	20	14	40	5	21	31
			getState	11	5	73	8	12	26
			initialActions	4	0	53	7	3	14
			loadScripts	772	665	974	58	806	882
			setupStore	7	4	24	2	8	11
	Webpack	Home	uiStartup	2218	1691	2701	224	2356	2583
			load	1665	1226	2026	183	1794	1928
			domContentLoaded	1658	1222	2022	181	1777	1919
			domInteractive	17	11	93	12	14	36
			firstPaint	169	62	377	56	201	286
			backgroundConnect	30	14	349	34	28	65
			firstReactRender	194	93	401	101	181	395
			getState	40	4	312	84	12	280
			initialActions	7	2	170	17	6	12
			loadScripts	1654	1220	2017	180	1775	1911
			setupStore	21	7	303	48	15	28
Firefox	Browserify	Home	uiStartup	1328	1110	1780	102	1397	1493
			load	1143	968	1328	81	1211	1271
			domContentLoaded	1143	968	1328	81	1211	1270
			domInteractive	98	35	273	41	106	204
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	16	362	36	31	58
			firstReactRender	24	19	52	6	23	38
			getState	7	2	64	10	5	32
			initialActions	3	0	41	6	2	15
			loadScripts	1122	954	1312	82	1191	1250
			setupStore	9	3	95	13	6	44
	Webpack	Home	uiStartup	1633	1420	2106	152	1701	1954
			load	1349	1158	1636	109	1415	1563
			domContentLoaded	1349	1157	1635	109	1415	1563
			domInteractive	98	32	271	50	100	256
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	37	20	133	21	38	94
			firstReactRender	55	44	91	7	58	68
			getState	12	4	104	15	11	41
			initialActions	8	0	206	25	3	23
			loadScripts	1321	1133	1612	111	1396	1514
			setupStore	12	5	112	15	9	37

Benchmark value 219 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 235 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2219 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 40 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2583 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 395 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 280 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 204 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 32 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 44 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1633 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 37 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 55 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1954 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 256 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 94 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 68 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 41 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 23 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 37 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 314ms | Sum of p95 exceeds: 741.8ms
Sum of all benchmark exceeds: 1055.8ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -876 Bytes (-0.02%)
ui: 1.78 KiB (0.03%)
common: -68.68 KiB (-0.91%)

app/scripts/lib/state-utils.ts

metamaskbot · 2025-08-13T07:54:31Z

Builds ready [3ffe32b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1142 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1142	1040	1270	64	1194	1265
			load	969	871	1099	58	1016	1072
			domContentLoaded	960	853	1082	58	1007	1064
			domInteractive	17	13	47	7	17	41
			firstPaint	642	79	1093	387	988	1069
			backgroundConnect	210	195	236	8	213	226
			firstReactRender	18	14	37	4	19	31
			getState	10	5	28	5	13	21
			initialActions	4	0	79	10	3	15
			loadScripts	759	654	880	59	803	862
			setupStore	8	5	22	3	8	14
	Webpack	Home	uiStartup	2198	1622	2700	230	2324	2570
			load	1643	1190	2025	180	1745	1914
			domContentLoaded	1635	1178	2000	177	1740	1899
			domInteractive	19	12	97	19	14	75
			firstPaint	174	65	540	70	209	288
			backgroundConnect	32	12	331	33	32	67
			firstReactRender	198	85	411	108	322	383
			getState	25	4	296	60	12	268
			initialActions	7	2	183	18	6	10
			loadScripts	1631	1175	1987	176	1736	1887
			setupStore	31	6	305	70	15	297
Firefox	Browserify	Home	uiStartup	1425	1208	2006	116	1478	1619
			load	1224	1056	1541	92	1285	1385
			domContentLoaded	1224	1056	1540	92	1285	1384
			domInteractive	108	32	285	48	119	222
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	19	83	12	33	63
			firstReactRender	24	20	59	4	25	29
			getState	7	2	69	9	6	19
			initialActions	3	0	43	6	2	13
			loadScripts	1202	1038	1521	92	1262	1361
			setupStore	11	3	192	22	6	47
	Webpack	Home	uiStartup	1537	1358	2044	136	1610	1803
			load	1280	1125	1611	120	1362	1543
			domContentLoaded	1280	1125	1611	120	1362	1543
			domInteractive	94	29	260	51	94	241
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	19	142	13	32	42
			firstReactRender	51	39	63	6	54	61
			getState	9	4	59	8	8	23
			initialActions	4	0	143	14	3	11
			loadScripts	1258	1107	1592	117	1343	1492
			setupStore	10	4	166	18	8	25

Benchmark value 210 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 227 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2198 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 2571 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 75 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 383 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 268 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 297 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1426 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 222 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 47 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 241 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 61 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 263ms | Sum of p95 exceeds: 841.8ms
Sum of all benchmark exceeds: 1104.8ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -804 Bytes (-0.02%)
ui: -725 Bytes (-0.01%)
common: -68.67 KiB (-0.91%)

metamaskbot · 2025-08-13T10:07:20Z

Builds ready [d0328a7]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1153 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1153	1032	1435	71	1189	1283
			load	980	876	1235	67	1011	1104
			domContentLoaded	972	869	1228	67	1005	1097
			domInteractive	16	13	39	4	16	25
			firstPaint	680	88	1169	382	991	1081
			backgroundConnect	213	201	241	7	217	227
			firstReactRender	19	15	37	4	20	29
			getState	10	5	33	7	11	26
			initialActions	4	0	74	8	3	13
			loadScripts	766	665	995	66	801	896
			setupStore	8	5	28	3	8	12
	Webpack	Home	uiStartup	2190	1723	2587	186	2292	2513
			load	1654	1248	1927	153	1728	1879
			domContentLoaded	1648	1244	1913	151	1724	1871
			domInteractive	17	11	90	14	15	63
			firstPaint	166	62	466	71	203	291
			backgroundConnect	25	12	79	11	27	54
			firstReactRender	191	84	386	106	313	382
			getState	27	4	312	68	11	282
			initialActions	5	2	12	2	5	9
			loadScripts	1643	1241	1899	150	1721	1858
			setupStore	23	6	305	57	14	31
Firefox	Browserify	Home	uiStartup	1342	1151	1660	91	1400	1509
			load	1161	1006	1474	85	1210	1347
			domContentLoaded	1161	1006	1473	85	1210	1346
			domInteractive	100	35	263	43	106	212
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	18	92	12	31	60
			firstReactRender	23	20	52	4	24	30
			getState	6	2	39	5	6	16
			initialActions	4	0	37	6	2	17
			loadScripts	1139	992	1405	84	1192	1328
			setupStore	7	3	47	8	6	32
	Webpack	Home	uiStartup	1600	1399	1948	138	1694	1881
			load	1331	1166	1667	111	1407	1553
			domContentLoaded	1330	1165	1666	111	1407	1553
			domInteractive	94	34	277	47	97	243
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	19	75	8	35	44
			firstReactRender	53	41	80	7	57	65
			getState	9	4	42	6	8	25
			initialActions	5	0	109	15	3	14
			loadScripts	1308	1142	1644	111	1383	1533
			setupStore	12	5	124	16	11	51

Benchmark value 214 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 228 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2513 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 64 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 382 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 282 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 212 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 17 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 243 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 51 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 237ms | Sum of p95 exceeds: 562.8ms
Sum of all benchmark exceeds: 799.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 628 Bytes (0.01%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

metamaskbot · 2025-08-13T11:49:24Z

Builds ready [cd1410a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1171 ± 75 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1171	1035	1478	75	1214	1292
			load	994	870	1295	71	1036	1106
			domContentLoaded	987	865	1292	71	1029	1099
			domInteractive	17	13	43	6	17	38
			firstPaint	635	85	1192	407	1008	1104
			backgroundConnect	214	195	340	15	217	226
			firstReactRender	20	14	47	5	21	33
			getState	10	5	33	6	12	24
			initialActions	3	0	53	6	2	8
			loadScripts	780	663	955	65	825	890
			setupStore	8	4	25	3	8	12
	Webpack	Home	uiStartup	2199	1656	2599	182	2282	2530
			load	1671	1224	1978	159	1752	1908
			domContentLoaded	1665	1220	1974	158	1745	1897
			domInteractive	18	11	95	18	14	76
			firstPaint	188	65	1689	166	201	318
			backgroundConnect	28	13	316	31	28	46
			firstReactRender	178	88	516	89	161	390
			getState	26	4	294	64	11	263
			initialActions	5	2	18	3	5	9
			loadScripts	1661	1215	1964	157	1743	1892
			setupStore	11	6	31	4	12	17
Firefox	Browserify	Home	uiStartup	1370	1191	1772	103	1423	1566
			load	1180	1040	1488	81	1229	1316
			domContentLoaded	1179	1040	1488	81	1229	1315
			domInteractive	103	33	348	55	102	230
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	19	90	12	33	60
			firstReactRender	24	20	62	6	24	32
			getState	6	2	51	7	6	20
			initialActions	3	0	35	5	3	12
			loadScripts	1157	1026	1469	81	1207	1296
			setupStore	9	3	63	11	6	36
	Webpack	Home	uiStartup	1684	1444	2127	152	1787	1947
			load	1407	1176	1723	119	1487	1638
			domContentLoaded	1407	1175	1722	119	1487	1638
			domInteractive	98	31	275	46	101	250
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	19	117	13	36	56
			firstReactRender	55	42	84	8	60	67
			getState	12	4	135	16	9	27
			initialActions	4	0	76	8	3	14
			loadScripts	1382	1153	1701	117	1460	1578
			setupStore	10	5	141	15	8	24

Benchmark value 214 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 227 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 8 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2199 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 2531 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 76 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 390 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 263 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 230 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1684 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1408 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1407 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 55 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1383 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1947 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 250 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 56 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 397ms | Sum of p95 exceeds: 597.8ms
Sum of all benchmark exceeds: 994.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 709 Bytes (0.01%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

app/scripts/lib/state-utils.ts

Gudahtt

LGTM!

lwin-kyaw

LGTM!

metamaskbot · 2025-08-13T17:23:06Z

Builds ready [0dd48d5]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1190 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1190	1065	1432	71	1239	1309
			load	1006	882	1179	65	1054	1120
			domContentLoaded	997	877	1171	66	1051	1109
			domInteractive	18	14	47	6	17	33
			firstPaint	641	82	1178	405	1018	1096
			backgroundConnect	216	202	265	10	219	235
			firstReactRender	21	14	57	7	22	32
			getState	11	4	65	8	12	26
			initialActions	3	0	48	6	2	11
			loadScripts	789	676	958	65	842	893
			setupStore	8	4	17	2	8	11
	Webpack	Home	uiStartup	2261	1696	2707	233	2415	2613
			load	1696	1252	2045	204	1838	1967
			domContentLoaded	1689	1246	2030	202	1828	1961
			domInteractive	18	12	101	15	15	57
			firstPaint	180	79	387	61	214	314
			backgroundConnect	28	15	71	10	33	52
			firstReactRender	194	89	415	103	190	394
			getState	32	5	290	73	12	274
			initialActions	8	2	305	30	7	9
			loadScripts	1684	1244	2017	201	1824	1952
			setupStore	17	6	311	41	13	22
Firefox	Browserify	Home	uiStartup	1294	1113	1684	108	1353	1503
			load	1108	970	1288	75	1173	1257
			domContentLoaded	1108	969	1288	75	1173	1257
			domInteractive	92	33	259	38	99	189
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	28	16	72	12	30	58
			firstReactRender	23	20	51	5	22	32
			getState	8	2	83	12	6	32
			initialActions	5	0	168	17	2	14
			loadScripts	1088	956	1272	74	1149	1237
			setupStore	9	3	74	12	6	34
	Webpack	Home	uiStartup	1558	1364	2006	124	1605	1833
			load	1295	1124	1568	101	1366	1493
			domContentLoaded	1294	1124	1568	101	1365	1492
			domInteractive	93	31	282	48	95	242
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	20	89	9	33	43
			firstReactRender	53	41	72	7	58	68
			getState	11	4	164	17	8	26
			initialActions	4	0	21	5	3	15
			loadScripts	1272	1106	1551	100	1344	1472
			setupStore	9	5	43	7	8	27

Benchmark value 216 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 235 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2262 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 32 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2613 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 58 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 394 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 274 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 32 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 54 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 242 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 68 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 316ms | Sum of p95 exceeds: 635.8ms
Sum of all benchmark exceeds: 951.8ms

seaona · 2025-08-14T07:59:08Z

✔️ I verified the fix on the RC and it looks good.
Both keys are now removed from the State Logs: 'encryptionKey', 'encryptionSalt'

matthiasgeihs added the team-web3auth Web3Auth team label Aug 11, 2025

matthiasgeihs force-pushed the mg/sanitize-sensitive-items branch 2 times, most recently from 75b2bd9 to 8256aa4 Compare August 12, 2025 13:39

github-actions bot added the size-S label Aug 12, 2025

matthiasgeihs force-pushed the mg/sanitize-sensitive-items branch 3 times, most recently from 621c9da to ee2a368 Compare August 12, 2025 15:39

matthiasgeihs changed the title ~~Sanitize sensitive items from state~~ fix: sanitize sensitive items from state Aug 12, 2025

matthiasgeihs changed the title ~~fix: sanitize sensitive items from state~~ fix: sanitize sensitive items from UI state Aug 12, 2025

matthiasgeihs force-pushed the mg/sanitize-sensitive-items branch from ee2a368 to 936c5ac Compare August 13, 2025 07:03

lwin-kyaw reviewed Aug 13, 2025

View reviewed changes

app/scripts/lib/state-utils.ts Show resolved Hide resolved

lwin-kyaw reviewed Aug 13, 2025

View reviewed changes

app/scripts/lib/state-utils.ts Outdated Show resolved Hide resolved

matthiasgeihs force-pushed the mg/sanitize-sensitive-items branch 2 times, most recently from cb9d0b8 to 3ffe32b Compare August 13, 2025 07:29

matthiasgeihs marked this pull request as ready for review August 13, 2025 07:57

This comment was marked as outdated.

Sign in to view

matthiasgeihs force-pushed the mg/sanitize-sensitive-items branch from 627ac12 to d0328a7 Compare August 13, 2025 09:42

This comment was marked as outdated.

Sign in to view

matthiasgeihs force-pushed the mg/sanitize-sensitive-items branch from d0328a7 to cd1410a Compare August 13, 2025 11:22

This comment was marked as outdated.

Sign in to view

matthiasgeihs added the Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. label Aug 13, 2025

Gudahtt reviewed Aug 13, 2025

View reviewed changes

app/scripts/lib/state-utils.ts Show resolved Hide resolved

Gudahtt previously approved these changes Aug 13, 2025

View reviewed changes

matthiasgeihs dismissed Gudahtt’s stale review via 10c0533 August 13, 2025 16:30

github-actions bot added size-M and removed size-S labels Aug 13, 2025

Gudahtt approved these changes Aug 13, 2025

View reviewed changes

lwin-kyaw approved these changes Aug 13, 2025

View reviewed changes

matthiasgeihs force-pushed the mg/sanitize-sensitive-items branch from 10c0533 to 631c7dd Compare August 13, 2025 16:49

matthiasgeihs enabled auto-merge August 13, 2025 16:49

matthiasgeihs added 5 commits August 13, 2025 18:57

state-utils.ts: sanitize more

7dd7d0e

delete instead of replace accessToken in srpSessionData

44cba36

sanitize nodeAuthTokens and socialBackupsMetadata

6983b88

update sanitization after bumping seedless controller

894a96a

add unit tests

0dd48d5

matthiasgeihs force-pushed the mg/sanitize-sensitive-items branch from 631c7dd to 0dd48d5 Compare August 13, 2025 16:57

matthiasgeihs added this pull request to the merge queue Aug 13, 2025

Merged via the queue into main with commit 5e642ca Aug 13, 2025
272 of 274 checks passed

matthiasgeihs deleted the mg/sanitize-sensitive-items branch August 13, 2025 17:58

github-actions bot locked and limited conversation to collaborators Aug 13, 2025

metamaskbot added the release-13.2.0 Issue or pull request that will be included in release 13.2.0 label Aug 13, 2025

fix: sanitize sensitive items from UI state #35003

fix: sanitize sensitive items from UI state #35003

Conversation

matthiasgeihs commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

metamaskbot commented Aug 11, 2025

Uh oh!

metamaskbot commented Aug 12, 2025

Uh oh!

metamaskbot commented Aug 12, 2025

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Aug 13, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Aug 13, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Aug 13, 2025

Uh oh!

Uh oh!

Gudahtt left a comment

Choose a reason for hiding this comment

Uh oh!

lwin-kyaw left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Aug 13, 2025

Uh oh!

Uh oh!

seaona commented Aug 14, 2025

Uh oh!

Uh oh!

matthiasgeihs commented Aug 11, 2025 •

edited

Loading