refactor(5557): migrate onboarding/ to react-router-v5-compat #35005

DDDDDanica · 2025-08-11T18:17:08Z

Description

Migrate onboarding flow components to React Router v6 compatibility.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5557

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-08-11T18:17:22Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-08-11T18:19:29Z

✨ Files requiring CODEOWNER review ✨

🔐 @MetaMask/web3auth (29 files, +410 -298)

📁 ui/
- 📁 pages/
  - 📁 onboarding-flow/
    - 📁 account-exist/
      - 📄 account-exist.test.tsx +18 -12
      - 📄 account-exist.tsx +6 -6
    - 📁 account-not-found/
      - 📄 account-not-found.test.tsx +18 -11
      - 📄 account-not-found.tsx +6 -6
    - 📁 create-password/
      - 📄 create-password.js +16 -15
      - 📄 create-password.test.js +22 -13
    - 📁 creation-successful/
      - 📄 creation-successful.js +6 -6
      - 📄 creation-successful.test.js +13 -10
    - 📁 download-app/
      - 📄 download-app.test.tsx +20 -20
      - 📄 download-app.tsx +5 -5
    - 📁 import-srp/
      - 📄 import-srp.js +7 -7
      - 📄 import-srp.stories.tsx +3 -6
      - 📄 import-srp.test.js +14 -13
    - 📁 metametrics/
      - 📄 metametrics.js +4 -4
      - 📄 metametrics.test.js +8 -11
    - 📁 onboarding-app-header/
      - 📄 onboarding-app-header.js +1 -1
      - 📄 onboarding-app-header.test.js +1 -1
    - 📁 onboarding-flow-switch/
      - 📄 onboarding-flow-switch.js +14 -13
      - 📄 onboarding-flow-switch.test.js +78 -13
    - 📁 pin-extension/
      - 📄 pin-extension.js +5 -5
      - 📄 pin-extension.test.js +18 -20
    - 📁 privacy-settings/
      - 📄 privacy-settings.js +3 -3
      - 📄 privacy-settings.test.js +1 -1
    - 📁 recovery-phrase/
      - 📄 confirm-recovery-phrase.js +14 -10
      - 📄 confirm-recovery-phrase.test.js +15 -12
      - 📄 recovery-phrase-chips.test.js +1 -1
      - 📄 reveal-recovery-phrase.tsx +9 -8
      - 📄 onboarding-flow.js +39 -44
      - 📄 onboarding-flow.test.js +45 -21

metamaskbot · 2025-08-11T20:37:58Z

Builds ready [c08b322]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1257 ± 88 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1257	1121	1558	88	1297	1458
			load	1058	933	1329	84	1108	1249
			domContentLoaded	1050	925	1321	83	1101	1241
			domInteractive	18	14	36	4	18	28
			firstPaint	683	105	1332	426	1062	1148
			backgroundConnect	227	212	282	10	232	241
			firstReactRender	22	16	47	6	24	35
			getState	13	5	80	9	14	27
			initialActions	6	0	85	14	5	28
			loadScripts	831	707	1098	80	880	996
			setupStore	8	5	21	2	9	12
	Webpack	Home	uiStartup	2500	1953	3023	218	2630	2896
			load	1881	1336	2442	215	2011	2187
			domContentLoaded	1874	1330	2437	215	2006	2179
			domInteractive	20	13	104	16	17	53
			firstPaint	204	66	713	93	246	390
			backgroundConnect	40	13	364	46	36	89
			firstReactRender	198	94	443	96	222	403
			getState	26	5	267	55	16	257
			initialActions	7	2	189	19	7	12
			loadScripts	1869	1327	2433	213	2004	2166
			setupStore	34	7	313	73	18	296
Firefox	Browserify	Home	uiStartup	1281	1091	1621	109	1325	1501
			load	1101	955	1397	77	1157	1227
			domContentLoaded	1101	955	1397	77	1157	1227
			domInteractive	95	33	297	49	96	212
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	15	128	16	31	57
			firstReactRender	23	19	50	4	23	31
			getState	8	2	72	11	5	34
			initialActions	2	0	13	3	2	9
			loadScripts	1079	941	1382	76	1138	1190
			setupStore	10	3	229	24	6	34
	Webpack	Home	uiStartup	1572	1352	1983	149	1671	1863
			load	1309	1121	1673	126	1400	1549
			domContentLoaded	1309	1121	1673	126	1400	1548
			domInteractive	95	30	271	49	95	254
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	18	70	10	34	51
			firstReactRender	54	41	69	6	59	65
			getState	11	4	132	17	8	49
			initialActions	4	0	110	11	3	15
			loadScripts	1287	1097	1650	126	1365	1525
			setupStore	11	5	132	15	9	25

Benchmark value 1257 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 227 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 7 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 832 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1458 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1249 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1241 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 241 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 28 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 997 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2501 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1881 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1874 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 204 exceeds gate value 199 for chrome webpack home mean firstPaint
Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1869 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 35 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2896 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2187 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2180 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 390 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 257 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2166 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 296 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 212 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 34 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 55 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 254 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 49 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 1109ms | Sum of p95 exceeds: 2062.8ms
Sum of all benchmark exceeds: 3171.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: 231 Bytes (0%)
common: 10 Bytes (0%)

metamaskbot · 2025-08-12T14:35:05Z

❌ test-e2e-chrome-api-specs failed. View the html report here.

metamaskbot · 2025-08-12T14:45:16Z

Builds ready [f19fc35]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1181 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1181	1078	1377	63	1231	1290
			load	1003	885	1167	61	1051	1115
			domContentLoaded	995	879	1151	61	1041	1107
			domInteractive	17	14	34	4	17	24
			firstPaint	677	74	1166	405	1023	1105
			backgroundConnect	218	204	241	8	222	233
			firstReactRender	20	14	42	5	21	34
			getState	10	5	39	6	11	24
			initialActions	4	0	64	9	3	18
			loadScripts	785	678	934	60	835	891
			setupStore	8	5	21	2	8	13
	Webpack	Home	uiStartup	2234	1663	2640	177	2324	2551
			load	1677	1212	1975	146	1742	1915
			domContentLoaded	1670	1207	1966	145	1736	1899
			domInteractive	18	11	88	16	14	65
			firstPaint	167	59	359	61	202	293
			backgroundConnect	28	15	332	32	27	49
			firstReactRender	218	92	438	112	363	395
			getState	29	4	309	70	12	280
			initialActions	5	2	18	2	6	9
			loadScripts	1666	1204	1954	143	1733	1887
			setupStore	17	6	303	39	14	24
Firefox	Browserify	Home	uiStartup	1342	1114	1786	121	1412	1626
			load	1156	974	1406	91	1217	1312
			domContentLoaded	1155	974	1406	91	1217	1312
			domInteractive	100	33	430	54	105	211
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	16	127	13	32	58
			firstReactRender	25	20	54	7	24	47
			getState	7	2	73	10	5	26
			initialActions	4	0	163	17	2	11
			loadScripts	1135	959	1388	89	1196	1294
			setupStore	7	3	74	9	6	26
	Webpack	Home	uiStartup	1566	1385	2067	134	1648	1824
			load	1300	1143	1635	108	1374	1494
			domContentLoaded	1300	1143	1635	108	1373	1493
			domInteractive	90	30	285	47	91	249
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	19	199	21	33	51
			firstReactRender	55	41	70	6	59	65
			getState	10	4	58	8	9	26
			initialActions	4	1	97	10	3	13
			loadScripts	1278	1125	1611	109	1352	1474
			setupStore	9	5	103	11	9	28

Benchmark value 218 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 233 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2235 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 30 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2551 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 395 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 280 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 211 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 55 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 249 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 291ms | Sum of p95 exceeds: 597.8ms
Sum of all benchmark exceeds: 888.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -1.34 KiB (-0.03%)
ui: 358 Bytes (0.01%)
common: 2.37 KiB (0.03%)

metamaskbot · 2025-08-12T16:03:18Z

Builds ready [492ad5e]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1197 ± 66 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1197	1083	1503	66	1234	1310
			load	1009	902	1200	60	1043	1114
			domContentLoaded	1001	896	1190	60	1037	1108
			domInteractive	17	14	39	4	17	26
			firstPaint	581	122	1199	396	1007	1062
			backgroundConnect	221	206	271	10	225	239
			firstReactRender	21	15	45	6	23	34
			getState	13	5	94	12	15	31
			initialActions	4	0	70	10	3	17
			loadScripts	788	679	970	59	820	889
			setupStore	8	4	17	2	8	11
	Webpack	Home	uiStartup	2174	1663	2596	181	2269	2490
			load	1617	1194	1901	150	1698	1853
			domContentLoaded	1608	1185	1887	148	1690	1826
			domInteractive	17	11	80	15	14	64
			firstPaint	174	57	374	58	209	292
			backgroundConnect	34	13	431	51	32	55
			firstReactRender	219	86	386	118	368	381
			getState	34	4	309	78	12	280
			initialActions	5	2	25	4	6	13
			loadScripts	1604	1182	1875	147	1687	1815
			setupStore	33	6	308	74	15	289
Firefox	Browserify	Home	uiStartup	1325	1136	1738	104	1391	1500
			load	1134	994	1443	79	1179	1264
			domContentLoaded	1133	993	1443	79	1179	1263
			domInteractive	98	33	273	44	106	209
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	17	82	12	34	59
			firstReactRender	28	20	160	16	25	52
			getState	9	2	106	15	5	40
			initialActions	3	0	27	4	2	12
			loadScripts	1112	977	1418	79	1162	1239
			setupStore	10	3	191	23	6	33
	Webpack	Home	uiStartup	1657	1421	2173	154	1735	1935
			load	1376	1170	1694	122	1458	1604
			domContentLoaded	1376	1169	1694	122	1457	1604
			domInteractive	103	32	285	52	104	262
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	18	115	15	36	61
			firstReactRender	57	44	83	7	61	70
			getState	11	4	186	19	9	28
			initialActions	3	1	25	4	3	13
			loadScripts	1351	1139	1668	122	1436	1582
			setupStore	11	5	108	14	9	36

Benchmark value 221 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 240 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 33 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2491 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 64 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 381 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 280 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 289 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 209 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 40 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1658 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 58 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 262 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 61 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 70 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 36 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 311ms | Sum of p95 exceeds: 810.8ms
Sum of all benchmark exceeds: 1121.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -1.34 KiB (-0.03%)
ui: 354 Bytes (0%)
common: 2.37 KiB (0.03%)

metamaskbot · 2025-09-01T15:07:23Z

Builds ready [95741f3]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1219 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1219	1105	1451	67	1268	1345
			load	1051	914	1265	70	1094	1187
			domContentLoaded	1043	904	1257	69	1085	1178
			domInteractive	17	13	46	6	17	36
			firstPaint	690	136	1267	424	1072	1182
			backgroundConnect	238	225	284	8	241	252
			firstReactRender	28	16	127	19	28	51
			getState	16	5	84	12	20	30
			initialActions	7	1	69	11	6	24
			loadScripts	813	669	1020	69	851	951
			setupStore	9	6	31	4	9	17
	Webpack	Home	uiStartup	2019	1530	2492	252	2198	2456
			load	1625	1259	1961	196	1740	1924
			domContentLoaded	1616	1245	1950	195	1734	1897
			domInteractive	17	12	84	13	14	49
			firstPaint	165	65	395	61	196	283
			backgroundConnect	33	16	326	31	35	62
			firstReactRender	91	38	324	63	90	308
			getState	42	5	327	86	15	284
			initialActions	6	2	23	3	7	10
			loadScripts	1611	1243	1939	194	1727	1885
			setupStore	12	6	31	4	13	20
Firefox	Browserify	Home	uiStartup	1388	1183	1779	106	1453	1567
			load	1202	1044	1421	78	1255	1340
			domContentLoaded	1202	1044	1421	78	1255	1340
			domInteractive	114	32	276	47	124	246
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	20	93	13	35	68
			firstReactRender	26	22	60	5	28	32
			getState	6	2	86	9	6	10
			initialActions	5	0	189	19	3	11
			loadScripts	1177	1029	1401	78	1232	1316
			setupStore	11	4	214	22	8	32
	Webpack	Home	uiStartup	1547	1364	2052	141	1632	1845
			load	1323	1153	1668	122	1416	1576
			domContentLoaded	1323	1153	1667	122	1416	1576
			domInteractive	109	35	309	55	103	271
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	20	51	7	37	46
			firstReactRender	43	31	52	4	46	49
			getState	6	2	59	6	6	10
			initialActions	3	1	16	2	3	8
			loadScripts	1300	1135	1646	124	1395	1554
			setupStore	9	6	28	4	9	16

Benchmark value 238 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 7 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1183 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 253 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 51 exceeds gate value 45 for chrome browserify home p95 firstReactRender
Benchmark value 24 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 951 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 43 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2457 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 284 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 114 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 246 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 271 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 298ms | Sum of p95 exceeds: 558.8ms
Sum of all benchmark exceeds: 856.8ms

metamaskbot · 2025-09-02T12:10:27Z

📊 Page Load Benchmark Results

Current Commit: f711cea | Date: 9/2/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

pageLoadTime-> current mean value: 1.27s (±60ms) 🟡 | historical mean value: 1.30s ⬇️ (historical data)
domContentLoaded-> current mean value: 959ms (±54ms) 🟢 | historical mean value: 980ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 85ms (±15ms) 🟢 | historical mean value: 92ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.27s	60ms	1.25s	1.85s	1.31s	1.85s
domContentLoaded	959ms	54ms	936ms	1.48s	996ms	1.48s
firstPaint	85ms	15ms	72ms	172ms	116ms	172ms
firstContentfulPaint	85ms	15ms	72ms	172ms	116ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-02T12:17:50Z

Builds ready [00c8214]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1209 ± 56 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1209	1094	1477	56	1235	1299
			load	1044	927	1291	56	1074	1133
			domContentLoaded	1037	921	1285	57	1067	1128
			domInteractive	17	13	44	6	16	38
			firstPaint	624	75	1290	420	1040	1123
			backgroundConnect	243	228	327	10	247	253
			firstReactRender	24	15	71	8	26	40
			getState	13	5	84	9	16	23
			initialActions	4	0	21	3	5	11
			loadScripts	801	684	966	53	835	894
			setupStore	9	6	23	3	10	16
	Webpack	Home	uiStartup	2071	1542	2675	258	2251	2533
			load	1665	1243	2080	194	1787	1963
			domContentLoaded	1654	1229	2063	193	1780	1941
			domInteractive	18	12	91	16	14	74
			firstPaint	165	63	503	67	195	275
			backgroundConnect	34	15	349	34	33	64
			firstReactRender	90	36	332	66	85	315
			getState	34	4	301	73	14	280
			initialActions	7	2	172	17	7	11
			loadScripts	1647	1226	1964	187	1777	1922
			setupStore	16	6	292	28	15	25
Firefox	Browserify	Home	uiStartup	1375	1186	1877	120	1437	1586
			load	1193	1032	1419	84	1259	1334
			domContentLoaded	1193	1032	1419	84	1259	1333
			domInteractive	110	31	312	48	127	223
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	19	104	13	34	55
			firstReactRender	27	21	61	5	29	34
			getState	8	2	142	16	6	16
			initialActions	6	0	182	24	3	7
			loadScripts	1170	1015	1390	82	1236	1300
			setupStore	11	4	181	20	8	45
	Webpack	Home	uiStartup	1565	1382	2121	163	1650	1870
			load	1337	1162	1717	136	1432	1621
			domContentLoaded	1336	1162	1717	136	1432	1620
			domInteractive	107	31	448	65	100	281
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	21	90	11	38	51
			firstReactRender	42	36	53	4	45	49
			getState	7	3	65	6	6	12
			initialActions	3	0	15	2	3	6
			loadScripts	1313	1144	1675	136	1413	1594
			setupStore	9	6	29	4	9	19

Benchmark value 244 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 254 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 34 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2533 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 75 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 280 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 223 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 7 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 45 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 281 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 286ms | Sum of p95 exceeds: 613.8ms
Sum of all benchmark exceeds: 899.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: 338 Bytes (0%)
common: 10 Bytes (0%)

metamaskbot · 2025-09-02T14:35:47Z

📊 Page Load Benchmark Results

Current Commit: 8bdf803 | Date: 9/2/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

pageLoadTime-> current mean value: 1.25s (±71ms) 🟡 | historical mean value: 1.30s ⬇️ (historical data)
domContentLoaded-> current mean value: 946ms (±68ms) 🟢 | historical mean value: 983ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 82ms (±17ms) 🟢 | historical mean value: 94ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.25s	71ms	1.21s	1.67s	1.30s	1.67s
domContentLoaded	946ms	68ms	904ms	1.35s	994ms	1.35s
firstPaint	82ms	17ms	64ms	188ms	128ms	188ms
firstContentfulPaint	82ms	17ms	64ms	188ms	128ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-02T14:42:53Z

Builds ready [ccfd9ac]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1257 ± 66 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1257	1125	1512	66	1307	1363
			load	1089	982	1323	61	1121	1186
			domContentLoaded	1081	973	1295	61	1110	1181
			domInteractive	18	13	46	5	18	22
			firstPaint	627	86	1205	436	1080	1167
			backgroundConnect	252	238	282	9	256	270
			firstReactRender	26	17	47	7	27	44
			getState	14	5	78	9	16	27
			initialActions	4	0	18	3	6	14
			loadScripts	837	730	1044	60	871	944
			setupStore	10	6	29	4	11	18
	Webpack	Home	uiStartup	2020	1485	2535	256	2178	2469
			load	1617	1194	1981	193	1739	1871
			domContentLoaded	1608	1182	1960	192	1732	1865
			domInteractive	16	12	76	11	14	39
			firstPaint	175	67	390	59	204	294
			backgroundConnect	34	17	345	45	29	65
			firstReactRender	89	37	347	66	87	314
			getState	38	5	320	80	15	278
			initialActions	9	2	173	23	6	12
			loadScripts	1604	1180	1948	191	1730	1854
			setupStore	14	6	254	24	13	20
Firefox	Browserify	Home	uiStartup	1455	1251	1743	104	1498	1649
			load	1261	1084	1559	82	1308	1419
			domContentLoaded	1260	1083	1559	82	1308	1419
			domInteractive	122	34	298	60	134	282
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	35	20	114	17	35	79
			firstReactRender	28	22	44	4	29	38
			getState	7	3	38	6	6	18
			initialActions	6	1	192	19	4	16
			loadScripts	1234	1066	1457	78	1282	1392
			setupStore	11	5	101	13	9	37
	Webpack	Home	uiStartup	1520	1374	2056	124	1564	1773
			load	1292	1176	1616	101	1334	1540
			domContentLoaded	1292	1176	1615	101	1333	1540
			domInteractive	102	32	317	49	98	282
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	20	81	8	36	43
			firstReactRender	43	35	65	5	45	54
			getState	6	3	23	4	6	15
			initialActions	5	1	115	14	3	13
			loadScripts	1268	1150	1590	101	1307	1520
			setupStore	10	6	80	9	9	27

Benchmark value 1257 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1090 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1081 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 252 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 838 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1181 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 271 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 944 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 38 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2469 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 278 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1456 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1261 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1261 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 123 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1234 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 282 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 79 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 16 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 37 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 282 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 54 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 478ms | Sum of p95 exceeds: 635.8ms
Sum of all benchmark exceeds: 1113.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: 9.92 KiB (0.13%)
common: 1.54 KiB (0.02%)

metamaskbot · 2025-09-02T15:12:37Z

📊 Page Load Benchmark Results

Current Commit: bf36d40 | Date: 9/2/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

pageLoadTime-> current mean value: 1.30s (±31ms) 🟡 | historical mean value: 1.30s ⬆️ (historical data)
domContentLoaded-> current mean value: 978ms (±26ms) 🟢 | historical mean value: 982ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 88ms (±22ms) 🟢 | historical mean value: 94ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.30s	31ms	1.26s	1.45s	1.35s	1.45s
domContentLoaded	978ms	26ms	946ms	1.10s	1.03s	1.10s
firstPaint	88ms	22ms	72ms	260ms	132ms	260ms
firstContentfulPaint	88ms	22ms	72ms	260ms	132ms	260ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-02T15:19:31Z

Builds ready [b10df64]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1219 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1219	1099	1393	60	1241	1341
			load	1058	956	1203	57	1079	1182
			domContentLoaded	1050	950	1195	58	1071	1173
			domInteractive	17	13	60	6	17	31
			firstPaint	684	86	1202	429	1074	1182
			backgroundConnect	246	233	296	10	249	265
			firstReactRender	24	17	43	5	26	36
			getState	14	5	59	9	19	31
			initialActions	5	0	78	8	6	14
			loadScripts	811	710	953	56	832	936
			setupStore	10	6	19	3	11	17
	Webpack	Home	uiStartup	2042	1584	2681	300	2257	2561
			load	1641	1278	2094	236	1824	1990
			domContentLoaded	1631	1271	2077	235	1816	1979
			domInteractive	17	12	74	12	15	47
			firstPaint	173	62	419	63	202	288
			backgroundConnect	34	14	294	33	33	66
			firstReactRender	76	36	313	44	82	107
			getState	34	4	334	75	14	281
			initialActions	7	2	169	17	6	10
			loadScripts	1628	1268	2065	234	1813	1966
			setupStore	17	6	292	37	14	25
Firefox	Browserify	Home	uiStartup	1795	1470	2290	163	1879	2139
			load	1557	1251	1995	137	1638	1821
			domContentLoaded	1557	1250	1995	137	1637	1821
			domInteractive	142	34	595	79	148	343
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	54	26	259	38	49	150
			firstReactRender	33	25	72	6	35	42
			getState	9	3	114	12	8	18
			initialActions	5	1	87	10	5	14
			loadScripts	1515	1225	1897	136	1602	1793
			setupStore	16	5	232	27	11	67
	Webpack	Home	uiStartup	1677	1429	2110	154	1814	1938
			load	1420	1196	1688	133	1535	1625
			domContentLoaded	1419	1195	1687	133	1535	1625
			domInteractive	113	41	304	47	115	238
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	24	54	7	38	49
			firstReactRender	48	38	76	6	52	58
			getState	7	4	20	2	7	11
			initialActions	7	1	230	25	4	6
			loadScripts	1395	1168	1660	133	1507	1600
			setupStore	11	6	84	10	10	24

Benchmark value 247 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1182 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 266 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2561 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 281 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1795 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1558 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1557 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 142 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 54 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 33 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1515 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 2139 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1821 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1821 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 343 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 150 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 1793 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Benchmark value 67 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1678 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1420 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1420 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 113 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 49 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1395 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1938 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 238 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 58 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 1852ms | Sum of p95 exceeds: 2284.8ms
Sum of all benchmark exceeds: 4136.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: 9.92 KiB (0.13%)
common: 1.54 KiB (0.02%)

lwin-kyaw

LGTM!

metamaskbot added the team-extension-platform Extension Platform team label Aug 11, 2025

DDDDDanica self-assigned this Aug 11, 2025

github-actions bot added the size-L label Aug 11, 2025

DDDDDanica force-pushed the refactor/5557-onboarding branch 2 times, most recently from 2ecb43e to 0eedfce Compare August 11, 2025 18:42

refactor(5557): migrate onboarding/ to react-router-v5-compat

c08b322

DDDDDanica force-pushed the refactor/5557-onboarding branch from 0eedfce to c08b322 Compare August 11, 2025 18:42

DDDDDanica removed the size-L label Aug 11, 2025

DDDDDanica marked this pull request as ready for review August 11, 2025 22:08

DDDDDanica requested a review from a team as a code owner August 11, 2025 22:08

This comment was marked as outdated.

Sign in to view

github-actions bot added the size-L label Aug 12, 2025

DDDDDanica force-pushed the refactor/5557-onboarding branch 5 times, most recently from 8e8a163 to 2dc1083 Compare August 12, 2025 14:19

refactor(5560): fix navigate replace missing

f19fc35

DDDDDanica force-pushed the refactor/5557-onboarding branch from 2dc1083 to f19fc35 Compare August 12, 2025 14:19

This comment was marked as outdated.

Sign in to view

refactor(5557): fix Trailing Slash Issue in Route Navigation

90146fd

DDDDDanica force-pushed the refactor/5557-onboarding branch from 492ad5e to 90146fd Compare August 12, 2025 18:05

DDDDDanica added 2 commits August 12, 2025 19:06

Merge remote-tracking branch 'origin/main' into refactor/5557-onboarding

c1231bf

refactor(5557): remove unneeded space

0b688bb

itsyoboieltr previously approved these changes Sep 1, 2025

View reviewed changes

HowardBraham enabled auto-merge September 1, 2025 19:44

DDDDDanica removed the request for review from lwin-kyaw September 2, 2025 10:21

DDDDDanica added 2 commits September 2, 2025 12:45

Merge branch 'main' into refactor/5557-onboarding

4d7480a

refactor(5557): refactor navigate to use pathname and search option

00c8214

DDDDDanica dismissed stale reviews from HowardBraham and itsyoboieltr via 00c8214 September 2, 2025 11:51

This comment was marked as outdated.

Sign in to view

DDDDDanica added 2 commits September 2, 2025 15:08

refactor(5557): remove wrong routes

9c93ae4

refactor(5557): resolve failing unit tests

ccfd9ac

This comment was marked as outdated.

Sign in to view

refactor(5557): fix Test Mismatch: Navigate Function Argument Type

b10df64

itsyoboieltr approved these changes Sep 2, 2025

View reviewed changes

DDDDDanica requested review from lwin-kyaw and HowardBraham September 2, 2025 20:53

HowardBraham approved these changes Sep 2, 2025

View reviewed changes

lwin-kyaw approved these changes Sep 3, 2025

View reviewed changes

HowardBraham added this pull request to the merge queue Sep 3, 2025

Merged via the queue into main with commit e47af11 Sep 3, 2025
145 checks passed

HowardBraham deleted the refactor/5557-onboarding branch September 3, 2025 01:35

github-actions bot locked and limited conversation to collaborators Sep 3, 2025

metamaskbot added the release-13.4.0 Issue or pull request that will be included in release 13.4.0 label Sep 3, 2025

refactor(5557): migrate onboarding/ to react-router-v5-compat #35005

refactor(5557): migrate onboarding/ to react-router-v5-compat #35005

Conversation

DDDDDanica commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

metamaskbot commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Aug 11, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Aug 12, 2025

Uh oh!

metamaskbot commented Aug 12, 2025

Uh oh!

metamaskbot commented Aug 12, 2025

Uh oh!

metamaskbot commented Sep 1, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Sep 2, 2025

📊 Page Load Benchmark Results

📄 https://metamask.github.io/test-dapp/

Summary

Uh oh!

metamaskbot commented Sep 2, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Sep 2, 2025

📊 Page Load Benchmark Results

📄 https://metamask.github.io/test-dapp/

Summary

Uh oh!

metamaskbot commented Sep 2, 2025

Uh oh!

metamaskbot commented Sep 2, 2025

📊 Page Load Benchmark Results

📄 https://metamask.github.io/test-dapp/

Summary

Uh oh!

metamaskbot commented Sep 2, 2025

Uh oh!

lwin-kyaw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DDDDDanica commented Aug 11, 2025 •

edited

Loading

metamaskbot commented Aug 11, 2025 •

edited

Loading