fix: show effective gas in swaps QuoteCard cp-13.1.0 #35038

micaelae · 2025-08-12T18:42:58Z

Description

Changes

patch bridge-controller and bridge-status-controller so that the effective gas fees for quotes are used for quote metadata calculations
show the totalNetworkFee instead of the totalMaxNetworkFee in the QuoteCard for accuracy
fix the token alert scanning payload for optimism (typo)

Changelog

CHANGELOG entry:

Related issues

Fixes: #35006

Manual testing steps

Get an EVM swap quote
The quoted network fee should be close to the swap fees on mobile or other aggregators
Get an EVM bridge quote
The quoted network fee should be close to the fees from other aggregators
Get a solana swap quote
The quoted network fee should be close to the fees from other aggregators

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2025-08-12T18:45:10Z

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (5 files, +69 -24)

📁 shared/
- 📁 lib/
  - 📁 bridge/
    - 📄 metrics.ts +1 -1
📁 test/
- 📁 data/
  - 📁 bridge/
    - 📄 mock-bridge-store.ts +5 -2
📁 ui/
- 📁 ducks/
  - 📁 bridge/
    - 📄 selectors.test.ts +45 -18
- 📁 pages/
  - 📁 bridge/
    - 📁 quotes/
      - 📄 bridge-quotes-modal.tsx +11 -1
      - 📄 multichain-bridge-quote-card.tsx +7 -2

metamaskbot · 2025-08-12T19:07:44Z

Builds ready [57a97b9]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1177 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1177	1037	1328	62	1220	1298
			load	1000	881	1164	65	1047	1120
			domContentLoaded	991	878	1157	66	1038	1113
			domInteractive	17	14	48	5	17	25
			firstPaint	626	74	1163	401	1004	1120
			backgroundConnect	219	202	265	10	223	240
			firstReactRender	21	14	48	6	23	35
			getState	12	4	33	7	16	29
			initialActions	4	0	68	8	3	15
			loadScripts	780	645	940	65	827	897
			setupStore	7	5	14	2	8	11
	Webpack	Home	uiStartup	2253	1675	2618	177	2348	2524
			load	1697	1237	1949	142	1764	1876
			domContentLoaded	1690	1231	1915	140	1757	1865
			domInteractive	17	11	98	15	14	60
			firstPaint	179	70	399	62	214	294
			backgroundConnect	29	11	325	32	29	56
			firstReactRender	205	91	428	111	349	387
			getState	35	5	280	75	12	270
			initialActions	5	2	23	3	6	12
			loadScripts	1686	1226	1904	139	1754	1859
			setupStore	23	6	314	57	14	30
Firefox	Browserify	Home	uiStartup	1314	1110	1730	102	1364	1472
			load	1130	977	1492	81	1181	1269
			domContentLoaded	1129	977	1491	81	1180	1268
			domInteractive	100	33	404	53	107	211
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	16	79	12	31	61
			firstReactRender	25	20	55	8	24	53
			getState	7	2	130	13	5	17
			initialActions	2	0	33	4	2	10
			loadScripts	1109	963	1475	80	1163	1242
			setupStore	9	3	56	11	6	37
	Webpack	Home	uiStartup	1650	1426	2085	152	1736	1936
			load	1368	1174	1674	124	1454	1605
			domContentLoaded	1368	1173	1674	124	1453	1605
			domInteractive	103	29	369	58	100	255
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	21	104	15	37	68
			firstReactRender	57	43	87	7	62	68
			getState	11	4	63	11	10	37
			initialActions	6	1	111	16	5	15
			loadScripts	1342	1146	1648	124	1429	1578
			setupStore	11	5	139	15	10	28

Benchmark value 220 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 241 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2254 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2525 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 387 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 270 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 211 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 37 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1651 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 35 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 58 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1936 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 255 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 68 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 68 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 37 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 362ms | Sum of p95 exceeds: 597.8ms
Sum of all benchmark exceeds: 959.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: 230 Bytes (0%)
common: 10 Bytes (0%)

This reverts commit 27c98e7.

metamaskbot · 2025-08-12T20:23:57Z

Builds ready [0619a08]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1168 ± 74 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1168	1053	1434	74	1211	1311
			load	991	871	1214	69	1034	1138
			domContentLoaded	983	865	1209	70	1025	1124
			domInteractive	17	13	48	7	16	37
			firstPaint	662	134	1145	393	1002	1091
			backgroundConnect	216	202	263	8	219	231
			firstReactRender	19	14	38	4	21	28
			getState	12	4	96	12	14	24
			initialActions	2	0	17	3	2	8
			loadScripts	775	665	953	69	824	923
			setupStore	7	4	24	2	8	10
	Webpack	Home	uiStartup	2174	1597	3017	228	2277	2524
			load	1634	1173	2396	190	1728	1900
			domContentLoaded	1624	1168	2384	189	1706	1888
			domInteractive	18	11	100	17	14	64
			firstPaint	175	60	780	92	192	323
			backgroundConnect	34	15	330	51	31	58
			firstReactRender	209	89	423	109	334	387
			getState	20	4	302	49	12	33
			initialActions	5	2	16	2	6	9
			loadScripts	1620	1165	2379	188	1702	1877
			setupStore	17	6	307	40	13	21
Firefox	Browserify	Home	uiStartup	1333	1124	1767	122	1387	1588
			load	1137	981	1413	81	1195	1272
			domContentLoaded	1136	981	1413	81	1194	1271
			domInteractive	100	34	400	57	99	245
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	17	100	15	34	69
			firstReactRender	24	20	54	6	24	34
			getState	7	2	162	16	5	13
			initialActions	3	0	61	7	2	13
			loadScripts	1114	966	1396	79	1173	1237
			setupStore	13	3	226	27	7	53
	Webpack	Home	uiStartup	1648	1415	2237	163	1740	1989
			load	1352	1156	1659	125	1442	1593
			domContentLoaded	1352	1155	1659	125	1442	1592
			domInteractive	101	31	298	50	98	254
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	21	153	16	39	52
			firstReactRender	59	43	91	8	64	70
			getState	14	4	154	20	15	39
			initialActions	5	0	81	9	3	17
			loadScripts	1328	1131	1635	125	1420	1566
			setupStore	16	5	212	28	12	40

Benchmark value 216 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 232 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 8 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2524 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 65 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 387 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 245 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 53 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1648 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 35 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 1989 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 254 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 52 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 70 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 39 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 17 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 40 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 292ms | Sum of p95 exceeds: 613.8ms
Sum of all benchmark exceeds: 905.8ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 43 Bytes (0%)
ui: 74 Bytes (0%)
common: -268 Bytes (0%)

This reverts commit 0619a08.

socket-security · 2025-08-12T22:13:37Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
@metamask/base-controller@8.0.1 ⏵ 8.1.0	⁺¹	⁺¹	⁺⁶
@metamask/bridge-status-controller@37.0.1 ⏵ 38.0.0	⁺¹	⁺¹	⁺¹
@metamask/bridge-controller@37.2.0 ⏵ 39.0.0	⁺¹	⁺¹	⁺¹

View full report

metamaskbot · 2025-08-12T23:17:45Z

Builds ready [4ef064f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1193 ± 81 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1193	1075	1471	81	1244	1347
			load	1017	888	1249	75	1067	1170
			domContentLoaded	1009	875	1235	75	1061	1158
			domInteractive	18	14	48	6	17	35
			firstPaint	617	80	1242	409	1014	1151
			backgroundConnect	219	206	253	9	222	239
			firstReactRender	21	14	43	5	21	34
			getState	11	4	92	11	11	23
			initialActions	3	0	25	4	2	12
			loadScripts	798	664	1011	74	848	946
			setupStore	7	4	13	2	8	11
	Webpack	Home	uiStartup	2259	1676	2719	212	2369	2588
			load	1694	1213	2031	183	1809	1931
			domContentLoaded	1688	1209	2017	182	1804	1927
			domInteractive	17	12	81	12	15	51
			firstPaint	170	63	398	63	212	284
			backgroundConnect	34	13	335	43	31	65
			firstReactRender	181	91	401	83	185	380
			getState	32	4	331	75	13	279
			initialActions	7	2	164	16	7	14
			loadScripts	1684	1207	2004	181	1801	1925
			setupStore	34	7	313	75	16	282
Firefox	Browserify	Home	uiStartup	1282	1092	1714	111	1335	1446
			load	1107	954	1492	89	1151	1236
			domContentLoaded	1107	954	1492	89	1150	1236
			domInteractive	97	29	362	51	98	225
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	16	341	33	29	57
			firstReactRender	23	19	56	5	23	29
			getState	6	2	43	6	5	21
			initialActions	3	0	33	6	2	21
			loadScripts	1084	938	1475	81	1126	1220
			setupStore	8	2	62	10	6	33
	Webpack	Home	uiStartup	1568	1352	2209	143	1630	1834
			load	1308	1131	1668	111	1374	1514
			domContentLoaded	1308	1130	1668	111	1374	1514
			domInteractive	92	31	273	48	91	237
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	28	19	68	8	32	42
			firstReactRender	54	41	81	6	58	64
			getState	11	4	70	11	12	40
			initialActions	7	0	224	26	3	16
			loadScripts	1288	1101	1636	110	1353	1489
			setupStore	10	4	81	9	9	27

Benchmark value 220 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 239 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 947 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2259 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 33 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 35 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2588 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 380 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 279 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 282 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 225 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 21 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 54 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 237 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 40 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 16 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 320ms | Sum of p95 exceeds: 862.8ms
Sum of all benchmark exceeds: 1182.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 290 Bytes (0.01%)
ui: 284 Bytes (0%)
common: 494 Bytes (0.01%)

metamaskbot · 2025-08-12T23:51:27Z

Builds ready [1e2c0c9]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1169 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1169	1065	1350	67	1212	1320
			load	989	886	1165	64	1021	1125
			domContentLoaded	982	878	1160	64	1012	1118
			domInteractive	16	14	41	3	17	23
			firstPaint	617	90	1140	390	995	1083
			backgroundConnect	217	202	240	8	220	235
			firstReactRender	20	14	44	5	21	32
			getState	12	4	89	11	12	28
			initialActions	4	0	74	11	2	15
			loadScripts	773	670	949	63	809	904
			setupStore	8	4	23	3	8	12
	Webpack	Home	uiStartup	2181	1615	2572	198	2270	2500
			load	1648	1180	1909	164	1732	1852
			domContentLoaded	1642	1175	1903	163	1727	1842
			domInteractive	17	11	84	13	14	55
			firstPaint	167	61	351	59	195	303
			backgroundConnect	30	14	329	43	27	51
			firstReactRender	176	91	399	87	169	380
			getState	37	4	306	83	11	284
			initialActions	4	2	10	2	5	8
			loadScripts	1638	1173	1891	162	1725	1831
			setupStore	16	6	302	37	12	20
Firefox	Browserify	Home	uiStartup	1330	1139	1823	120	1402	1529
			load	1147	993	1558	97	1218	1301
			domContentLoaded	1147	992	1558	97	1217	1300
			domInteractive	101	34	294	53	110	243
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	28	17	79	11	32	59
			firstReactRender	24	21	54	6	24	37
			getState	6	2	43	7	5	25
			initialActions	2	0	37	4	2	12
			loadScripts	1126	977	1516	95	1192	1277
			setupStore	10	3	168	19	6	34
	Webpack	Home	uiStartup	1584	1335	2031	145	1679	1821
			load	1322	1112	1674	123	1416	1535
			domContentLoaded	1322	1111	1674	123	1416	1534
			domInteractive	97	31	278	48	100	244
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	20	114	11	32	44
			firstReactRender	55	41	70	7	60	68
			getState	9	4	61	8	8	26
			initialActions	3	0	19	3	3	13
			loadScripts	1301	1094	1654	122	1392	1514
			setupStore	12	5	118	16	8	53

Benchmark value 217 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 236 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 37 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2500 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 380 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 284 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 8 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 243 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 25 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 56 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 244 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 68 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 53 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 248ms | Sum of p95 exceeds: 585.8ms
Sum of all benchmark exceeds: 833.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 290 Bytes (0.01%)
ui: 289 Bytes (0%)
common: 494 Bytes (0.01%)

metamaskbot · 2025-08-13T00:20:21Z

Builds ready [b07a97b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1175 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1175	1058	1414	64	1211	1282
			load	991	874	1139	56	1023	1097
			domContentLoaded	983	869	1132	56	1011	1091
			domInteractive	18	13	48	6	17	33
			firstPaint	638	75	1117	396	1003	1050
			backgroundConnect	219	204	251	8	224	232
			firstReactRender	20	14	49	6	21	33
			getState	11	4	52	7	12	26
			initialActions	3	0	37	5	3	13
			loadScripts	771	660	906	56	801	881
			setupStore	8	4	27	3	9	13
	Webpack	Home	uiStartup	2200	1764	2617	180	2293	2562
			load	1654	1203	1965	157	1719	1909
			domContentLoaded	1647	1196	1954	155	1715	1903
			domInteractive	18	11	110	17	14	74
			firstPaint	167	62	407	62	199	292
			backgroundConnect	29	14	427	42	26	52
			firstReactRender	189	89	408	102	172	382
			getState	31	4	295	73	11	277
			initialActions	5	2	15	2	5	9
			loadScripts	1643	1192	1942	154	1712	1891
			setupStore	25	6	303	62	13	288
Firefox	Browserify	Home	uiStartup	1303	1111	1671	105	1364	1500
			load	1123	970	1405	83	1181	1259
			domContentLoaded	1123	970	1405	83	1181	1259
			domInteractive	99	33	256	40	106	189
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	16	112	16	30	60
			firstReactRender	24	19	54	6	24	39
			getState	6	2	44	8	5	23
			initialActions	3	0	34	5	2	12
			loadScripts	1102	956	1390	82	1155	1241
			setupStore	9	3	103	14	5	45
	Webpack	Home	uiStartup	1633	1393	2179	168	1743	1991
			load	1351	1144	1815	138	1425	1630
			domContentLoaded	1351	1144	1815	138	1425	1628
			domInteractive	103	34	303	54	103	265
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	35	20	265	26	37	49
			firstReactRender	56	42	72	7	61	67
			getState	12	4	129	14	12	28
			initialActions	5	1	100	11	4	18
			loadScripts	1325	1126	1638	130	1400	1588
			setupStore	11	5	182	18	9	31

Benchmark value 219 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 233 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2201 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 32 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2562 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 75 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 382 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 277 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 288 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 45 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1634 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 35 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 57 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1991 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 265 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 18 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 285ms | Sum of p95 exceeds: 900.8ms
Sum of all benchmark exceeds: 1185.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 290 Bytes (0.01%)
ui: 289 Bytes (0%)
common: 494 Bytes (0.01%)

SteP-n-s · 2025-08-13T09:10:56Z

shared/modules/bridge-utils/security-alerts-api.util.ts

@@ -145,7 +145,7 @@ export const CHAIN_ID_TO_SECURITY_API_NAME: Record<
  [CHAIN_IDS.AVALANCHE]: 'avalanche',
  [CHAIN_IDS.BSC]: 'bsc',
  [CHAIN_IDS.ARBITRUM]: 'arbitrum',
-  [CHAIN_IDS.OPTIMISM]: 'optimist',
+  [CHAIN_IDS.OPTIMISM]: 'optimism',


Good catch!

SteP-n-s · 2025-08-14T08:44:19Z

@seaona looks like the PR hasn't been cherry picked yet.

seaona · 2025-08-14T10:49:04Z

@SteP-n-s thank you for keeping eyes on this!! I later realized it and deleted the message 🙈 I will re-test again once it's merged 🙏 just to confirm it works!

micaelae added 4 commits August 12, 2025 11:36

fix: blockaid optimism payload for token scanner

dfa93e1

fix: show estimated effective gas in quote card

6783bfa

fix: quoted_gas event property

d31234a

fix: can_submit event properties

57a97b9

metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Aug 12, 2025

micaelae mentioned this pull request Aug 12, 2025

feat: calculate effective gasFee for swap and bridge quotes MetaMask/core#6295

Merged

4 tasks

github-actions bot added the size-S label Aug 12, 2025

micaelae added 2 commits August 12, 2025 12:56

fix: patch bridge-controller and bridge-status-controller

27c98e7

fix: undo can_submit

0619a08

github-actions bot added size-XL and removed size-S labels Aug 12, 2025

micaelae marked this pull request as ready for review August 12, 2025 20:06

micaelae requested a review from a team as a code owner August 12, 2025 20:06