Skip to content

Conversation

owencraston
Copy link
Contributor

@owencraston owencraston commented Aug 12, 2025

Description

  1. What is the reason for the change?
    Create a selector to get all the possible internal accounts that are valid for a given CAIP scope
    the Swaps team needs this to unblock their BIP44 work.
  2. What is the improvement/solution?
    Add a selector on top of the accounts controller since it already holds all the accounts
    filter the accounts based on the passed in scope
    tests
    This PR has no functional or UI changes and instead will be used by other teams in the future.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-553

Manual testing steps

This code is not testable in the ui at the moment

please...

  1. read the code
  2. read the tests
  3. verify that all tests are passing

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [d3da74a]
UI Startup Metrics (1208 ± 74 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1208108614497412521342
load102589712106910761134
domContentLoaded101789411946910711129
domInteractive18143951728
firstPaint63086120541510301128
backgroundConnect2202052558224235
firstReactRender21145562333
getState1152971328
initialActions3059729
loadScripts80568995767854915
setupStore84202912
WebpackHomeuiStartup21651613254718722632501
load16411170195715817091862
domContentLoaded16351165195215617041847
domInteractive171176131352
firstPaint1666542257186282
backgroundConnect2715338332548
firstReactRender1778941280164380
getState2643086510275
initialActions52163510
loadScripts16321163194115517021836
setupStore146288281318
FirefoxBrowserifyHomeuiStartup14291170184911914901644
load1227102214158812911389
domContentLoaded1227102114158812901389
domInteractive1083437453123227
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3218125173467
firstReactRender24205442431
getState9315018536
initialActions31567212
loadScripts1204100713858612651352
setupStore83549634
WebpackHomeuiStartup15781366204913616671842
load13111136157110813791541
domContentLoaded13111135157010813791540
domInteractive92313445094245
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect30197583348
firstReactRender55407985968
getState94447928
initialActions40698316
loadScripts12891119154310713611517
setupStore10513414922
Benchmark value 220 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 235 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 9 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2501 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 380 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 275 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1430 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 227 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 36 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 55 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 245 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 68 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 16 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 273ms | Sum of p95 exceeds: 546.8ms
Sum of all benchmark exceeds: 819.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 605 Bytes (0.01%)

@owencraston owencraston enabled auto-merge August 13, 2025 15:00
@owencraston owencraston added this pull request to the merge queue Aug 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2025
@owencraston owencraston added this pull request to the merge queue Aug 13, 2025
Merged via the queue into main with commit 0a9a6c0 Aug 13, 2025
289 of 292 checks passed
@owencraston owencraston deleted the feat/mul-459 branch August 13, 2025 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2025
@github-actions github-actions bot added the needs-validation Post merge validation label Aug 13, 2025
@metamaskbot metamaskbot added the release-13.2.0 Issue or pull request that will be included in release 13.2.0 label Aug 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-validation Post merge validation release-13.2.0 Issue or pull request that will be included in release 13.2.0 size-M team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants