-
Notifications
You must be signed in to change notification settings - Fork 5.3k
refactor(5562): migrate bridge component to React Router v6 compatibility #35045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers (20 files, +215 -172)
|
Builds ready [35e92b8]
UI Startup Metrics (1209 ± 75 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 240 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 9 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2474 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 385 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 277 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 249 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 39 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 56 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 248 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 66 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 17 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 249ms | Sum of p95 exceeds: 546.8ms Sum of all benchmark exceeds: 795.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
35e92b8
to
2ccaf0e
Compare
Builds ready [2ccaf0e]
UI Startup Metrics (1159 ± 69 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 234 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2571 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 383 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 275 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 237 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 32 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 30 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 55 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 243 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 66 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 239ms | Sum of p95 exceeds: 620.8ms Sum of all benchmark exceeds: 859.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [7b016f5]
UI Startup Metrics (1167 ± 58 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 234 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 37 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2532 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 73 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 376 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 277 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1680 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 240 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 72 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 30 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 16 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 49 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1939 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 257 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 50 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 253ms | Sum of p95 exceeds: 658.8ms Sum of all benchmark exceeds: 911.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
7b016f5
to
e281614
Compare
Builds ready [e281614]
UI Startup Metrics (1160 ± 66 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 220 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2230 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 42 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2572 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 76 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 336 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 381 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 282 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1707 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 215 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 173 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 22 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 38 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 286ms | Sum of p95 exceeds: 601.8ms Sum of all benchmark exceeds: 887.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
f353997
to
3e6722e
Compare
Builds ready [3e6722e]
UI Startup Metrics (1176 ± 64 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 234 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2512 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 380 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 272 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 238 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 244 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 50 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 37 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 16 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 242ms | Sum of p95 exceeds: 575.8ms Sum of all benchmark exceeds: 817.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
3e6722e
to
bd97179
Compare
Builds ready [bd97179]
UI Startup Metrics (1174 ± 71 ms)
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 231 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2197 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 38 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2535 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 67 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 382 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 288 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 211 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 78 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 33 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 219 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 61 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 12 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 255ms | Sum of p95 exceeds: 567.8ms Sum of all benchmark exceeds: 822.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [c6dfa8e]
UI Startup Metrics (1247 ± 76 ms)
Benchmark value 1087 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1080 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 243 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 844 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1399 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1234 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1226 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1204 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 260 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 995 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 30 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 278 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1557 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1348 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1347 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 126 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 43 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1316 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1918 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1586 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1584 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 275 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 118 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1556 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 30 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1959 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 271 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 814ms | Sum of p95 exceeds: 1356.8ms Sum of all benchmark exceeds: 2170.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [e9c0a67]
UI Startup Metrics (1266 ± 64 ms)
Benchmark value 1095 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1088 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 249 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 8 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 846 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 12 exceeds gate value 11 for chrome browserify home mean setupStore Benchmark value 1379 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1216 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1210 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 266 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 955 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 32 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 277 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 119 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 261 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 8 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 281 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 12 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 404ms | Sum of p95 exceeds: 653.8ms Sum of all benchmark exceeds: 1057.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [dcb815c]
UI Startup Metrics (1298 ± 93 ms)
Benchmark value 1128 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1120 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 257 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 872 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1493 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1322 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1311 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1242 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 274 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 21 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 1065 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 32 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2469 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 278 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 242 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 76 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 194 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 511ms | Sum of p95 exceeds: 1063.8ms Sum of all benchmark exceeds: 1574.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [2e466f3]
UI Startup Metrics (1195 ± 52 ms)
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 257 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2484 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 281 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 210 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 8 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 266 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 280ms | Sum of p95 exceeds: 518.8ms Sum of all benchmark exceeds: 798.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [15899ab]
UI Startup Metrics (1270 ± 64 ms)
Benchmark value 1104 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1096 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 257 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 846 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1369 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1206 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1201 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 43 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 1188 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 270 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 944 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 30 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2494 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 274 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 236 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 82 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1809 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1533 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1533 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 35 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1507 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2031 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1726 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1726 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 300 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 53 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 61 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1701 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 1075ms | Sum of p95 exceeds: 974.8ms Sum of all benchmark exceeds: 2049.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [47ffbb6]
UI Startup Metrics (1213 ± 62 ms)
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 251 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 33 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2500 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 70 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 275 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 37 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 252 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 103 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 32 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 18 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 274 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 276ms | Sum of p95 exceeds: 626.8ms Sum of all benchmark exceeds: 902.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [204568e]
UI Startup Metrics (1208 ± 59 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 259 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 220 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1714 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 235 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 277 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 5 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 279ms | Sum of p95 exceeds: 523.8ms Sum of all benchmark exceeds: 802.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [f35b54f]
UI Startup Metrics (1232 ± 66 ms)
Benchmark value 1063 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 246 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 262 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 208 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 78 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 33 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 270 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 5 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 280ms | Sum of p95 exceeds: 412.8ms Sum of all benchmark exceeds: 692.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [8c7f0db]
UI Startup Metrics (1246 ± 68 ms)
Benchmark value 1080 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1072 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 247 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 832 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1367 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 259 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 947 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 37 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 279 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 252 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 40 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1616 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1958 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 272 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 54 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 336ms | Sum of p95 exceeds: 590.8ms Sum of all benchmark exceeds: 926.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Migrate bridge Pages with react-router-v5-compat
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5562
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist