Skip to content

Conversation

@LimitedVERSE
Copy link

@LimitedVERSE LimitedVERSE commented Sep 2, 2025

Description

This PR introduces QYX20 / QuantumYield branding and configuration into the MetaMask extension codebase.
The goal is to adapt the upstream MetaMask extension into a whitelabel variant, enabling specialized support for the QYX20 token standard and QuantumYield exchange integration.

  • Reason for change: Extend MetaMask core to include custom branding and advanced functionality for QuantumYield users.
  • Improvement/solution: Provide a dedicated build path with preconfigured assets, token/chain metadata, and UX adjustments aligned with QYX20.

Open in GitHub Codespaces


Changelog

CHANGELOG entry:
Added QYX20 (QuantumYield) branding and configuration support as a whitelabel MetaMask variant.


Related issues

Fixes: [link issue or tracking ticket here if applicable]


Manual testing steps

  1. Pull this branch and build the extension with yarn start or pnpm build.
  2. Load the unpacked extension into Chrome/Edge/Brave.
  3. Confirm QuantumYield branding (icons, splash, UI assets).
  4. Validate QYX20 token/chain metadata loads correctly.
  5. Ensure base MetaMask functionality (accounts, RPC, transactions) is not broken.
  6. Test QYX20-specific flows (deposit/withdraw/UTXO integration if available).

Screenshots/Recordings

Before

Default MetaMask branding and configuration.

After

QuantumYield (QYX20) branding, UI updates, and chain configuration visible in extension.

(add screenshots when available)


Pre-merge author checklist


Pre-merge reviewer checklist

  • I’ve manually tested this branch (pull, build, run extension).
  • I confirm the PR addresses all acceptance criteria in its related ticket.
  • I’ve added/checked screenshots or recordings showing changes in action.

Note

Rebrands MetaMask UI strings to QuantumYield and updates multiple GitHub Actions (self-hosted runners, new Pages deploys, improved scripting), plus minor code robustness and styling tweaks.

  • Branding/UI:
    • Replace MetaMask with QuantumYield across app/_locales/en/messages.json, app/loading.html, and app/popup-init.html (titles, messages, support text).
    • Tweak popup dark background color and loading copy.
  • Code robustness:
    • Wrap completeQrCodeScan in try/catch to log background call errors.
    • Minor comment note in multichain-avatar-group.tsx.
  • CI/CD (GitHub Actions):
    • Switch many jobs to runs-on: self-hosted; adjust envs and tokens; capture NEXT_SEMVER_VERSION via step output.
    • Add GitHub Pages deploy workflows for Jekyll and Next.js (branch QYX20).
    • Modify Crowdin workflow branch target and various E2E/reporting jobs; introduce custom flaky test report generation.
    • Nightly build tweaks (risk/allow-scripts), broader workflow refinements (benchmarks, bundle size, policies, releases).

Written by Cursor Bugbot for commit 48c0bc6. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you all read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

1 out of 2 committers have signed the CLA.
@LimitedVERSE
❌ @Copilot

@LimitedVERSE LimitedVERSE marked this pull request as ready for review September 2, 2025 02:30
LimitedVERSE and others added 3 commits September 14, 2025 03:48
Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
…orrect runs-on

Co-authored-by: LimitedVERSE <218420696+LimitedVERSE@users.noreply.github.com>
Co-authored-by: LimitedVERSE <218420696+LimitedVERSE@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 47 out of 49 changed files in this pull request and generated 5 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

LimitedVERSE and others added 4 commits September 14, 2025 04:53
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
cursor[bot]

This comment was marked as outdated.

Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 48 out of 50 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 48 out of 50 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
cursor[bot]

This comment was marked as outdated.

Change concurrency setting to cancel in-progress deployments.

Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

yarn-custom-url: ${{ vars.YARN_URL }}

- name: Create flaky test report
run: yarn tsx .github/scripts/create-flaky-test-report.ts
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Flaky Test Report Workflow Fails

The flaky test report workflow changed to an inline implementation that calls .github/scripts/create-flaky-test-report.ts, but this script is missing from the repository. Additionally, the Slack webhook secret name changed from SLACK_WEBHOOK_FLAKY_TESTS to SLACK_WEBHOOK_URL. This will cause the workflow to fail and prevent flaky test reports.

Fix in Cursor Fix in Web

jobs:
check-template-and-add-labels:
runs-on: ubuntu-latest
runs-on: self-hosted
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Self-Hosted Runners Risk Repository Security

Switching GitHub Actions workflows to self-hosted runners introduces a critical security vulnerability. In public repositories, this allows malicious pull requests from forks to execute arbitrary code on the runner infrastructure, potentially compromising repository secrets and sensitive permissions like security-events: write.

Additional Locations (1)

Fix in Cursor Fix in Web

@LimitedVERSE LimitedVERSE requested a review from Copilot October 5, 2025 06:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 50 out of 51 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +36 to 38
RELEASE_LABEL_TOKEN: ${{ secrets.RELEASE_LABEL_TOKEN || '' }}
NEXT_SEMVER_VERSION: ${{ steps.get-next-semver-version.outputs.NEXT_SEMVER_VERSION }}
run: yarn run add-release-label-to-pr-and-linked-issues
Copy link

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using an empty string as fallback for a missing secret token could lead to silent failures in authentication. Consider using a conditional check or failing explicitly when the token is missing.

Suggested change
RELEASE_LABEL_TOKEN: ${{ secrets.RELEASE_LABEL_TOKEN || '' }}
NEXT_SEMVER_VERSION: ${{ steps.get-next-semver-version.outputs.NEXT_SEMVER_VERSION }}
run: yarn run add-release-label-to-pr-and-linked-issues
RELEASE_LABEL_TOKEN: ${{ secrets.RELEASE_LABEL_TOKEN }}
NEXT_SEMVER_VERSION: ${{ steps.get-next-semver-version.outputs.NEXT_SEMVER_VERSION }}
run: |
if [ -z "$RELEASE_LABEL_TOKEN" ]; then
echo "ERROR: RELEASE_LABEL_TOKEN secret is not set. Failing workflow."
exit 1
fi
yarn run add-release-label-to-pr-and-linked-issues

Copilot uses AI. Check for mistakes.
Comment on lines +30 to +31
- name: Create flaky test report
run: yarn tsx .github/scripts/create-flaky-test-report.ts
Copy link

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow references a script file .github/scripts/create-flaky-test-report.ts that doesn't exist in the current diff. Ensure this script file is created or already exists in the repository.

Copilot uses AI. Check for mistakes.

on:
push:
branches:
Copy link

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Crowdin workflow now only triggers on the QYX20 branch instead of main. This could break localization updates for the main branch. Consider whether this change is intentional or if both branches should be included.

Suggested change
branches:
branches:
- main

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants