-
Notifications
You must be signed in to change notification settings - Fork 5.5k
QYX20 #35571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
QYX20 #35571
Conversation
QuantumYield integration for popup initiation
QuantumYield integration
|
CLA Signature Action: Thank you for your submission, we really appreciate it. We ask that you all read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:
By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository. 1 out of 2 committers have signed the CLA. |
Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
…orrect runs-on Co-authored-by: LimitedVERSE <218420696+LimitedVERSE@users.noreply.github.com>
Co-authored-by: LimitedVERSE <218420696+LimitedVERSE@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 47 out of 49 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 48 out of 50 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 48 out of 50 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
Change concurrency setting to cancel in-progress deployments. Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
Signed-off-by: LimitedVERSE <limitedverse@gmail.com>
| yarn-custom-url: ${{ vars.YARN_URL }} | ||
|
|
||
| - name: Create flaky test report | ||
| run: yarn tsx .github/scripts/create-flaky-test-report.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Flaky Test Report Workflow Fails
The flaky test report workflow changed to an inline implementation that calls .github/scripts/create-flaky-test-report.ts, but this script is missing from the repository. Additionally, the Slack webhook secret name changed from SLACK_WEBHOOK_FLAKY_TESTS to SLACK_WEBHOOK_URL. This will cause the workflow to fail and prevent flaky test reports.
| jobs: | ||
| check-template-and-add-labels: | ||
| runs-on: ubuntu-latest | ||
| runs-on: self-hosted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Self-Hosted Runners Risk Repository Security
Switching GitHub Actions workflows to self-hosted runners introduces a critical security vulnerability. In public repositories, this allows malicious pull requests from forks to execute arbitrary code on the runner infrastructure, potentially compromising repository secrets and sensitive permissions like security-events: write.
Additional Locations (1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 50 out of 51 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| RELEASE_LABEL_TOKEN: ${{ secrets.RELEASE_LABEL_TOKEN || '' }} | ||
| NEXT_SEMVER_VERSION: ${{ steps.get-next-semver-version.outputs.NEXT_SEMVER_VERSION }} | ||
| run: yarn run add-release-label-to-pr-and-linked-issues |
Copilot
AI
Oct 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using an empty string as fallback for a missing secret token could lead to silent failures in authentication. Consider using a conditional check or failing explicitly when the token is missing.
| RELEASE_LABEL_TOKEN: ${{ secrets.RELEASE_LABEL_TOKEN || '' }} | |
| NEXT_SEMVER_VERSION: ${{ steps.get-next-semver-version.outputs.NEXT_SEMVER_VERSION }} | |
| run: yarn run add-release-label-to-pr-and-linked-issues | |
| RELEASE_LABEL_TOKEN: ${{ secrets.RELEASE_LABEL_TOKEN }} | |
| NEXT_SEMVER_VERSION: ${{ steps.get-next-semver-version.outputs.NEXT_SEMVER_VERSION }} | |
| run: | | |
| if [ -z "$RELEASE_LABEL_TOKEN" ]; then | |
| echo "ERROR: RELEASE_LABEL_TOKEN secret is not set. Failing workflow." | |
| exit 1 | |
| fi | |
| yarn run add-release-label-to-pr-and-linked-issues |
| - name: Create flaky test report | ||
| run: yarn tsx .github/scripts/create-flaky-test-report.ts |
Copilot
AI
Oct 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow references a script file .github/scripts/create-flaky-test-report.ts that doesn't exist in the current diff. Ensure this script file is created or already exists in the repository.
|
|
||
| on: | ||
| push: | ||
| branches: |
Copilot
AI
Oct 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Crowdin workflow now only triggers on the QYX20 branch instead of main. This could break localization updates for the main branch. Consider whether this change is intentional or if both branches should be included.
| branches: | |
| branches: | |
| - main |
Description
This PR introduces QYX20 / QuantumYield branding and configuration into the MetaMask extension codebase.
The goal is to adapt the upstream MetaMask extension into a whitelabel variant, enabling specialized support for the QYX20 token standard and QuantumYield exchange integration.
Changelog
CHANGELOG entry:
Added QYX20 (QuantumYield) branding and configuration support as a whitelabel MetaMask variant.Related issues
Fixes: [link issue or tracking ticket here if applicable]
Manual testing steps
yarn startorpnpm build.Screenshots/Recordings
Before
Default MetaMask branding and configuration.
After
QuantumYield (QYX20) branding, UI updates, and chain configuration visible in extension.
(add screenshots when available)
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Rebrands MetaMask UI strings to QuantumYield and updates multiple GitHub Actions (self-hosted runners, new Pages deploys, improved scripting), plus minor code robustness and styling tweaks.
QuantumYieldacrossapp/_locales/en/messages.json,app/loading.html, andapp/popup-init.html(titles, messages, support text).completeQrCodeScanin try/catch to log background call errors.multichain-avatar-group.tsx.runs-on: self-hosted; adjust envs and tokens; capture NEXT_SEMVER_VERSION via step output.QYX20).Written by Cursor Bugbot for commit 48c0bc6. This will update automatically on new commits. Configure here.