feat: Add account upgrade and check status RPC methods #36452

MoMannn · 2025-09-30T09:23:51Z

Description

This PR adds RPC methods for upgrading Externally Owned Accounts (EOAs) to EIP-7702 delegator accounts. This functions are only callable by preinstalled snaps. It adds

wallet_upgradeAccount for upgrading the account
wallet_getAccountUpgradeStatus for checking if account is upgraded or not

Related Issues

Needed for: feat: upgrade account to smart account snap-7715-permissions#188
Requires: Feat/eip 7702 internal rpc middleware core#6789

Changelog

CHANGELOG entry: null

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Introduces EIP-7702 account upgrade/status RPC for snaps, wires middleware in the controller, adds shared upgrade/downgrade utils, refactors the UI hook/tests, and updates policies/deps.

RPC/Middleware:
- Add wallet_upgradeAccount and wallet_getAccountUpgradeStatus via @metamask/eip-7702-internal-rpc-middleware and register as eip7702Middleware in app/scripts/metamask-controller.js.
- Enable for Snap subjects when isFlask() or the Snap is preinstalled; uses hooks for upgradeAccount, getCurrentChainIdForDomain, isAtomicBatchSupported, getCode, and permitted accounts.
- New getCurrentChainIdForDomain(domain) helper.
Controller:
- Implement upgradeAccount(address, upgradeContractAddress, chainId) using createEIP7702UpgradeTransaction and toHex(chainId).
Shared Utils (shared/lib/eip7702-utils.ts):
- Add createEIP7702UpgradeTransaction, createEIP7702DowngradeTransaction, isAccountUpgraded, and EIP_7702_REVOKE_ADDRESS.
UI:
- Refactor useEIP7702Account to use shared utils; export EIP_7702_REVOKE_ADDRESS.
- Update tests to import the shared constant and assert requireApproval and transaction types.
Policy/Deps:
- Add @metamask/eip-7702-internal-rpc-middleware to package.json, yarn.lock, and LavaMoat policies.
Minor:
- Improve error message formatting in getControllerOrThrow.

^{Written by Cursor Bugbot for commit f7711ca. This will update automatically on new commits. Configure here.}

github-actions · 2025-09-30T09:23:59Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…into feat/account-upgrade-rpc

metamaskbot · 2025-09-30T09:27:21Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (2 files, +52 -58)

📁 ui/
- 📁 pages/
  - 📁 confirmations/
    - 📁 hooks/
      - 📄 useEIP7702Account.test.ts +9 -10
      - 📄 useEIP7702Account.ts +43 -48

metamaskbot · 2025-09-30T09:51:07Z

📊 Page Load Benchmark Results

Current Commit: 0511ad1 | Date: 9/30/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±99ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 735ms (±120ms) 🟢 | historical mean value: 739ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 84ms (±89ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	99ms	1.00s	1.79s	1.24s	1.79s
domContentLoaded	735ms	120ms	691ms	1.75s	929ms	1.75s
firstPaint	84ms	89ms	60ms	964ms	88ms	964ms
firstContentfulPaint	84ms	89ms	60ms	964ms	88ms	964ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-30T09:51:12Z

Builds ready [0511ad1]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1234 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1234	1112	1428	67	1270	1334
			load	1065	963	1236	58	1092	1162
			domContentLoaded	1059	957	1228	58	1086	1155
			domInteractive	18	14	56	8	17	41
			firstPaint	693	82	1167	422	1077	1148
			backgroundConnect	252	239	281	8	257	269
			firstReactRender	26	17	57	8	27	42
			getState	15	5	101	13	16	28
			initialActions	6	0	33	6	8	19
			loadScripts	813	718	967	55	842	914
			setupStore	10	6	27	4	12	22
	Webpack	Home	uiStartup	2040	1535	2591	267	2250	2507
			load	1643	1232	2032	208	1778	1981
			domContentLoaded	1636	1221	2027	208	1772	1961
			domInteractive	20	12	141	23	15	69
			firstPaint	164	65	425	67	192	313
			backgroundConnect	33	16	359	47	30	58
			firstReactRender	89	37	332	72	85	327
			getState	27	5	298	64	14	271
			initialActions	5	2	22	4	5	11
			loadScripts	1632	1215	2016	207	1769	1949
			setupStore	16	6	244	28	15	23
Firefox	Browserify	Home	uiStartup	1360	1171	1728	113	1430	1611
			load	1183	1023	1450	91	1265	1333
			domContentLoaded	1182	1023	1450	91	1265	1332
			domInteractive	98	33	387	52	100	224
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	18	93	13	32	63
			firstReactRender	28	24	66	6	28	49
			getState	7	3	39	6	7	14
			initialActions	3	0	12	2	4	6
			loadScripts	1160	1006	1426	88	1229	1301
			setupStore	9	5	49	7	9	17
	Webpack	Home	uiStartup	1758	1467	2205	167	1870	2051
			load	1488	1229	1791	150	1617	1732
			domContentLoaded	1488	1228	1790	149	1617	1731
			domInteractive	124	36	395	67	120	313
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	36	24	105	12	41	50
			firstReactRender	42	34	54	4	45	51
			getState	7	3	28	4	8	14
			initialActions	5	1	85	9	5	15
			loadScripts	1461	1206	1756	149	1592	1708
			setupStore	15	6	207	24	12	30

Benchmark value 1235 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 253 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 270 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 19 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 22 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2507 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 70 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 271 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 224 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 6 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 1758 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1489 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1488 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 124 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 36 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1462 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2051 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1732 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1731 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 313 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 50 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1708 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 772ms | Sum of p95 exceeds: 964.8ms
Sum of all benchmark exceeds: 1736.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 3.94 KiB (0.09%)
ui: -100 Bytes (0%)
common: 1.25 KiB (0.02%)

…into feat/account-upgrade-rpc

metamaskbot · 2025-09-30T10:42:12Z

📊 Page Load Benchmark Results

Current Commit: 7c7c089 | Date: 9/30/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±70ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 728ms (±68ms) 🟢 | historical mean value: 739ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±10ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	70ms	1.00s	1.31s	1.26s	1.31s
domContentLoaded	728ms	68ms	694ms	988ms	932ms	988ms
firstPaint	75ms	10ms	60ms	160ms	84ms	160ms
firstContentfulPaint	75ms	10ms	60ms	160ms	84ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-30T10:42:22Z

Builds ready [7c7c089]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1251 ± 87 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1251	1097	1521	87	1304	1406
			load	1081	964	1328	79	1125	1213
			domContentLoaded	1072	948	1321	81	1116	1206
			domInteractive	17	13	41	4	17	26
			firstPaint	699	74	1325	441	1093	1189
			backgroundConnect	253	238	280	9	258	275
			firstReactRender	25	17	49	7	28	40
			getState	13	5	82	12	15	34
			initialActions	5	1	45	6	5	13
			loadScripts	827	709	1064	79	877	954
			setupStore	9	6	40	4	10	16
	Webpack	Home	uiStartup	2005	1541	2506	241	2167	2430
			load	1617	1246	2024	190	1733	1896
			domContentLoaded	1611	1243	2020	190	1727	1891
			domInteractive	18	12	130	16	14	53
			firstPaint	163	63	606	71	193	300
			backgroundConnect	32	14	342	44	31	51
			firstReactRender	87	37	320	70	81	312
			getState	27	5	326	65	14	260
			initialActions	5	2	20	4	5	17
			loadScripts	1607	1240	2010	188	1724	1880
			setupStore	23	6	294	54	15	25
Firefox	Browserify	Home	uiStartup	1395	1204	1925	113	1452	1596
			load	1205	1060	1473	81	1262	1335
			domContentLoaded	1204	1059	1473	81	1262	1335
			domInteractive	98	35	254	46	99	228
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	19	124	15	32	67
			firstReactRender	28	23	65	6	28	42
			getState	7	3	55	8	6	23
			initialActions	6	1	193	20	4	10
			loadScripts	1181	1044	1454	81	1244	1315
			setupStore	9	5	64	8	9	20
	Webpack	Home	uiStartup	1550	1392	1865	129	1649	1839
			load	1319	1172	1590	108	1407	1537
			domContentLoaded	1318	1172	1589	108	1406	1537
			domInteractive	101	32	309	56	101	287
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	20	90	12	34	40
			firstReactRender	37	31	52	4	39	46
			getState	6	3	18	2	7	10
			initialActions	4	1	162	16	3	8
			loadScripts	1296	1148	1569	108	1383	1516
			setupStore	10	6	67	7	10	15

Benchmark value 1252 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1081 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1073 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 254 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1406 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1213 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1206 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1189 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 275 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 34 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 955 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 260 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 17 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 228 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 287 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 318ms | Sum of p95 exceeds: 636.8ms
Sum of all benchmark exceeds: 954.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 4.04 KiB (0.09%)
ui: -100 Bytes (0%)
common: 1.25 KiB (0.02%)

…k/metamask-extension into feat/account-upgrade-rpc

metamaskbot · 2025-09-30T13:50:17Z

📊 Page Load Benchmark Results

Current Commit: 244a65d | Date: 9/30/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±64ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 738ms (±62ms) 🟢 | historical mean value: 739ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	64ms	1.01s	1.34s	1.28s	1.34s
domContentLoaded	738ms	62ms	698ms	1.02s	956ms	1.02s
firstPaint	78ms	12ms	60ms	180ms	88ms	180ms
firstContentfulPaint	78ms	12ms	60ms	180ms	88ms	180ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-30T13:50:22Z

Builds ready [244a65d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1246 ± 75 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1246	1108	1404	75	1316	1371
			load	1075	964	1240	71	1140	1204
			domContentLoaded	1068	950	1233	71	1134	1196
			domInteractive	18	13	54	7	17	38
			firstPaint	677	68	1242	446	1076	1206
			backgroundConnect	253	240	279	7	257	267
			firstReactRender	25	18	57	7	26	41
			getState	13	5	103	11	15	28
			initialActions	6	0	65	7	7	14
			loadScripts	822	714	990	70	888	937
			setupStore	10	6	44	6	10	21
	Webpack	Home	uiStartup	2029	1516	2599	254	2193	2465
			load	1644	1211	1983	194	1759	1917
			domContentLoaded	1637	1208	1973	193	1752	1913
			domInteractive	18	11	114	14	15	44
			firstPaint	162	62	375	62	185	297
			backgroundConnect	27	15	91	12	30	50
			firstReactRender	93	37	335	75	84	305
			getState	23	5	311	55	14	28
			initialActions	5	2	37	5	5	17
			loadScripts	1633	1206	1961	192	1749	1902
			setupStore	20	6	301	44	14	32
Firefox	Browserify	Home	uiStartup	1533	1246	2057	145	1587	1933
			load	1307	1086	1520	88	1362	1486
			domContentLoaded	1306	1086	1519	88	1361	1486
			domInteractive	112	36	346	56	118	250
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	37	22	166	21	39	103
			firstReactRender	31	24	58	6	32	43
			getState	15	4	333	40	8	67
			initialActions	5	2	43	5	5	9
			loadScripts	1279	1069	1470	86	1336	1456
			setupStore	13	6	128	16	11	29
	Webpack	Home	uiStartup	1560	1357	1921	146	1661	1862
			load	1332	1162	1683	135	1432	1600
			domContentLoaded	1332	1162	1682	135	1432	1600
			domInteractive	106	33	335	67	98	298
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	21	50	7	36	40
			firstReactRender	36	31	46	3	38	42
			getState	6	3	14	2	7	12
			initialActions	5	1	123	14	4	9
			loadScripts	1309	1136	1654	136	1411	1578
			setupStore	10	5	50	6	9	23

Benchmark value 1246 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1076 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1069 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 254 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1372 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1204 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1197 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1207 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 268 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 21 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2465 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 17 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1534 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1307 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1307 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 37 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1280 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1933 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 250 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 103 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 67 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 298 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 637ms | Sum of p95 exceeds: 914.8ms
Sum of all benchmark exceeds: 1551.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 4.25 KiB (0.09%)
ui: -100 Bytes (0%)
common: 1.25 KiB (0.02%)

…into feat/account-upgrade-rpc

…k/metamask-extension into feat/account-upgrade-rpc

metamaskbot · 2025-10-01T11:50:45Z

📊 Page Load Benchmark Results

Current Commit: 2703ec4 | Date: 10/1/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±72ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 745ms (±70ms) 🟢 | historical mean value: 738ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±10ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	72ms	1.01s	1.35s	1.28s	1.35s
domContentLoaded	745ms	70ms	699ms	1.03s	955ms	1.03s
firstPaint	76ms	10ms	60ms	156ms	84ms	156ms
firstContentfulPaint	76ms	10ms	60ms	156ms	84ms	156ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-01T11:51:00Z

Builds ready [2703ec4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1242 ± 75 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1242	1105	1480	75	1294	1381
			load	1077	959	1284	70	1127	1199
			domContentLoaded	1070	950	1277	70	1121	1190
			domInteractive	18	13	72	8	17	38
			firstPaint	686	88	1282	441	1094	1196
			backgroundConnect	252	240	279	7	255	263
			firstReactRender	24	18	44	5	25	37
			getState	13	5	35	6	17	26
			initialActions	5	0	22	4	6	14
			loadScripts	824	708	1021	68	876	936
			setupStore	10	6	24	4	11	20
	Webpack	Home	uiStartup	1960	1470	2562	281	2171	2434
			load	1558	1181	1965	206	1684	1866
			domContentLoaded	1551	1176	1945	206	1678	1856
			domInteractive	16	12	74	11	14	41
			firstPaint	157	66	327	59	175	288
			backgroundConnect	30	14	381	37	30	58
			firstReactRender	97	36	332	83	84	322
			getState	34	4	319	75	15	283
			initialActions	5	2	35	4	5	13
			loadScripts	1547	1174	1934	205	1676	1844
			setupStore	20	5	308	49	12	28
Firefox	Browserify	Home	uiStartup	1401	1186	1974	122	1455	1599
			load	1208	1033	1444	80	1269	1344
			domContentLoaded	1207	1033	1444	80	1268	1344
			domInteractive	104	32	305	53	106	225
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	19	80	10	33	47
			firstReactRender	28	24	63	5	28	33
			getState	12	3	307	33	6	54
			initialActions	4	1	14	2	4	6
			loadScripts	1186	1017	1420	80	1243	1326
			setupStore	10	5	92	11	10	16
	Webpack	Home	uiStartup	1584	1343	2065	150	1651	1923
			load	1342	1153	1750	126	1408	1584
			domContentLoaded	1342	1153	1749	126	1408	1583
			domInteractive	109	34	330	58	112	298
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	21	56	7	37	42
			firstReactRender	38	32	66	5	41	46
			getState	8	3	153	15	7	15
			initialActions	4	0	33	4	4	11
			loadScripts	1319	1135	1715	126	1388	1565
			setupStore	11	6	71	8	10	24

Benchmark value 1242 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1077 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1070 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 252 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1381 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1199 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1190 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1196 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 264 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 283 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 225 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 54 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 6 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 298 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 311ms | Sum of p95 exceeds: 621.8ms
Sum of all benchmark exceeds: 932.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 4.25 KiB (0.09%)
ui: 3.24 KiB (0.05%)
common: 1.2 KiB (0.01%)

…k/metamask-extension into feat/account-upgrade-rpc

metamaskbot · 2025-10-02T09:35:19Z

📊 Page Load Benchmark Results

Current Commit: 4688eff | Date: 10/2/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±71ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 739ms (±70ms) 🟢 | historical mean value: 738ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±10ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	71ms	1.01s	1.34s	1.28s	1.34s
domContentLoaded	739ms	70ms	702ms	1.02s	953ms	1.02s
firstPaint	77ms	10ms	56ms	160ms	84ms	160ms
firstContentfulPaint	77ms	10ms	56ms	160ms	84ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-02T09:35:24Z

Builds ready [4688eff]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1282 ± 82 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1282	1147	1521	82	1334	1425
			load	1104	980	1287	79	1159	1255
			domContentLoaded	1097	973	1273	79	1153	1248
			domInteractive	18	13	69	8	18	41
			firstPaint	721	89	1298	451	1127	1262
			backgroundConnect	259	241	291	10	266	276
			firstReactRender	26	17	114	11	28	44
			getState	14	5	52	8	18	26
			initialActions	5	1	40	5	5	17
			loadScripts	845	726	1018	77	900	987
			setupStore	10	6	23	3	11	18
	Webpack	Home	uiStartup	2043	1512	2585	293	2271	2470
			load	1630	1214	2033	226	1778	1988
			domContentLoaded	1622	1211	2026	226	1773	1979
			domInteractive	18	12	84	15	14	67
			firstPaint	165	64	367	66	187	314
			backgroundConnect	35	13	351	46	31	61
			firstReactRender	100	37	332	76	95	320
			getState	24	5	332	56	15	33
			initialActions	8	2	172	17	6	18
			loadScripts	1618	1208	2015	225	1770	1969
			setupStore	18	5	285	37	13	26
Firefox	Browserify	Home	uiStartup	1440	1247	1996	120	1496	1653
			load	1243	1093	1432	83	1315	1392
			domContentLoaded	1243	1092	1432	83	1315	1391
			domInteractive	113	33	420	62	115	240
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	20	88	11	33	52
			firstReactRender	29	25	88	7	30	35
			getState	8	3	51	8	6	30
			initialActions	5	1	47	5	4	11
			loadScripts	1220	1078	1412	81	1289	1367
			setupStore	12	6	209	21	10	31
	Webpack	Home	uiStartup	1622	1399	2206	154	1712	1888
			load	1379	1176	1639	130	1480	1604
			domContentLoaded	1379	1175	1638	129	1480	1603
			domInteractive	113	40	329	64	103	297
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	21	105	12	36	45
			firstReactRender	37	33	52	4	40	45
			getState	8	3	184	18	7	12
			initialActions	3	1	11	2	4	6
			loadScripts	1355	1147	1612	129	1459	1583
			setupStore	11	5	69	10	10	23

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 4.4 KiB (0.1%)
ui: -95 Bytes (0%)
common: 1.28 KiB (0.02%)

jeffsmale90

This is so good!

shared/lib/eip7702-utils.ts

app/scripts/lib/rpc-method-middleware/handlers/wallet-upgrade-account.ts

app/scripts/metamask-controller.js

jeffsmale90 · 2025-10-03T00:29:55Z

app/scripts/metamask-controller.js

+   * @param {number} chainId - The chain ID for the upgrade
+   * @returns {Promise<{transactionHash: string, delegatedTo: string}>}
+   */
+  async upgradeAccount(address, upgradeContractAddress, chainId) {


It might be worth decomposing these hooks out to avoid bloating metamask-controller.js

I don't know this is the pattern used for all other implementations I would go with the same way.

app/scripts/lib/rpc-method-middleware/handlers/wallet-upgrade-account.ts

socket-security · 2025-10-07T13:38:31Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/eip-7702-internal-rpc-middleware@1.0.0

View full report

add account upgrade and check status RPC methods

d1d3ebc

MoMannn requested a review from a team as a code owner September 30, 2025 09:23

metamaskbot added the team-delegation MetaMask Delegation Team label Sep 30, 2025

Merge branch 'main' of https://github.com/MetaMask/metamask-extension …

0511ad1

…into feat/account-upgrade-rpc

github-actions bot added the size-XL label Sep 30, 2025

MoMannn changed the title ~~Add account upgrade and check status RPC methods~~ Feat: Add account upgrade and check status RPC methods Sep 30, 2025

MoMannn changed the title ~~Feat: Add account upgrade and check status RPC methods~~ feat: Add account upgrade and check status RPC methods Sep 30, 2025

This comment was marked as outdated.

Sign in to view

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 30, 2025

MoMannn added 3 commits September 30, 2025 11:56

cast chainId to hex

b173723

optimize tests

3f7117f

Merge branch 'main' of https://github.com/MetaMask/metamask-extension …

7c7c089

…into feat/account-upgrade-rpc

This comment was marked as outdated.

Sign in to view

MoMannn added 2 commits September 30, 2025 15:10

get config via isAtomicBatchSupported

0890df6

Merge branch 'main' into feat/account-upgrade-rpc

e8ccc03

This comment was marked as outdated.

Sign in to view

MoMannn marked this pull request as draft September 30, 2025 13:19

MoMannn added 2 commits September 30, 2025 15:23

use txController

21dc9b4

Merge branch 'feat/account-upgrade-rpc' of https://github.com/MetaMas…

244a65d

…k/metamask-extension into feat/account-upgrade-rpc

MoMannn added 3 commits October 1, 2025 10:47

Fix supported chain check

6f9f1a0

cursor configuration check fix

6a001c7

Merge branch 'main' of https://github.com/MetaMask/metamask-extension …

3a2437c

…into feat/account-upgrade-rpc

MoMannn added 4 commits October 1, 2025 12:58

wait for transaction hash

9e936a5

Merge branch 'main' into feat/account-upgrade-rpc

ab1fdbf

test fix

9e4b674

Merge branch 'feat/account-upgrade-rpc' of https://github.com/MetaMas…

2703ec4

…k/metamask-extension into feat/account-upgrade-rpc

MoMannn marked this pull request as ready for review October 2, 2025 08:39

Merge branch 'main' into feat/account-upgrade-rpc

32ca828

This comment was marked as outdated.

Sign in to view

MoMannn added 2 commits October 2, 2025 10:50

update import path

928c2c7

Merge branch 'feat/account-upgrade-rpc' of https://github.com/MetaMas…

b52fe35

…k/metamask-extension into feat/account-upgrade-rpc

This comment was marked as outdated.

Sign in to view

add null check to getCurrentChainId

4688eff

MoMannn mentioned this pull request Oct 2, 2025

feat: upgrade account to smart account MetaMask/snap-7715-permissions#188

Open

6 tasks

jeffsmale90 reviewed Oct 3, 2025

View reviewed changes

use getCurrentChainIdForDomain

60717f2

MoMannn mentioned this pull request Oct 7, 2025

Feat/eip 7702 internal rpc middleware MetaMask/core#6789

Open

4 tasks

Move rpc methods to external core package

f7711ca

MoMannn requested review from a team as code owners October 7, 2025 13:35

MoMannn marked this pull request as draft October 7, 2025 13:36

Merge branch 'main' into feat/account-upgrade-rpc

5ab0a9e

github-actions bot added size-M and removed size-XL labels Oct 7, 2025

feat: Add account upgrade and check status RPC methods #36452

Are you sure you want to change the base?

feat: Add account upgrade and check status RPC methods #36452

Conversation

MoMannn commented Sep 30, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Changelog

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Sep 30, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Sep 30, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 30, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Sep 30, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 30, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Sep 30, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 30, 2025

Uh oh!

metamaskbot commented Oct 1, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 1, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Oct 2, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 2, 2025

Uh oh!

jeffsmale90 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeffsmale90 Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

MoMannn Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

socket-security bot commented Oct 7, 2025

Uh oh!

Reviewers

MoMannn commented Sep 30, 2025 •

edited by cursor bot

Loading

metamaskbot commented Sep 30, 2025 •

edited

Loading