Skip to content

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Oct 10, 2025

Description

This PR aims to add BTC labels to the send flow asset and accounts.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5965

Manual testing steps

  1. Have btc in your account
  2. Click send from wallet view
  3. See BTC asset have type - select it
  4. Click recipient selection modal
  5. See BTC type next to recipient address

Screenshots/Recordings

Before

Screenshot 2025-10-10 at 13 13 23 Screenshot 2025-10-10 at 13 13 33

After

Screenshot 2025-10-10 at 13 08 29 Screenshot 2025-10-10 at 13 08 36

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds Bitcoin account type labels (Legacy, Nested SegWit, Native SegWit, Taproot) to asset and recipient UI, with supporting types, hooks, and tests.

  • UI:
    • Account type labels: Display BTC account type next to token name in UI/asset/asset.tsx and next to address in UI/recipient/recipient.tsx via AccountTypeLabel.
    • New component: UI/account-type-label/account-type-label.tsx with tests.
  • Constants:
    • constants/network.ts: accountTypeLabel map for KeyringAccountType (BTC variants).
  • Types/Data:
    • types/send.ts: Asset now includes accountType.
    • hooks/send/useRecipients.ts: Recipient now includes accountType.
    • hooks/send/useAccountRecipients.ts: passes through account.type to recipients.
  • Tests:
    • Add/expand tests in asset.test.tsx, recipient.test.tsx, useAccountRecipients.test.ts for label rendering and BTC account types.

Written by Cursor Bugbot for commit d09e2de. This will update automatically on new commits. Configure here.

@OGPoyraz OGPoyraz requested a review from a team as a code owner October 10, 2025 11:10
@OGPoyraz OGPoyraz added team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Oct 10, 2025
cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 10, 2025

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (12 files, +130 -8)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 components/
          • 📁 UI/
            • 📁 account-type-label/
              • 📄 account-type-label.test.tsx +19 -0
              • 📄 account-type-label.tsx +11 -0
              • 📄 index.ts +1 -0
            • 📁 asset/
              • 📄 asset.test.tsx +11 -0
              • 📄 asset.tsx +19 -3
            • 📁 recipient/
              • 📄 recipient.test.tsx +16 -0
              • 📄 recipient.tsx +19 -5
        • 📁 constants/
          • 📄 network.ts +10 -0
        • 📁 hooks/
          • 📁 send/
            • 📄 useAccountRecipients.test.ts +19 -0
            • 📄 useAccountRecipients.ts +1 -0
            • 📄 useRecipients.ts +2 -0
        • 📁 types/
          • 📄 send.ts +2 -0

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: d09e2de | Date: 10/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±72ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 742ms (±69ms) 🟢 | historical mean value: 734ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 72ms 1.02s 1.34s 1.28s 1.34s
domContentLoaded 742ms 69ms 707ms 1.02s 951ms 1.02s
firstPaint 78ms 11ms 60ms 172ms 88ms 172ms
firstContentfulPaint 78ms 11ms 60ms 172ms 88ms 172ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [d09e2de]
UI Startup Metrics (1236 ± 72 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1236109114787212811343
load106794913006611031189
domContentLoaded106192012826710981179
domInteractive18144771641
firstPaint72876132343110871188
backgroundConnect25223638215257266
firstReactRender25165572740
getState1244171326
initialActions50507519
loadScripts815671102464847937
setupStore951831014
WebpackHomeuiStartup804696105161826944
load61957590058626772
domContentLoaded61157089058620765
domInteractive15115581333
firstPaint20754893215196769
backgroundConnect21124062537
firstReactRender26165483139
getState83193911
initialActions208235
loadScripts60856887955618754
setupStore84152911
FirefoxBrowserifyHomeuiStartup14231244217413214761618
load1217106815359112831366
domContentLoaded1217106815359112811366
domInteractive1023348365104254
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect281991103345
firstReactRender29255953134
getState8213518534
initialActions30729210
loadScripts1196105315118912561346
setupStore11313819657
WebpackHomeuiStartup15321329201412115721796
load1330118415778113741487
domContentLoaded1329118415778113741487
domInteractive983036963100320
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect311894153471
firstReactRender352583123573
getState7210412537
initialActions40558223
loadScripts1306116915147713511464
setupStore1145914746
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.17 KiB (0.03%)
  • ui: 2.15 KiB (0.03%)
  • common: 10 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-M team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants