-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: Remove flask code fences for the snap accounts link #36770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+39
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (1 files, +39 -50)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [62affb8]
UI Startup Metrics (1247 ± 72 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gantunesr
approved these changes
Oct 10, 2025
hmalik88
approved these changes
Oct 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-13.6.0
Issue or pull request that will be included in release 13.6.0
size-S
team-accounts-framework
Accounts Framework team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes flask code fences for Snap accounts link located in "Add wallet" modal. This way we enable the Snap accounts link to the main production version of extension.
Changelog
CHANGELOG entry: Add changes to enable Snap accounts link to stable
Related issues
Fixes: n/a
Manual testing steps
Screenshots/Recordings
Before
Stable (

main
):Flask:

After
Stable (

main
):Flask:

Pre-merge author checklist
Pre-merge reviewer checklist
Note
Removes Flask-only guards to show the Snap accounts link in Add Wallet modal in stable, while keeping the watch-only Ethereum account behind Flask.
ui/components/multichain-accounts/add-wallet-modal/add-wallet-modal.tsx
):build-flask
fences arounduseCallback
/useContext
,getIsAddSnapAccountEnabled
, event tracking, and the Snap link UI block (still feature-flagged byaddSnapAccountEnabled
).build-flask
fences.Written by Cursor Bugbot for commit 62affb8. This will update automatically on new commits. Configure here.