Skip to content

Conversation

david0xd
Copy link
Contributor

@david0xd david0xd commented Oct 10, 2025

Description

This PR removes flask code fences for Snap accounts link located in "Add wallet" modal. This way we enable the Snap accounts link to the main production version of extension.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Add changes to enable Snap accounts link to stable

Related issues

Fixes: n/a

Manual testing steps

  1. Open extension
  2. Go to account list
  3. Click on the "Add wallet" button located in footer.
  4. Make sure that modal opens and option called "Add account Snap" is visible.
  5. Make sure that option link to the proper web page.

Screenshots/Recordings

Before

Stable (main):
Screenshot 2025-10-10 at 14 48 36

Flask:
Screenshot 2025-10-10 at 14 51 58

After

Stable (main):
Screenshot 2025-10-10 at 14 33 11

Flask:
Screenshot 2025-10-10 at 14 42 53

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Removes Flask-only guards to show the Snap accounts link in Add Wallet modal in stable, while keeping the watch-only Ethereum account behind Flask.

  • UI (Add Wallet Modal ui/components/multichain-accounts/add-wallet-modal/add-wallet-modal.tsx):
    • Exposes Snap accounts link to all builds by removing build-flask fences around useCallback/useContext, getIsAddSnapAccountEnabled, event tracking, and the Snap link UI block (still feature-flagged by addSnapAccountEnabled).
    • Keeps the Watch Ethereum Account option and related selector/handlers behind build-flask fences.
    • Minor JSX cleanup and import consolidation.

Written by Cursor Bugbot for commit 62affb8. This will update automatically on new commits. Configure here.

@david0xd david0xd self-assigned this Oct 10, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@david0xd david0xd added the team-accounts-framework Accounts Framework team label Oct 10, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (1 files, +39 -50)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain-accounts/
        • 📁 add-wallet-modal/
          • 📄 add-wallet-modal.tsx +39 -50

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 62affb8 | Date: 10/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.07s (±72ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 750ms (±70ms) 🟢 | historical mean value: 736ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±11ms) 🟢 | historical mean value: 82ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.07s 72ms 1.02s 1.34s 1.29s 1.34s
domContentLoaded 750ms 70ms 706ms 1.01s 961ms 1.01s
firstPaint 79ms 11ms 60ms 168ms 92ms 168ms
firstContentfulPaint 79ms 11ms 60ms 168ms 92ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [62affb8]
UI Startup Metrics (1247 ± 72 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1247111315017212931405
load107297512876411081187
domContentLoaded106796412826411001183
domInteractive18145871737
firstPaint66893124443210761168
backgroundConnect2542422978257272
firstReactRender27196083046
getState145109121530
initialActions50557512
loadScripts818702102062851936
setupStore962641018
WebpackHomeuiStartup847726107463869985
load64959591959659758
domContentLoaded64058990859648751
domInteractive16115681436
firstPaint19657737182205623
backgroundConnect23135072734
firstReactRender281793113440
getState942441016
initialActions2013236
loadScripts63658689757647748
setupStore842431013
FirefoxBrowserifyHomeuiStartup1367119817549514121511
load1176104513486512171311
domContentLoaded1176104413486512171310
domInteractive923423634100162
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect28199693138
firstReactRender28244532934
getState63739512
initialActions30729212
loadScripts1155102813206311991270
setupStore74648718
WebpackHomeuiStartup15291358190612015891826
load1322119015218013701508
domContentLoaded1322118915218013701508
domInteractive93313484798169
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect301993133352
firstReactRender352680133673
getState13224033687
initialActions30496212
loadScripts1298117314917713351465
setupStore1047714748
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 2.03 KiB (0.03%)
  • common: 10 Bytes (0%)

@david0xd david0xd marked this pull request as ready for review October 10, 2025 13:29
@david0xd david0xd requested a review from a team as a code owner October 10, 2025 13:29
@david0xd david0xd enabled auto-merge October 10, 2025 13:38
@gantunesr gantunesr added team-accounts-framework Accounts Framework team and removed team-accounts-framework Accounts Framework team labels Oct 10, 2025
@david0xd david0xd added this pull request to the merge queue Oct 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 13, 2025
@gantunesr gantunesr added this pull request to the merge queue Oct 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2025
@gantunesr gantunesr added this pull request to the merge queue Oct 14, 2025
Merged via the queue into main with commit b1cee4f Oct 14, 2025
194 of 199 checks passed
@gantunesr gantunesr deleted the dd/remove-snap-account-link-flask-code-fences branch October 14, 2025 09:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2025
@metamaskbot metamaskbot added the release-13.6.0 Issue or pull request that will be included in release 13.6.0 label Oct 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.6.0 Issue or pull request that will be included in release 13.6.0 size-S team-accounts-framework Accounts Framework team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants