fix: flaky test Vault Corruption restores a backup that is missing its meta property successfully
#36777
+23
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
seaona
added
flaky tests
no-changelog
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [cfc977a]
UI Startup Metrics (1225 ± 54 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [e663508]
UI Startup Metrics (1205 ± 59 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
seaona
commented
Oct 13, 2025
| confirm: boolean; | ||
| }) { | ||
| // click the Recovery/Reset button | ||
| const recoveryButton = await driver.findClickableElement( |
There was a problem hiding this comment.
ℹ️ this is an anti-pattern which can cause the element being stale, when we try to assert its state later on, if the element refreshed. See example of failure:
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [402b139]
UI Startup Metrics (1232 ± 70 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [f3874d9]
UI Startup Metrics (1249 ± 68 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
seaona
commented
Oct 16, 2025
| await prompt.accept(); | ||
| await driver.switchToWindowWithTitle( | ||
| WINDOW_TITLES.ExtensionInFullScreenView, | ||
| ); |
There was a problem hiding this comment.
we switch to the Extension page to make sure we are in the correct window, as sometimes the window is closed and re-opened, causing the error web view has been discarded
seaona
added
no-changelog
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [e92bdae]
UI Startup Metrics (1240 ± 72 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [ccbb5c6]
UI Startup Metrics (1253 ± 69 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [b710796]
UI Startup Metrics (1276 ± 79 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [1d139e3]
UI Startup Metrics (1228 ± 55 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
seaona
commented
Oct 16, 2025
| import LoginPage from '../../page-objects/pages/login-page'; | ||
|
|
||
| describe('Vault Corruption', function () { | ||
| this.timeout(120000); // This test is very long, so we need an unusually high timeout |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [480ac88]
UI Startup Metrics (1276 ± 63 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [50950b5]
UI Startup Metrics (1241 ± 66 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
seaona
added
no-changelog
seaona
commented
Oct 17, 2025
| // reload and check title as quickly a possible, forever | ||
| { interval: 0, timeout: Infinity }, | ||
| // reload and check title as quickly a possible | ||
| { interval: 100, timeout: 10000 }, |
There was a problem hiding this comment.
the Infinityvalue here is just taken as null (see last log below), then passing interval 0 and timeout of null effectively means the condition will run only once
with this fix, the test is less prone to errors, as we are effectively waiting for the correct title, going to the home page, as many times as needed (until reaching 10 seconds):
await driver.waitUntil(
async () => {
await driver.navigate(PAGES.HOME, { waitForControllers: false });
const title = await driver.driver.getTitle();
// the browser will return an error message for our UI's HOME page until
// the extension has restarted
return title === WINDOW_TITLES.ExtensionInFullScreenView;
},
jvbriones
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Investigation:
Ìnfinitywhich results in a null value, making the function run only once, then that's prone to failures, as there's no more 'wait until', rather just run the func once. See here[Bug]: Restore Vault - Race condition where page is auto closed after confirming Restore #36916
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Stabilizes vault corruption E2E tests by increasing timeouts, refining wait/polling, and hardening recovery click/window handling to avoid race conditions and stale elements.
test/e2e/tests/vault-corruption/vault-corruption.spec.ts):120000ms.waitForVaultRestorePagepolling to{ interval: 100, timeout: 10000 }.clickRecover):driver.clickElement('#critical-error-button')instead of finding then clicking.switchToWindowWithTitle, fallbackopenNewPage+navigate), and assert#critical-error-buttonis absent (avoid stale state checks).#critical-error-buttonremains clickable.Written by Cursor Bugbot for commit 50950b5. This will update automatically on new commits. Configure here.