Skip to content

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Oct 12, 2025

Description

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-accounts-framework Accounts Framework team label Oct 12, 2025
@hmalik88 hmalik88 changed the title Hm/fix e2e 36715 fix: e2e tests for sol perf update Oct 12, 2025
Copy link

Copy link

Caution

MetaMask internal reviewing guidelines:

  • Do not ignore-all
  • Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
  • Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
    @SocketSecurity ignore npm/PACKAGE@VERSION
Action Severity Alert  (click "▶" to expand/collapse)
Block Medium
@metamask/[email protected] has Network access.

Module: globalThis["fetch"]

Location: Package overview

From: package.jsonnpm/@metamask/[email protected]

ℹ Read more on: This package | This alert | What is network access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@metamask/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🧩 @MetaMask/extension-devs (5 files, +40 -0)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +8 -0
      • 📁 experimental/
        • 📄 policy.json +8 -0
      • 📁 flask/
        • 📄 policy.json +8 -0
      • 📁 main/
        • 📄 policy.json +8 -0
    • 📁 webpack/
      • 📄 policy.json +8 -0

📜 @MetaMask/policy-reviewers (5 files, +40 -0)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +8 -0
      • 📁 experimental/
        • 📄 policy.json +8 -0
      • 📁 flask/
        • 📄 policy.json +8 -0
      • 📁 main/
        • 📄 policy.json +8 -0
    • 📁 webpack/
      • 📄 policy.json +8 -0

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.


🧪 @MetaMask/qa (1 files, +8 -8)
  • 📁 test/
    • 📁 e2e/
      • 📁 page-objects/
        • 📁 pages/
          • 📁 home/
            • 📄 non-evm-homepage.ts +8 -8

🔗 @MetaMask/supply-chain (5 files, +40 -0)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +8 -0
      • 📁 experimental/
        • 📄 policy.json +8 -0
      • 📁 flask/
        • 📄 policy.json +8 -0
      • 📁 main/
        • 📄 policy.json +8 -0
    • 📁 webpack/
      • 📄 policy.json +8 -0

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: f1ae84e | Date: 10/12/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.07s (±75ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 750ms (±87ms) 🟢 | historical mean value: 737ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 82ms (±43ms) 🟢 | historical mean value: 80ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.07s 75ms 1.02s 1.37s 1.30s 1.37s
domContentLoaded 750ms 87ms 704ms 1.32s 969ms 1.32s
firstPaint 82ms 43ms 60ms 508ms 92ms 508ms
firstContentfulPaint 82ms 43ms 60ms 508ms 92ms 508ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [f1ae84e]
UI Startup Metrics (1237 ± 81 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1237110215938112761417
load106295813767410901228
domContentLoaded105695513727510851222
domInteractive1913124151743
firstPaint61269128443010611157
backgroundConnect2512372717255266
firstReactRender25186172742
getState1554071832
initialActions60426623
loadScripts811709111574833985
setupStore1052641120
WebpackHomeuiStartup8547221193808681059
load64058398679642902
domContentLoaded63257797779635894
domInteractive16116781436
firstPaint19258907193198608
backgroundConnect22123762733
firstReactRender27176793243
getState942331114
initialActions3014247
loadScripts62957596476633883
setupStore1051631214
FirefoxBrowserifyHomeuiStartup14161247176812514931705
load1189106214009012681363
domContentLoaded1188106114009012681363
domInteractive99352985399246
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect322085113752
firstReactRender30247073137
getState85354812
initialActions4186939
loadScripts1168104513828712471328
setupStore136142181046
WebpackHomeuiStartup15811410212312716331853
load13601182165810014201574
domContentLoaded13601182165810014201574
domInteractive101313706898309
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3519100124056
firstReactRender332694123368
getState10412314917
initialActions7116022325
loadScripts1337116816249814021529
setupStore156236251045
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.45 KiB (0.03%)
  • ui: 1.55 KiB (0.02%)
  • common: 12.97 KiB (0.16%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-M team-accounts-framework Accounts Framework team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants