Skip to content

Conversation

metamaskbot
Copy link
Collaborator

@metamaskbot metamaskbot commented Oct 13, 2025

This is the release candidate for version 13.4.3. The changelog will be found in another PR release/13.4.3-Changelog.

Team sign-off checklist

  • Product Safety

Reference


Note

Adds path-based phishing URL blocking and whitelist paths, updates phishing API to v2, bumps version to 13.4.3, and sets timeouts across CI workflows.

  • Security / Phishing:
    • Add path-based blocking via PathTrie and integrate into PhishingController, PhishingDetector, and utils (new blocklistPaths, whitelistPaths, path matching/bypass, deep copy, insert/delete helpers).
    • Switch hotlist diffs endpoint to v2 and consume stalelist blocklistPaths.
    • Patch @metamask/phishing-controller and update tests/mocks; add E2E fixtures for path scenarios; mask PhishingController.whitelistPaths in metrics.
  • CI/CD:
    • Set timeout-minutes: 30 on many GitHub Actions jobs and update reusable workflow SHAs.
  • Policies/Deps:
    • Allow console.error in LavaMoat policies; update various MetaMask deps and yarn lock; attribution updates.
  • Release:
    • Bump version to 13.4.3 and update CHANGELOG.md.

Written by Cursor Bugbot for commit f7ca950. This will update automatically on new commits. Configure here.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Oct 13, 2025
@metamaskbot
Copy link
Collaborator Author

Builds ready [1fbcc8f]
UI Startup Metrics (1215 ± 67 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1215108713396712671318
load105393611866311051155
domContentLoaded104692711806210971148
domInteractive17134561638
firstPaint67072117243010831142
backgroundConnect2432322787246252
firstReactRender23174152434
getState1252961526
initialActions4047659
loadScripts81070294361858907
setupStore962131018
WebpackHomeuiStartup20551535268426522342465
load16411236210119817761909
domContentLoaded16331231207719617671896
domInteractive181290131546
firstPaint1717337360206306
backgroundConnect3117294283060
firstReactRender100363528789321
getState3343097415271
initialActions7217017615
loadScripts16291226206519517651884
setupStore186295401423
FirefoxBrowserifyHomeuiStartup13691206191411414171563
load1183104714097412401315
domContentLoaded1183104714087412391315
domInteractive1023345963105253
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect301981103643
firstReactRender27235552834
getState7210711612
initialActions31122310
loadScripts1161102813877212151296
setupStore104559833
WebpackHomeuiStartup15431328218716316221906
load13151144160112114081536
domContentLoaded13141143160112114071536
domInteractive103323415997283
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect32206183646
firstReactRender3730132113846
getState9317522711
initialActions5020520314
loadScripts12911109157712313871509
setupStore95657816

@metamaskbot metamaskbot added the release-13.4.3 Issue or pull request that will be included in release 13.4.3 label Oct 13, 2025
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR updates the change log for 13.4.3.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/36813?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Updates `CHANGELOG.md` for 13.4.3 with a fix for path-based URL
blocking and refreshes compare links.
> 
> - **Changelog (`CHANGELOG.md`)**:
>   - **13.4.3 (Fixed)**: Add path-based URL blocking entry (#36634).
> - **Links**: Update `[Unreleased]` to compare from `v13.4.3` and add
`[13.4.3]` compare link.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
c6cec8c. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@metamaskbot
Copy link
Collaborator Author

Builds ready [0dfc31c]
UI Startup Metrics (1234 ± 76 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1234109913997612861378
load106994012257211191200
domContentLoaded106293612177211121191
domInteractive18135271737
firstPaint62773122844310971183
backgroundConnect24623232411248262
firstReactRender24174352535
getState14596101729
initialActions40183512
loadScripts82369898271874951
setupStore962131015
WebpackHomeuiStartup19451485252627821152428
load15441197192921217151868
domContentLoaded15361193191921217061858
domInteractive181286131454
firstPaint1686533961189303
backgroundConnect43163556532276
firstReactRender84373417176317
getState4343298913289
initialActions11228940621
loadScripts15321187190721017021847
setupStore176308411320
FirefoxBrowserifyHomeuiStartup14091246190311214681605
load1216107814337312661348
domContentLoaded1216107714337312651348
domInteractive1013430549103235
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3319147163568
firstReactRender26234432731
getState73577719
initialActions31374311
loadScripts1191106113626912441314
setupStore1057810826
WebpackHomeuiStartup15391336317421016111823
load13141140160412414051568
domContentLoaded13131139160412414051568
domInteractive1073130662103287
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect28204763143
firstReactRender35296643741
getState63213611
initialActions3024335
loadScripts12921112158412513861548
setupStore2451368136818

- feat: path based blocking (#36634)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
Introduces URL path based blocking within the extension. This allows
websites like `example.com/path` to be blocked rather than blocking all
of `example.com`.

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/36634?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Added path-based blocking for URLs

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to `sites.google.com/view/aoooop/aave-com` and make sure that it
you are redirected to the Phishing Warning Page
2. Go to `sites.google.com/view/aoooop/` and make sure that it does not
redirect you.
3. Go to `sites.google.com/view/aoooop/aave-com/path` and make sure that
you are redirected to the Phishing Warning Page.
4. Click proceed anyway
5. Going to `sites.google.com/view/aoooop/aave-com` should also no
longer redirect to the Phishing Warning Page.
6. Going to `sites.google.com/view/aoooop/aave-com/path` should also no
longer redirect to the Phishing Warning Page (implicit in step 4).

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Introduce trie-based path matching for phishing detection, add path
whitelisting, migrate hotlist diffs to v2, and update tests/mocks and
dependencies.
> 
> - **Phishing Detection**:
> - **Path-based blocking**: Add `PathTrie` (insert/delete/match,
list->trie, deep copy) used to match `hostname+path`.
> - **Controller (`PhishingController`)**: new `state.whitelistPaths`;
`test`/`bypass` honor path matches; parse stalelist `blocklistPaths` via
`convertListToTrie`; hotlist diffs endpoint to `v2`.
> - **Detector (`PhishingDetector`)**: check `blocklistPaths` with
`matchedPathPrefix`; expose `blockingPath(url)`.
> - **Utils**: add `getHostnameAndPathComponents`/`getPathnameFromUrl`;
`applyDiffs` supports `blocklistPaths` with trie ops; minor config
cleanup.
> - **Tests/Mocks**:
> - Update E2E/unit tests for path-based logic; add mock pages with
nested paths; adjust phishing mocks/schema; expect `diffsSince v2`;
metrics masks include `whitelistPaths`.
> - **State/Telemetry**: Sanitize/remove `whitelistPaths` from UI state
and snapshots.
> - **Build & Deps**:
> - Patch `@metamask/phishing-controller` (adds new dist files); bump
`@metamask/phishing-warning`; lockfile/attributions updates; LavaMoat
policies allow `console.error` for base-controller.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
5b70d32. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: augmentedmode <[email protected]>
[8bdd1e1](8bdd1e1)

---------

Co-authored-by: imblue <[email protected]>
Co-authored-by: imblue-dabadee <[email protected]>
Co-authored-by: MetaMask Bot <[email protected]>
Copy link

socket-security bot commented Oct 14, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​messenger@​0.2.0 ⏵ 0.3.010010076 +189 -1100
Updated@​metamask/​base-controller@​8.3.0 ⏵ 8.4.11001007794100
Updated@​metamask/​controller-utils@​11.12.0 ⏵ 11.14.199 +110077 +196 +2100
Updated@​metamask/​utils@​11.7.0 ⏵ 11.8.199 +110094 +194 -2100
Updated@​metamask/​phishing-warning@​5.0.1 ⏵ 5.1.0100 +8100100 +7100 +10100

View full report

@gauthierpetetin gauthierpetetin marked this pull request as ready for review October 14, 2025 19:06
@gauthierpetetin gauthierpetetin requested review from a team as code owners October 14, 2025 19:06
cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator Author

Builds ready [8ae39c5]
UI Startup Metrics (1325 ± 86 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1325118116078613751542
load114398814118111841319
domContentLoaded113198013968311751311
domInteractive20155281945
firstPaint72380138346911461256
backgroundConnect27625246328279297
firstReactRender2917107133150
getState16690122034
initialActions50335614
loadScripts8677271118809041035
setupStore1162741119
WebpackHomeuiStartup20201406261826321862449
load16121115195721317731918
domContentLoaded16041107195121317601914
domInteractive1812107151546
firstPaint1626252968188289
backgroundConnect3513349453254
firstReactRender85374547084327
getState2743166514270
initialActions8216917621
loadScripts16001105194121217561911
setupStore2862876115243
FirefoxBrowserifyHomeuiStartup13841204173510214421631
load1196105513807312431335
domContentLoaded1195105413807312421335
domInteractive1023429948111206
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3520198223578
firstReactRender26235142731
getState8314716612
initialActions8118627343
loadScripts1170103713507212181304
setupStore948210825
WebpackHomeuiStartup15301346187013516261804
load13141137160612514031555
domContentLoaded13141136160512514031554
domInteractive1073333066100300
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect31194873646
firstReactRender35305043742
getState63152610
initialActions206135
loadScripts12911107158712713831534
setupStore9515615914

chloeYue
chloeYue previously approved these changes Oct 15, 2025
…ons (#36896)

- ci: GitHub Actions time usage optimizations (#36629)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

- [Add `concurrency` field to

`update-lavamoat-policies`.](a20025f)
- Saves approx. 20 minutes of billable time (=runtime of
`update-lavamoat-policies`) for each `@metamaskbot update-policies`
comment.
- Cancels CI run when the comment is posted, instead of waiting for the
`update-lavamoat-policies` workflow to complete.
- Excluded release branches, where even an incomplete CI run might
provide useful info.

- Set `timeout-minutes` for all jobs to 30 (instead of default of 360).
- Example of 6-hour run:

https://github.com/MetaMask/metamask-extension/actions/runs/18155641151/job/51675026463?pr=33539

> All jobs should set

[timeout-minutes](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes).
> ...
> By default, GitHub Actions kills workflows after 6 hours if they have
not finished by then. Many workflows don't need nearly as much time to
finish, but sometimes unexpected errors occur or a job hangs until the
workflow run is killed 6 hours after starting it. Therefore it's
recommended to specify a shorter timeout.
> ...
> This has the following advantages:
> 
> PRs won't be pending CI for half the day, issues can be caught early
or workflow runs can be restarted. The number of overall parallel builds
is limited, hanging jobs will not cause issues for other PRs if they are
cancelled early.
>
> --

[`ghalint`](https://github.com/suzuki-shunsuke/ghalint/blob/main/docs/policies/012.md#job_timeout_minutes_is_required)

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/36629?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Sets 30-minute timeouts across GitHub Actions jobs and adds
concurrency to `update-lavamoat-policies` to cancel superseded runs
(excluding `release/*`).
> 
> - **CI/GitHub Actions**
> - **Job timeouts**: Add `timeout-minutes: 30` to jobs across workflows
(e.g., `main.yml`, tests, builds, e2e, releases, checks) to cap runtime.
> - **Concurrency control**: Add `concurrency` to
`update-lavamoat-policies.yml` to cancel in-progress runs for the same
ref, excluding `release/*` branches.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
8169786. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->


[8453e5e](8453e5e)

Co-authored-by: Jongsun Suh <[email protected]>
runway-github bot and others added 3 commits October 15, 2025 16:31
…release pr template (#36890)

- fix(pr template): Use latest version of release pr template (#36743)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

The purpose of this PR is to use the latest version of the release PR
template.
It's a minor change, and it's been tested on this test repo:

consensys-test#201

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/36743?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Update `.github/workflows/create-release-pr.yml` to use
MetaMask/github-tools workflow and `github-tools-version` at SHA
`7fe185fdb0e60981c898e88d82e44ff33f604daa`.
> 
> - **CI/Workflows**:
> - Update `create-release-pr.yml` to reference
`MetaMask/github-tools/.github/workflows/create-release-pr.yml@7fe185fdb0e60981c898e88d82e44ff33f604daa`.
> - Sync `github-tools-version` input to
`7fe185fdb0e60981c898e88d82e44ff33f604daa`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
0a2922e. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->


[d073679](d073679)

Co-authored-by: Gauthier Petetin <[email protected]>
…o use topology.json (#36891)

- MCRM-8: Updated add-team-label worklow to use topology.json (#36731)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Ticket: https://consensyssoftware.atlassian.net/browse/MCRM-8
github-tools change: MetaMask/github-tools#137

Testing:

consensys-test#200,

https://github.com/consensys-test/metamask-extension-test-workflow2/actions/runs/18387086043

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/36731?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
[220b8c6](220b8c6)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Bumps the `add-team-label` reusable workflow to a newer commit in
`metamask/github-tools`.
> 
> - **CI / GitHub Actions**:
> - Update reusable workflow reference in
`.github/workflows/add-team-label.yml` to
`metamask/github-tools/.github/workflows/add-team-label.yml@7fe185f...`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
97bd029. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Pavel Dvorkin <[email protected]>
Co-authored-by: Gauthier Petetin <[email protected]>
…#36629)" (#36769) (#36898)

- fix: Revert changes from "ci: GitHub Actions time usage optimizations
(#36629)" (#36769)

This reverts changes from commit
8453e5e.

The `concurrency` field added to `update-lavavmoat-policies.yml` is
scoped incorrectly, and is blocking workflow runs.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/36769?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Removes the workflow-level `concurrency` block from
`.github/workflows/update-lavamoat-policies.yml`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
56c20f6. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->




[7846af3](7846af3)

Co-authored-by: Jongsun Suh <[email protected]>
@metamaskbot
Copy link
Collaborator Author

Builds ready [f7ca950]
UI Startup Metrics (1236 ± 86 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1236110315268612821413
load107194113508111201228
domContentLoaded106493513438111121217
domInteractive17135961735
firstPaint66779135144010691167
backgroundConnect24823143520249264
firstReactRender24174262640
getState14592101725
initialActions40516612
loadScripts82470298675874965
setupStore952331016
WebpackHomeuiStartup20061487256127121912482
load16131194193920317531895
domContentLoaded16051188192320217461888
domInteractive1712100131543
firstPaint1696638267201336
backgroundConnect3115359343053
firstReactRender98373318285322
getState2753056513275
initialActions52244612
loadScripts16011186191920017441877
setupStore156268261420
FirefoxBrowserifyHomeuiStartup14641287197910815171663
load1265111615527613201389
domContentLoaded1265111515517613201389
domInteractive1063328146111222
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect41222603139103
firstReactRender28234732934
getState9322322815
initialActions616010438
loadScripts1233108515317612851351
setupStore125207211025
WebpackHomeuiStartup15961384217917316981908
load13591175171714814891613
domContentLoaded13591174171714814881612
domInteractive1123435268110303
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3524127133949
firstReactRender38317764047
getState64455612
initialActions3119235
loadScripts13331139169814814641586
setupStore10610410921

@gauthierpetetin gauthierpetetin merged commit 6317069 into stable Oct 15, 2025
274 of 279 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.4.3 Issue or pull request that will be included in release 13.4.3 team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants