fix(script): delete unused generate-rc-commits.js script #36814

gauthierpetetin · 2025-10-13T13:06:00Z

Description

Based on @chloeYue , the generate-rc-commits.js script was used to manually generate the commit list for the release progress tracker in old format. Now we have the new format and automation in place, so we don't need it anymore and it can be deleted.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Removes the deprecated development/generate-rc-commits.js script.

^{Written by Cursor Bugbot for commit f2ebb03. This will update automatically on new commits. Configure here.}

github-actions · 2025-10-13T13:06:13Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-10-13T13:32:47Z

📊 Page Load Benchmark Results

Current Commit: f2ebb03 | Date: 10/13/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±72ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 725ms (±68ms) 🟢 | historical mean value: 738ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±13ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	72ms	999ms	1.31s	1.28s	1.31s
domContentLoaded	725ms	68ms	693ms	990ms	956ms	990ms
firstPaint	75ms	13ms	56ms	180ms	84ms	180ms
firstContentfulPaint	75ms	13ms	56ms	180ms	84ms	180ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-13T13:32:52Z

Builds ready [f2ebb03]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1239 ± 75 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1239	1085	1486	75	1285	1368
			load	1072	949	1283	65	1117	1177
			domContentLoaded	1065	944	1278	65	1112	1170
			domInteractive	18	13	128	12	17	37
			firstPaint	713	77	1291	428	1093	1157
			backgroundConnect	251	237	274	7	254	266
			firstReactRender	27	19	52	7	31	42
			getState	12	5	99	11	14	26
			initialActions	4	0	24	5	6	13
			loadScripts	821	707	1016	63	867	924
			setupStore	10	5	24	4	10	22
	Webpack	Home	uiStartup	816	700	1052	69	830	987
			load	628	579	906	67	629	815
			domContentLoaded	620	571	899	67	622	808
			domInteractive	16	11	74	9	14	36
			firstPaint	188	57	887	181	194	592
			backgroundConnect	21	11	38	6	26	30
			firstReactRender	27	16	65	10	31	42
			getState	7	3	12	2	9	11
			initialActions	2	0	11	2	3	6
			loadScripts	617	569	888	65	619	797
			setupStore	8	4	20	2	9	12
Firefox	Browserify	Home	uiStartup	1447	1228	1883	125	1501	1685
			load	1237	1069	1530	89	1295	1381
			domContentLoaded	1237	1069	1530	89	1294	1380
			domInteractive	100	33	328	55	100	248
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	20	99	14	33	51
			firstReactRender	30	26	66	5	32	39
			getState	6	3	37	5	6	13
			initialActions	4	0	131	14	2	24
			loadScripts	1213	1054	1507	88	1266	1355
			setupStore	10	4	59	12	7	50
	Webpack	Home	uiStartup	1545	1388	2043	121	1601	1770
			load	1345	1238	1583	80	1393	1509
			domContentLoaded	1345	1238	1583	80	1393	1508
			domInteractive	100	30	369	66	97	331
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	17	120	14	35	53
			firstReactRender	35	27	92	11	36	59
			getState	7	3	145	15	5	21
			initialActions	4	0	120	13	2	14
			loadScripts	1321	1212	1534	78	1367	1485
			setupStore	12	4	149	22	6	46

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

…cies

metamaskbot · 2025-10-14T13:45:12Z

📊 Page Load Benchmark Results

Current Commit: 8b80f1a | Date: 10/14/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.08s (±75ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 757ms (±72ms) 🟢 | historical mean value: 737ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±13ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.08s	75ms	1.03s	1.37s	1.32s	1.37s
domContentLoaded	757ms	72ms	714ms	1.04s	1.00s	1.04s
firstPaint	80ms	13ms	68ms	200ms	88ms	200ms
firstContentfulPaint	80ms	13ms	68ms	200ms	88ms	200ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-14T13:45:17Z

Builds ready [8b80f1a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1248 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1248	1126	1427	57	1288	1335
			load	1071	972	1199	53	1111	1160
			domContentLoaded	1064	967	1193	53	1104	1154
			domInteractive	19	14	79	9	17	39
			firstPaint	637	80	1182	428	1082	1137
			backgroundConnect	256	239	398	16	259	269
			firstReactRender	25	18	69	6	25	39
			getState	12	5	95	12	13	26
			initialActions	5	0	79	9	5	15
			loadScripts	815	730	940	51	850	909
			setupStore	8	5	22	3	9	13
	Webpack	Home	uiStartup	861	734	1155	75	882	1040
			load	650	589	962	65	660	796
			domContentLoaded	642	582	952	65	654	789
			domInteractive	16	12	43	7	15	36
			firstPaint	191	59	912	196	196	676
			backgroundConnect	22	11	53	7	27	33
			firstReactRender	28	17	70	9	33	38
			getState	9	3	47	5	10	15
			initialActions	2	0	10	2	4	6
			loadScripts	640	580	941	62	652	778
			setupStore	9	4	28	3	10	14
Firefox	Browserify	Home	uiStartup	1377	1222	1900	119	1436	1612
			load	1175	1054	1363	83	1251	1320
			domContentLoaded	1174	1053	1362	83	1251	1319
			domInteractive	98	33	298	52	97	235
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	28	18	96	11	32	39
			firstReactRender	29	25	56	5	31	36
			getState	8	3	181	18	5	17
			initialActions	3	0	65	8	2	20
			loadScripts	1153	1038	1335	81	1222	1301
			setupStore	10	4	146	17	7	48
	Webpack	Home	uiStartup	1527	1356	2008	119	1572	1795
			load	1325	1203	1713	88	1359	1492
			domContentLoaded	1325	1203	1713	88	1359	1492
			domInteractive	97	32	350	56	101	192
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	18	94	10	34	48
			firstReactRender	35	25	79	13	35	75
			getState	8	3	106	13	5	43
			initialActions	4	0	139	15	2	16
			loadScripts	1302	1187	1690	86	1334	1466
			setupStore	11	4	159	20	7	45

Bundle size diffs [🚀 Bundle size reduced!]

background: 796 Bytes (0.02%)
ui: 9.76 KiB (0.15%)
common: -25.41 KiB (-0.3%)

fi(script): delete unused generate-rc-commits.js script

f2ebb03

gauthierpetetin self-assigned this Oct 13, 2025

gauthierpetetin added the extension-delivery label Oct 13, 2025

gauthierpetetin added this to PR review queue Oct 13, 2025

github-project-automation bot moved this to Needs dev review in PR review queue Oct 13, 2025

metamaskbot added the team-extension-platform Extension Platform team label Oct 13, 2025

github-actions bot added the size-M label Oct 13, 2025

chloeYue previously approved these changes Oct 13, 2025

View reviewed changes

vpintorico previously approved these changes Oct 14, 2025

View reviewed changes

github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Oct 14, 2025

gauthierpetetin changed the title ~~fi(script): delete unused generate-rc-commits.js script~~ fix(script): delete unused generate-rc-commits.js script Oct 14, 2025

fix(dependencies): remove unused simple-git and octokit/core dependen…

8b80f1a

…cies

gauthierpetetin dismissed stale reviews from vpintorico and chloeYue via 8b80f1a October 14, 2025 13:18

chloeYue approved these changes Oct 14, 2025

View reviewed changes

vpintorico approved these changes Oct 16, 2025

View reviewed changes

gauthierpetetin added this pull request to the merge queue Oct 16, 2025

Merged via the queue into main with commit b19a4e4 Oct 16, 2025
169 checks passed

gauthierpetetin deleted the delete-unused-script branch October 16, 2025 12:45

github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Oct 16, 2025

github-actions bot locked and limited conversation to collaborators Oct 16, 2025

metamaskbot added the release-13.6.0 Issue or pull request that will be included in release 13.6.0 label Oct 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(script): delete unused generate-rc-commits.js script #36814

fix(script): delete unused generate-rc-commits.js script #36814

gauthierpetetin commented Oct 13, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

metamaskbot commented Oct 13, 2025

Uh oh!

metamaskbot commented Oct 13, 2025

Uh oh!

metamaskbot commented Oct 14, 2025

Uh oh!

metamaskbot commented Oct 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix(script): delete unused generate-rc-commits.js script #36814

fix(script): delete unused generate-rc-commits.js script #36814

Conversation

gauthierpetetin commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

metamaskbot commented Oct 13, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 13, 2025

Uh oh!

metamaskbot commented Oct 14, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gauthierpetetin commented Oct 13, 2025 •

edited

Loading