fix: flaky test Multichain API Call wallet_createSession With requested EVM scope... issue with fill
#36818
+36
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
seaona
added
no-changelog
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [b9ceb76]
UI Startup Metrics (1180 ± 66 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (1 files, +3 -3)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [aa4d8a0]
UI Startup Metrics (1244 ± 63 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
seaona
commented
Oct 13, 2025
| ); | ||
| await this.clickConnectExternallyConnectableButton(); | ||
| await this.driver.delay(largeDelayMs); | ||
| await this.driver.delay(veryLargeDelayMs); |
There was a problem hiding this comment.
this intends to mitigate this other error - it seems a large delay wasn't sufficient
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [c83017f]
UI Startup Metrics (1250 ± 72 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
seaona
added
no-changelog
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [1022e62]
UI Startup Metrics (1216 ± 64 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
seaona
commented
Oct 14, 2025
| * '0xc427D562164062a23a5cFf596A4a3208e72Acd28'); | ||
| */ | ||
| async fill(rawLocator, input) { | ||
| async fill(rawLocator, input, { retries = 0 } = {}) { |
There was a problem hiding this comment.
ℹ️ I choose to make this as a param with 0 as default, because the verification path can break existing specs (those where the input is then changed after being added (ie send ens domain etc), so it cannot be used everywhere
jvbriones
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fill method is flaky as in this spec we can see how the extension id was sent twice, making the spec fail as the dapp fails with
Error connecting: TypeError: Error in invocation of runtime.connect(optional string extensionId, optional object connectInfo): Invalid extension id: 'hebhblbkkdabgoldnojllkipeoacjiochebhblbkkdabgoldnChangelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a retry/verification option to
driver.filland uses it in the multichain dapp page, plus increases the connect delay to reduce flakiness.test/e2e/webdriver/driver.js):fill(rawLocator, input, { retries })to support optional retries with value verification viagetAttribute('value')andwaitUntil; throws if not set after attempts. Updates JSDoc accordingly.test/e2e/page-objects/pages/test-dapp-multichain.ts):driver.fill(..., { retries: 3 })forextensionIdinput.largeDelayMstoveryLargeDelayMs.Written by Cursor Bugbot for commit 1022e62. This will update automatically on new commits. Configure here.