Skip to content

Conversation

seaona
Copy link
Member

@seaona seaona commented Oct 13, 2025

Description

Removing Swap entries from the e2e live requests allowlist

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-431

Manual testing steps

  1. Check ci

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Cursor Bugbot is generating a summary for commit 405a3c0. Configure here.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Oct 13, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🧪 @MetaMask/qa (1 files, +0 -8)
  • 📁 test/
    • 📁 e2e/
      • 📄 mock-e2e-allowlist.js +0 -8

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 405a3c0 | Date: 10/13/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±73ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 732ms (±70ms) 🟢 | historical mean value: 737ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 73ms 1.01s 1.34s 1.25s 1.34s
domContentLoaded 732ms 70ms 695ms 1.02s 936ms 1.02s
firstPaint 77ms 13ms 60ms 184ms 88ms 184ms
firstContentfulPaint 77ms 13ms 60ms 184ms 88ms 184ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [405a3c0]
UI Startup Metrics (1237 ± 86 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1237111516138612781404
load106695514558010951208
domContentLoaded106095114478010881193
domInteractive1813125131737
firstPaint51987148841610271162
backgroundConnect2502362777254266
firstReactRender25195172643
getState1257791427
initialActions50406514
loadScripts815714120179840945
setupStore962031015
WebpackHomeuiStartup815690107672834974
load62557091564629789
domContentLoaded61756790364623782
domInteractive15115781436
firstPaint19856866174196590
backgroundConnect2193152530
firstReactRender271678103146
getState833441013
initialActions2012236
loadScripts61556589362622771
setupStore842331013
FirefoxBrowserifyHomeuiStartup13861221176212114211697
load1183105013637512301327
domContentLoaded1183105013637512291327
domInteractive99334326295235
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3018102163270
firstReactRender29244343038
getState62234517
initialActions30649212
loadScripts1161103013367212041305
setupStore11413722728
WebpackHomeuiStartup15251319194911815561800
load1330116916528913711520
domContentLoaded1329116916518913711520
domInteractive972934658100224
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect281786113440
firstReactRender362680143875
getState7312713514
initialActions409212215
loadScripts1308115316298713491493
setupStore946511732
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

@seaona seaona marked this pull request as ready for review October 13, 2025 16:12
@seaona seaona requested a review from a team as a code owner October 13, 2025 16:12
@seaona seaona self-assigned this Oct 13, 2025
@seaona seaona added flaky tests e2e-maintenance no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Oct 13, 2025
@seaona seaona changed the title test: remove Swap live requests from the allowlist and add the corresponding mocks test: remove Swap live requests from the allowlist Oct 13, 2025
@seaona seaona enabled auto-merge October 13, 2025 16:15
Copy link
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@seaona seaona requested a review from a team October 14, 2025 06:59
@seaona seaona added this pull request to the merge queue Oct 14, 2025
Merged via the queue into main with commit 62380ce Oct 14, 2025
204 of 213 checks passed
@seaona seaona deleted the e2e-remove-swap-mocks branch October 14, 2025 10:16
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2025
@metamaskbot metamaskbot added the release-13.6.0 Issue or pull request that will be included in release 13.6.0 label Oct 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

e2e-maintenance flaky tests no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.6.0 Issue or pull request that will be included in release 13.6.0 size-XS team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants