docs(README): Test PR - Do not merge #36823

gauthierpetetin · 2025-10-13T15:50:52Z

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds test placeholder lines to README.md and a non-functional comment in app/scripts/metamask-controller.js constructor.

^{Written by Cursor Bugbot for commit 8845fad. This will update automatically on new commits. Configure here.}

github-actions · 2025-10-13T15:50:59Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-10-13T16:20:21Z

📊 Page Load Benchmark Results

Current Commit: dd617e1 | Date: 10/13/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±73ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 751ms (±71ms) 🟢 | historical mean value: 737ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	73ms	1.03s	1.34s	1.32s	1.34s
domContentLoaded	751ms	71ms	709ms	1.02s	993ms	1.02s
firstPaint	78ms	11ms	64ms	160ms	88ms	160ms
firstContentfulPaint	78ms	11ms	64ms	160ms	88ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-13T16:20:35Z

Builds ready [dd617e1]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1222 ± 94 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1222	1094	1901	94	1269	1329
			load	1054	932	1573	80	1095	1162
			domContentLoaded	1048	924	1563	80	1090	1156
			domInteractive	18	13	118	11	16	35
			firstPaint	745	86	1587	420	1070	1146
			backgroundConnect	250	236	359	13	251	263
			firstReactRender	24	17	60	6	23	39
			getState	11	5	38	6	12	25
			initialActions	4	0	63	7	4	17
			loadScripts	804	676	1302	78	838	912
			setupStore	8	4	23	3	9	16
	Webpack	Home	uiStartup	860	731	1070	65	890	971
			load	657	598	892	60	668	785
			domContentLoaded	649	591	883	60	658	779
			domInteractive	16	12	53	8	15	39
			firstPaint	215	58	877	215	198	739
			backgroundConnect	22	11	47	7	27	34
			firstReactRender	28	18	62	9	34	40
			getState	9	3	23	4	11	17
			initialActions	2	0	7	2	3	7
			loadScripts	646	589	872	58	655	777
			setupStore	8	4	18	2	10	12
Firefox	Browserify	Home	uiStartup	1395	1200	1707	106	1458	1582
			load	1200	1039	1455	86	1257	1354
			domContentLoaded	1199	1039	1455	86	1257	1354
			domInteractive	104	34	333	56	112	251
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	18	120	19	33	67
			firstReactRender	30	25	53	5	31	41
			getState	8	3	90	12	6	27
			initialActions	3	0	40	6	2	12
			loadScripts	1176	1022	1436	85	1237	1326
			setupStore	8	3	59	9	7	28
	Webpack	Home	uiStartup	1635	1425	2243	149	1684	1970
			load	1405	1231	1873	112	1464	1635
			domContentLoaded	1404	1230	1872	112	1464	1634
			domInteractive	107	31	400	78	102	367
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	36	20	156	21	39	78
			firstReactRender	39	29	92	13	40	81
			getState	9	3	97	14	6	23
			initialActions	7	0	130	18	2	47
			loadScripts	1378	1214	1763	103	1441	1605
			setupStore	13	4	148	19	8	52

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

metamaskbot · 2025-10-14T09:08:03Z

📊 Page Load Benchmark Results

Current Commit: de7fd78 | Date: 10/14/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±71ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 738ms (±69ms) 🟢 | historical mean value: 737ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±10ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	71ms	1.01s	1.32s	1.26s	1.32s
domContentLoaded	738ms	69ms	699ms	999ms	939ms	999ms
firstPaint	76ms	10ms	60ms	160ms	84ms	160ms
firstContentfulPaint	76ms	10ms	60ms	160ms	84ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-14T09:08:08Z

Builds ready [de7fd78]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1246 ± 84 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1246	1103	1535	84	1288	1422
			load	1075	960	1309	77	1113	1243
			domContentLoaded	1066	948	1301	77	1101	1237
			domInteractive	18	14	52	7	17	34
			firstPaint	735	143	1308	421	1087	1216
			backgroundConnect	258	241	361	16	260	286
			firstReactRender	27	18	149	15	26	39
			getState	11	5	64	8	11	21
			initialActions	4	0	53	6	4	14
			loadScripts	816	694	999	73	852	975
			setupStore	8	5	24	3	9	16
	Webpack	Home	uiStartup	823	705	1106	74	852	971
			load	646	580	948	80	651	831
			domContentLoaded	639	575	939	80	642	815
			domInteractive	15	11	45	8	14	38
			firstPaint	191	56	849	177	195	595
			backgroundConnect	20	11	42	6	25	32
			firstReactRender	25	16	52	7	31	33
			getState	8	3	17	3	9	14
			initialActions	2	0	14	2	2	6
			loadScripts	636	573	928	78	641	805
			setupStore	8	4	16	2	9	12
Firefox	Browserify	Home	uiStartup	1372	1211	1809	118	1433	1585
			load	1178	1054	1363	86	1246	1321
			domContentLoaded	1177	1054	1362	86	1246	1320
			domInteractive	98	33	309	53	102	233
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	28	18	125	12	32	40
			firstReactRender	29	24	52	5	31	39
			getState	7	3	59	9	5	27
			initialActions	3	0	130	13	2	6
			loadScripts	1156	1039	1346	85	1228	1303
			setupStore	8	4	57	10	7	36
	Webpack	Home	uiStartup	1593	1388	2037	119	1640	1824
			load	1381	1229	1722	91	1440	1545
			domContentLoaded	1380	1228	1722	91	1440	1545
			domInteractive	98	31	370	63	105	306
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	19	122	18	36	62
			firstReactRender	36	27	84	10	37	74
			getState	7	3	47	7	6	15
			initialActions	5	0	59	9	3	24
			loadScripts	1355	1202	1690	88	1398	1518
			setupStore	12	4	151	19	8	49

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 81 Bytes (0%)
ui: 5.09 KiB (0.08%)
common: 688 Bytes (0.01%)

metamaskbot · 2025-10-15T13:43:27Z

📊 Page Load Benchmark Results

Current Commit: 8845fad | Date: 10/15/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±71ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 736ms (±69ms) 🟢 | historical mean value: 740ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	71ms	1.01s	1.33s	1.26s	1.33s
domContentLoaded	736ms	69ms	698ms	1.02s	947ms	1.02s
firstPaint	77ms	11ms	60ms	172ms	88ms	172ms
firstContentfulPaint	77ms	11ms	60ms	172ms	88ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-15T13:43:42Z

Builds ready [8845fad]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1273 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1273	1125	1435	69	1326	1401
			load	1090	977	1249	62	1142	1200
			domContentLoaded	1085	972	1244	62	1134	1196
			domInteractive	19	14	121	12	17	43
			firstPaint	705	101	1230	436	1105	1176
			backgroundConnect	254	241	278	7	258	270
			firstReactRender	26	17	51	7	28	42
			getState	18	5	89	13	20	35
			initialActions	5	0	69	8	6	13
			loadScripts	836	723	991	60	882	950
			setupStore	10	6	32	3	10	15
	Webpack	Home	uiStartup	894	760	1208	78	912	1069
			load	677	618	1030	80	680	910
			domContentLoaded	668	611	1015	79	674	900
			domInteractive	16	12	49	7	16	37
			firstPaint	200	65	1019	200	187	643
			backgroundConnect	25	11	64	9	31	38
			firstReactRender	29	17	120	12	33	37
			getState	10	4	37	5	11	18
			initialActions	3	0	16	2	4	6
			loadScripts	665	609	1004	77	672	888
			setupStore	11	6	24	3	13	15
Firefox	Browserify	Home	uiStartup	1509	1329	2064	150	1555	1929
			load	1252	1116	1470	83	1320	1416
			domContentLoaded	1252	1115	1470	83	1319	1416
			domInteractive	103	35	294	55	107	259
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	42	25	134	22	44	101
			firstReactRender	32	26	65	6	32	41
			getState	11	6	197	19	10	20
			initialActions	8	2	201	21	4	28
			loadScripts	1225	1095	1443	81	1292	1390
			setupStore	18	7	214	32	12	57
	Webpack	Home	uiStartup	1585	1390	2026	118	1639	1825
			load	1354	1192	1600	85	1418	1498
			domContentLoaded	1354	1192	1599	85	1418	1498
			domInteractive	106	30	400	83	102	358
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	36	21	134	16	42	66
			firstReactRender	33	25	83	10	34	51
			getState	9	3	70	7	9	13
			initialActions	7	2	186	22	3	15
			loadScripts	1330	1173	1575	84	1387	1479
			setupStore	13	6	100	14	11	48

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.37 KiB (0.05%)
ui: 10.73 KiB (0.17%)
common: 11.37 KiB (0.14%)

docs(README): add test

ff718bf

gauthierpetetin self-assigned this Oct 13, 2025

metamaskbot added the team-extension-platform Extension Platform team label Oct 13, 2025

github-actions bot added the size-XS label Oct 13, 2025

docs(README): add a second test

dd617e1

docs(metamask-controller): add comment

de7fd78

This comment was marked as outdated.

Sign in to view

gauthierpetetin added 2 commits October 15, 2025 15:11

Add test comment

558fb92

remove test comment

8845fad

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

docs(README): Test PR - Do not merge #36823

docs(README): Test PR - Do not merge #36823

gauthierpetetin commented Oct 13, 2025 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

metamaskbot commented Oct 13, 2025

Uh oh!

metamaskbot commented Oct 13, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Oct 14, 2025

Uh oh!

metamaskbot commented Oct 14, 2025

Uh oh!

metamaskbot commented Oct 15, 2025

Uh oh!

metamaskbot commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

docs(README): Test PR - Do not merge #36823

Are you sure you want to change the base?

docs(README): Test PR - Do not merge #36823

Conversation

gauthierpetetin commented Oct 13, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

metamaskbot commented Oct 13, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 13, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Oct 14, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 14, 2025

Uh oh!

metamaskbot commented Oct 15, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gauthierpetetin commented Oct 13, 2025 •

edited by cursor bot

Loading