-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: cp-13.5.0 Send functionality related fixes #36831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+121
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (9 files, +115 -21)
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [6b1e9ae]
UI Startup Metrics (1210 ± 62 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
pedronfigueiredo
approved these changes
Oct 14, 2025
vinistevam
approved these changes
Oct 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
no-changelog
no-changelog Indicates no external facing user changes, therefore no changelog documentation needed
release-13.6.0
Issue or pull request that will be included in release 13.6.0
size-M
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Multiple small new send implementation related fixes.
Changelog
CHANGELOG entry:
Related issues
Fixes: #36787
Fixes: #36789
Fixes: #36757
Manual testing steps
Screenshots/Recordings
TODO
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Refines send flow by showing fiat currency code in Amount, exposing fiatCurrencyName, safely handling missing gas estimates for max amount, standardizing name-resolution error, and returning unique recipients (with tests and i18n updates).
ui/.../amount.tsx
): Show fiat currency code when in fiat mode; usesfiatCurrencyName
fromuseCurrencyConversions
.useCurrencyConversions.ts
): ExposefiatCurrencyName
in hook return.useMaxAmount.ts
): Gracefully handle missinggasFeeEstimates
(default to0
) ingetEstimatedTotalGas
.useNameValidation.ts
): Useerror: \
nameResolutionFailedError`` for failed lookups.useRecipients.ts
): Return accounts first and de-duplicate contacts by address.nameResolutionFailedError
string toapp/_locales/en/messages.json
anden_GB/messages.json
.fiatCurrencySymbol: '$'
and assertUSD
; add coverage for fiat toggle behavior.Written by Cursor Bugbot for commit 6b1e9ae. This will update automatically on new commits. Configure here.