Skip to content

fix: layout inconsistencies - snaps #38534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
n3ps wants to merge 4 commits into
base: main
Choose a base branch
from
+3 −18
Open

fix: layout inconsistencies - snaps #38534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
763ef57
snaps
n3ps Dec 3, 2025
76a672a
more
n3ps Dec 3, 2025
1bf6a99
cleanup
n3ps Dec 3, 2025
307ee60
Merge branch 'main' into n3ps/layout-polish-snaps
n3ps Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/pages/routes/routes.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,14 +730,14 @@ export default function Routes() {
component={Notifications}
layout={RootLayout}
/>
<RouteWithLayout path={SNAPS_ROUTE} exact layout={LegacyLayout}>
<RouteWithLayout path={SNAPS_ROUTE} exact layout={RootLayout}>
{createV5CompatRoute(SnapList, {
wrapper: AuthenticatedV5Compat,
includeNavigate: true,
includeLocation: true,
})}
</RouteWithLayout>
<RouteWithLayout path={SNAPS_VIEW_ROUTE} layout={LegacyLayout}>
<RouteWithLayout path={SNAPS_VIEW_ROUTE} layout={RootLayout}>
{createV5CompatRoute(SnapView, {
wrapper: AuthenticatedV5Compat,
includeNavigate: true,
Expand Down
15 changes: 0 additions & 15 deletions ui/pages/snaps/snaps-list/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@

.snaps {
$height-screen-sm-max: 100%;
$width-screen-sm-min: 85vw;
$width-screen-md-min: 80vw;
$width-screen-lg-min: 62vw;

// prevent overflow-x
max-width: 100%;
Expand All @@ -15,18 +12,6 @@
height: $height-screen-sm-max;
}

@include design-system.screen-sm-min {
Copy link
Contributor Author

@n3ps n3ps Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let the layout handle widths

width: $width-screen-sm-min;
}

@include design-system.screen-md-min {
width: $width-screen-md-min;
}

@include design-system.screen-lg-min {
width: $width-screen-lg-min;
}

&__content {
padding: 0;

Expand Down
2 changes: 1 addition & 1 deletion ui/pages/snaps/snaps-list/snap-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const SnapList = ({ navigate: navigateProp }) => {
const snapUpdateMap = useSelector(getAllSnapAvailableUpdates);

return (
<div className="snaps">
<div className="snaps h-full">
<Page backgroundColor={BackgroundColor.backgroundDefault}>
<Header
backgroundColor={BackgroundColor.backgroundDefault}
Expand Down
Loading