feat: Implement dataType migration for seedless onboarding secrets #38540

huggingbot · 2025-12-04T04:24:42Z

Description

Adds client-side migration to assign dataType column values to legacy seedless onboarding secrets. This categorizes backed-up data as PrimarySrp, ImportedSrp, or ImportedPrivateKey.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/SL-350

Manual testing steps

Create a new wallet via social login and verify migration version is set
Unlock an existing social login wallet with legacy secrets and verify dataType is assigned
Import a new SRP/private key and verify correct dataType is passed

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2025-12-04T04:59:45Z

Builds ready [d200905]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1213 ± 94 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1213	986	1433	94	1280	1390
			load	1018	852	1221	82	1070	1189
			domContentLoaded	1013	847	1216	81	1065	1174
			domInteractive	25	15	102	18	21	75
			firstPaint	537	95	1218	397	995	1136
			backgroundConnect	216	194	278	14	225	239
			firstReactRender	30	17	58	10	37	53
			getState	35	17	109	16	39	62
			initialActions	1	0	3	1	1	2
			loadScripts	803	651	1005	78	842	952
			setupStore	11	7	30	4	13	22
			numNetworkReqs	11	5	70	17	5	59
	Browserify	Power User Home	uiStartup	1968	1608	2497	218	2116	2372
			load	986	852	1469	133	1020	1301
			domContentLoaded	975	844	1459	133	1010	1294
			domInteractive	29	16	96	20	27	89
			firstPaint	660	95	1512	381	935	1288
			backgroundConnect	254	188	718	116	226	531
			firstReactRender	54	39	95	11	60	74
			getState	189	151	312	27	202	242
			initialActions	1	0	4	1	1	2
			loadScripts	774	663	1241	127	806	1098
			setupStore	17	9	60	10	16	37
			numNetworkReqs	80	66	233	30	74	159
	Webpack	Standard Home	uiStartup	828	692	1119	87	864	1007
			load	644	568	906	74	683	812
			domContentLoaded	639	560	901	74	679	807
			domInteractive	28	15	127	24	24	95
			firstPaint	204	80	825	134	205	598
			backgroundConnect	11	5	42	7	12	28
			firstReactRender	28	20	174	16	31	38
			getState	25	13	56	10	32	44
			initialActions	1	0	4	1	1	2
			loadScripts	637	557	891	72	677	798
			setupStore	11	6	31	5	13	20
			numNetworkReqs	11	5	71	17	5	63
	Webpack	Power User Home	uiStartup	1590	1232	2105	246	1796	2082
			load	674	584	1110	94	690	890
			domContentLoaded	666	579	1101	94	684	884
			domInteractive	34	16	242	32	29	107
			firstPaint	297	100	1131	225	329	863
			backgroundConnect	120	7	664	203	117	580
			firstReactRender	58	45	87	9	62	78
			getState	174	141	301	23	185	220
			initialActions	1	0	3	1	1	2
			loadScripts	663	577	1090	93	682	876
			setupStore	16	9	48	9	15	43
			numNetworkReqs	81	64	266	36	73	156
Firefox	Browserify	Standard Home	uiStartup	1330	1078	1879	164	1410	1703
			load	1090	928	1437	105	1152	1302
			domContentLoaded	1090	923	1437	105	1152	1301
			domInteractive	64	30	195	33	86	118
			firstPaint	-	-	-	-	-	-
			backgroundConnect	47	22	257	36	48	111
			firstReactRender	23	18	42	5	23	37
			getState	15	6	204	28	10	38
			initialActions	1	0	3	1	1	2
			loadScripts	1062	910	1414	94	1116	1249
			setupStore	12	5	95	12	10	35
			numNetworkReqs	12	5	67	17	7	62
	Browserify	Power User Home	uiStartup	3029	1949	5121	911	3935	4728
			load	1412	979	3003	535	1396	2504
			domContentLoaded	1411	979	3003	535	1396	2504
			domInteractive	118	31	1053	137	108	317
			firstPaint	-	-	-	-	-	-
			backgroundConnect	284	27	1970	390	341	1143
			firstReactRender	60	36	264	29	64	103
			getState	299	70	1135	266	318	964
			initialActions	2	0	7	1	2	3
			loadScripts	1281	952	2657	391	1323	2296
			setupStore	109	6	906	178	94	539
			numNetworkReqs	76	49	132	21	77	128
	Webpack	Standard Home	uiStartup	1545	1269	2364	186	1625	1946
			load	1259	1087	1568	103	1327	1438
			domContentLoaded	1258	1086	1568	103	1327	1438
			domInteractive	67	26	153	35	85	129
			firstPaint	-	-	-	-	-	-
			backgroundConnect	51	16	271	38	59	136
			firstReactRender	28	20	81	9	30	41
			getState	17	6	155	23	14	52
			initialActions	1	0	3	1	2	2
			loadScripts	1229	1067	1463	95	1296	1404
			setupStore	19	6	209	32	14	74
			numNetworkReqs	12	5	67	17	7	63
	Webpack	Power User Home	uiStartup	3378	2189	5958	1072	4325	5646
			load	1649	1153	3914	624	1744	2843
			domContentLoaded	1648	1152	3914	625	1744	2843
			domInteractive	151	29	1417	246	100	1028
			firstPaint	-	-	-	-	-	-
			backgroundConnect	225	24	1320	331	214	1166
			firstReactRender	72	39	348	50	68	156
			getState	338	78	1316	280	489	904
			initialActions	4	1	66	10	2	30
			loadScripts	1519	1124	2985	490	1551	2713
			setupStore	144	7	1270	260	93	786
			numNetworkReqs	77	51	143	23	72	129

📊 Page Load Benchmark Results

Current Commit: d200905 | Date: 12/4/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±46ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 730ms (±42ms) 🟢 | historical mean value: 723ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±13ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	46ms	1.01s	1.33s	1.11s	1.33s
domContentLoaded	730ms	42ms	699ms	997ms	773ms	997ms
firstPaint	78ms	13ms	60ms	192ms	88ms	192ms
firstContentfulPaint	78ms	13ms	60ms	192ms	88ms	192ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.94 KiB (0.04%)
ui: 0 Bytes (0%)
common: 147 Bytes (0%)

metamaskbot · 2025-12-05T14:49:09Z

Builds ready [2e11045]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1194 ± 121 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1194	972	1651	121	1275	1381
			load	999	812	1242	97	1070	1184
			domContentLoaded	993	809	1234	97	1061	1172
			domInteractive	24	14	84	16	21	73
			firstPaint	615	92	1252	401	1001	1133
			backgroundConnect	198	176	248	12	205	218
			firstReactRender	25	19	72	7	26	38
			getState	31	15	128	14	37	56
			initialActions	1	0	5	1	1	2
			loadScripts	802	633	1038	92	875	981
			setupStore	11	6	32	4	12	19
			numNetworkReqs	27	18	92	20	18	89
	Browserify	Power User Home	uiStartup	2023	1653	2581	197	2139	2400
			load	1015	887	1559	134	1007	1358
			domContentLoaded	1001	876	1552	134	995	1351
			domInteractive	34	17	180	27	33	102
			firstPaint	487	128	1483	366	938	1240
			backgroundConnect	250	200	743	101	230	566
			firstReactRender	54	38	90	9	59	75
			getState	195	148	660	71	202	250
			initialActions	1	0	3	1	1	2
			loadScripts	793	676	1312	130	787	1142
			setupStore	19	9	38	6	23	35
			numNetworkReqs	145	64	389	62	206	257
	Webpack	Standard Home	uiStartup	825	699	1152	83	864	981
			load	635	564	813	67	663	786
			domContentLoaded	630	560	806	66	660	780
			domInteractive	27	15	106	23	21	96
			firstPaint	218	72	813	158	194	632
			backgroundConnect	10	6	46	6	12	25
			firstReactRender	26	19	50	6	31	37
			getState	26	14	55	11	33	48
			initialActions	1	0	1	0	1	1
			loadScripts	627	557	797	65	658	770
			setupStore	10	6	29	4	12	18
			numNetworkReqs	27	18	97	21	18	88
	Webpack	Power User Home	uiStartup	1701	1302	2208	241	1970	2153
			load	697	600	1245	104	698	945
			domContentLoaded	687	593	1236	104	684	938
			domInteractive	37	20	158	29	36	121
			firstPaint	265	97	948	164	263	650
			backgroundConnect	89	7	721	184	24	601
			firstReactRender	62	48	90	10	68	82
			getState	210	146	748	120	192	709
			initialActions	1	0	5	1	1	2
			loadScripts	684	591	1225	102	681	928
			setupStore	23	10	63	12	25	52
			numNetworkReqs	162	65	409	63	214	291
Firefox	Browserify	Standard Home	uiStartup	1260	1057	1580	125	1346	1511
			load	1041	889	1265	86	1109	1214
			domContentLoaded	1041	885	1265	86	1109	1213
			domInteractive	55	31	138	28	80	109
			firstPaint	-	-	-	-	-	-
			backgroundConnect	42	23	152	26	43	96
			firstReactRender	22	17	41	5	23	34
			getState	12	6	183	18	11	23
			initialActions	1	0	3	1	1	2
			loadScripts	1017	874	1234	79	1085	1164
			setupStore	12	5	75	11	10	36
			numNetworkReqs	28	18	87	20	20	80
	Browserify	Power User Home	uiStartup	2598	1947	4820	530	2683	4099
			load	1167	927	2618	236	1151	1531
			domContentLoaded	1166	927	2617	236	1151	1531
			domInteractive	115	32	459	89	110	359
			firstPaint	-	-	-	-	-	-
			backgroundConnect	151	31	1481	201	136	553
			firstReactRender	61	38	145	20	62	112
			getState	311	33	977	243	447	810
			initialActions	2	1	7	1	2	3
			loadScripts	1116	909	2347	170	1117	1434
			setupStore	149	10	982	212	122	703
			numNetworkReqs	83	58	169	25	80	152
	Webpack	Standard Home	uiStartup	1541	1302	2094	139	1633	1795
			load	1262	1091	1483	90	1322	1423
			domContentLoaded	1262	1091	1483	90	1322	1423
			domInteractive	59	26	197	33	82	122
			firstPaint	-	-	-	-	-	-
			backgroundConnect	54	23	184	32	64	124
			firstReactRender	27	21	74	8	28	40
			getState	17	7	212	27	14	46
			initialActions	1	0	3	1	1	2
			loadScripts	1232	1060	1456	82	1288	1375
			setupStore	16	6	120	19	13	78
			numNetworkReqs	28	18	87	20	22	85
	Webpack	Power User Home	uiStartup	2958	2155	5056	742	2907	4839
			load	1493	1186	2972	408	1467	2724
			domContentLoaded	1493	1186	2972	408	1466	2724
			domInteractive	125	33	648	121	110	436
			firstPaint	-	-	-	-	-	-
			backgroundConnect	197	34	1355	278	158	1044
			firstReactRender	73	41	376	47	67	151
			getState	282	57	1059	244	344	838
			initialActions	3	0	59	7	2	3
			loadScripts	1387	1159	2811	246	1432	1811
			setupStore	150	12	778	194	176	630
			numNetworkReqs	83	61	169	25	80	150

📊 Page Load Benchmark Results

Current Commit: 2e11045 | Date: 12/5/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±38ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 723ms (±36ms) 🟢 | historical mean value: 724ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	38ms	1.02s	1.31s	1.07s	1.31s
domContentLoaded	723ms	36ms	705ms	989ms	751ms	989ms
firstPaint	78ms	11ms	64ms	172ms	88ms	172ms
firstContentfulPaint	78ms	11ms	64ms	172ms	88ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 71.11 KiB (1.37%)
ui: -23.44 KiB (-0.3%)
common: -74.71 KiB (-0.83%)

huggingbot added 2 commits December 4, 2025 12:12

feat: add dataType migration for seedless onboarding secrets

79747f1

Merge branch 'main' into feat/data-type

d200905

metamaskbot added the team-onboarding Onboarding team label Dec 4, 2025

github-actions bot added the size-M label Dec 4, 2025

fix: Run seedless onboarding migrations during the restore flow

2e11045

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Implement dataType migration for seedless onboarding secrets #38540

feat: Implement dataType migration for seedless onboarding secrets #38540

huggingbot commented Dec 4, 2025 •

edited by github-actions bot

Loading

Uh oh!

metamaskbot commented Dec 4, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 5, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: Implement dataType migration for seedless onboarding secrets #38540

Are you sure you want to change the base?

feat: Implement dataType migration for seedless onboarding secrets #38540

Conversation

huggingbot commented Dec 4, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Dec 4, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 5, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

huggingbot commented Dec 4, 2025 •

edited by github-actions bot

Loading