feat: Update row key colors in Confirmations #38553

dan437 · 2025-12-04T13:25:57Z

Description

Updates row key colors in Confirmations.

Changelog

CHANGELOG entry: Update row key colors in Confirmations

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5279

Manual testing steps

Trigger the Confirmations page for different scenarios (Send, dapp, Base network, etc.)
Click on "Show advanced details" button
Check that colors are updated according to the screenshots

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Set default label text color in confirmation info rows to textAlternative and update affected snapshots.

UI:
- Confirmations Info Row: Default label color now falls back to TextColor.textAlternative (ui/components/app/confirm/info/row/row.tsx).
Tests/Snapshots:
- Updated snapshots across confirmation views to reflect the new label color on row keys (multiple files under ui/pages/confirmations/components/confirm/** and ui/components/app/confirm/info/row/**).

^{Written by Cursor Bugbot for commit d773d38. This will update automatically on new commits. Configure here.}

github-actions · 2025-12-04T13:26:09Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-12-04T13:26:52Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (21 files, +282 -282)

📁 ui/
- 📁 pages/
  - 📁 confirmations/
    - 📁 components/
      - 📁 confirm/
        
        📁 info/
        
        📁 __snapshots__/
        
        📄 info.test.tsx.snap +27 -27
        
        📁 approve/
        
        📁 __snapshots__/
        
        📄 approve.test.tsx.snap +8 -8
        
        📁 approve-static-simulation/
        
        📁 __snapshots__/
        
        📄 approve-static-simulation.test.tsx.snap +4 -4
        
        📁 native-transfer/
        
        📁 __snapshots__/
        
        📄 native-transfer.test.tsx.snap +1 -1
        
        📁 nft-token-transfer/
        
        📁 __snapshots__/
        
        📄 nft-token-transfer.test.tsx.snap +1 -1
        
        📁 personal-sign/
        
        📁 siwe-sign/
        
        📁 __snapshots__/
        
        📄 siwe-sign.test.tsx.snap +19 -19
        
        📁 set-approval-for-all-info/
        
        📁 __snapshots__/
        
        📄 set-approval-for-all-info.test.tsx.snap +2 -2
        
        📁 revoke-set-approval-for-all-static-simulation/
        
        📁 __snapshots__/
        
        📄 revoke-set-approval-for-all-static-simulation.test.tsx.snap +3 -3
        
        📁 set-approval-for-all-static-simulation/
        
        📁 __snapshots__/
        
        📄 set-approval-for-all-static-simulation.test.tsx.snap +2 -2
        
        📁 shared/
        
        📁 advanced-details/
        
        📁 __snapshots__/
        
        📄 advanced-details.test.tsx.snap +4 -4
        
        📁 gas-fees-row/
        
        📁 __snapshots__/
        
        📄 gas-fees-row.test.tsx.snap +1 -1
        
        📁 transaction-data/
        
        📁 __snapshots__/
        
        📄 transaction-data.test.tsx.snap +55 -55
        
        📁 token-transfer/
        
        📁 __snapshots__/
        
        📄 token-details-section.test.tsx.snap +1 -1
        
        📄 token-transfer.test.tsx.snap +1 -1
        
        📁 typed-sign/
        
        📁 __snapshots__/
        
        📄 typed-sign.test.tsx.snap +47 -47
        
        📁 typed-sign-v4-simulation/
        
        📁 permit-simulation/
        
        📁 __snapshots__/
        📄 permit-simulation.test.tsx.snap +4 -4
        
        📁 typed-sign-v1/
        
        📁 __snapshots__/
        
        📄 typed-sign-v1.test.tsx.snap +3 -3
        
        📁 row/
        
        📁 __snapshots__/
        
        📄 dataTree.test.tsx.snap +28 -28
        
        📁 typed-sign-data/
        
        📁 __snapshots__/
        
        📄 typedSignData.test.tsx.snap +15 -15
        
        📁 typed-sign-data-v1/
        
        📁 __snapshots__/
        
        📄 typedSignDataV1.test.tsx.snap +2 -2
    - 📁 confirm/
      - 📁 __snapshots__/
        
        📄 confirm.test.tsx.snap +54 -54

metamaskbot · 2025-12-04T13:59:26Z

Builds ready [0da8b0c]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1235 ± 104 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1235	1028	1531	104	1310	1427
			load	1037	863	1294	93	1090	1223
			domContentLoaded	1030	860	1277	92	1084	1218
			domInteractive	26	14	160	21	22	78
			firstPaint	515	95	1293	407	997	1195
			backgroundConnect	215	194	261	13	224	242
			firstReactRender	30	19	60	10	34	52
			getState	35	16	110	17	39	82
			initialActions	1	0	4	1	1	3
			loadScripts	822	658	1068	90	878	994
			setupStore	11	6	22	3	12	19
			numNetworkReqs	10	5	68	16	5	59
	Browserify	Power User Home	uiStartup	1954	1570	2628	229	2096	2376
			load	992	891	1419	113	1001	1288
			domContentLoaded	981	882	1411	114	987	1273
			domInteractive	30	16	109	21	28	94
			firstPaint	512	81	1299	376	938	1215
			backgroundConnect	261	196	820	124	232	538
			firstReactRender	51	39	101	9	56	66
			getState	207	139	785	117	200	680
			initialActions	1	0	2	1	1	2
			loadScripts	775	680	1203	111	785	1070
			setupStore	16	10	44	8	15	38
			numNetworkReqs	78	65	161	20	74	139
	Webpack	Standard Home	uiStartup	814	695	1177	74	839	986
			load	632	562	941	65	674	768
			domContentLoaded	628	558	934	64	671	762
			domInteractive	27	15	128	22	23	94
			firstPaint	202	72	792	125	202	588
			backgroundConnect	10	5	53	8	9	26
			firstReactRender	27	20	41	6	32	38
			getState	26	13	56	10	34	42
			initialActions	1	0	3	1	1	1
			loadScripts	625	556	923	63	669	754
			setupStore	10	5	28	4	12	17
			numNetworkReqs	10	5	70	16	5	59
	Webpack	Power User Home	uiStartup	1570	1202	2357	263	1739	2092
			load	683	572	1084	107	728	892
			domContentLoaded	675	564	1071	107	721	878
			domInteractive	38	17	253	40	30	127
			firstPaint	288	88	904	211	299	832
			backgroundConnect	64	7	756	155	15	542
			firstReactRender	57	43	88	10	63	80
			getState	181	144	665	53	184	229
			initialActions	1	0	4	1	1	2
			loadScripts	672	562	1069	106	719	876
			setupStore	17	9	59	11	15	50
			numNetworkReqs	79	65	242	27	74	148
Firefox	Browserify	Standard Home	uiStartup	1314	1096	1751	144	1390	1582
			load	1094	947	1545	114	1143	1321
			domContentLoaded	1094	946	1545	114	1143	1320
			domInteractive	67	31	301	42	88	134
			firstPaint	-	-	-	-	-	-
			backgroundConnect	51	21	330	41	64	116
			firstReactRender	23	18	60	7	23	36
			getState	11	6	69	9	10	30
			initialActions	1	0	3	1	2	2
			loadScripts	1065	932	1459	103	1116	1278
			setupStore	11	6	51	8	10	34
			numNetworkReqs	11	5	66	16	6	63
	Browserify	Power User Home	uiStartup	3089	1920	4751	800	3937	4543
			load	1380	982	2746	453	1448	2414
			domContentLoaded	1380	982	2746	453	1448	2413
			domInteractive	97	36	336	71	101	266
			firstPaint	-	-	-	-	-	-
			backgroundConnect	297	27	2008	384	483	1093
			firstReactRender	64	39	272	33	65	127
			getState	285	72	1341	252	350	867
			initialActions	6	0	63	13	3	49
			loadScripts	1247	967	2575	320	1335	2229
			setupStore	194	8	1090	269	296	926
			numNetworkReqs	77	52	141	24	71	133
	Webpack	Standard Home	uiStartup	1477	1281	2169	162	1504	1805
			load	1215	1065	1496	102	1271	1455
			domContentLoaded	1215	1065	1496	102	1271	1455
			domInteractive	53	27	193	32	72	111
			firstPaint	-	-	-	-	-	-
			backgroundConnect	49	21	319	38	43	121
			firstReactRender	28	20	80	10	29	41
			getState	17	7	197	29	12	64
			initialActions	1	0	3	1	2	2
			loadScripts	1187	1050	1435	89	1245	1366
			setupStore	14	6	124	18	11	36
			numNetworkReqs	12	5	68	17	7	63
	Webpack	Power User Home	uiStartup	3389	2121	6108	942	4235	5149
			load	1665	1152	3114	545	1743	2832
			domContentLoaded	1664	1151	3109	545	1743	2832
			domInteractive	102	32	403	76	100	311
			firstPaint	-	-	-	-	-	-
			backgroundConnect	227	25	1540	337	206	1219
			firstReactRender	68	40	195	28	72	147
			getState	353	88	1832	317	508	949
			initialActions	3	1	62	8	2	7
			loadScripts	1528	1118	2936	424	1596	2624
			setupStore	134	7	1149	194	114	664
			numNetworkReqs	77	54	132	22	73	126

📊 Page Load Benchmark Results

Current Commit: 0da8b0c | Date: 12/4/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±38ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 733ms (±36ms) 🟢 | historical mean value: 725ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	38ms	1.03s	1.33s	1.08s	1.33s
domContentLoaded	733ms	36ms	714ms	1000ms	756ms	1000ms
firstPaint	78ms	10ms	64ms	164ms	88ms	164ms
firstContentfulPaint	78ms	10ms	64ms	164ms	88ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 33 Bytes (0%)
common: 20 Bytes (0%)

metamaskbot · 2025-12-04T14:39:37Z

Builds ready [22910d8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1263 ± 112 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1263	1004	1596	112	1338	1480
			load	1059	864	1391	97	1114	1239
			domContentLoaded	1053	859	1383	97	1107	1234
			domInteractive	25	15	98	18	22	80
			firstPaint	533	85	1415	419	1038	1175
			backgroundConnect	221	198	266	14	230	250
			firstReactRender	32	20	59	11	38	55
			getState	36	16	93	13	43	56
			initialActions	1	0	7	1	1	3
			loadScripts	839	656	1175	91	893	1002
			setupStore	12	7	31	4	14	21
			numNetworkReqs	11	5	71	17	5	63
	Browserify	Power User Home	uiStartup	1999	1573	2656	230	2163	2396
			load	1000	879	1380	122	1025	1326
			domContentLoaded	990	870	1375	122	1005	1317
			domInteractive	31	17	98	20	29	92
			firstPaint	484	97	1359	372	921	1261
			backgroundConnect	255	200	748	110	228	527
			firstReactRender	52	39	92	8	55	67
			getState	197	142	690	77	199	285
			initialActions	1	0	3	1	1	2
			loadScripts	784	671	1169	119	803	1098
			setupStore	17	8	50	9	16	44
			numNetworkReqs	80	64	245	26	75	143
	Webpack	Standard Home	uiStartup	798	694	997	73	819	963
			load	627	560	806	68	644	787
			domContentLoaded	622	556	801	68	639	781
			domInteractive	26	14	109	23	21	96
			firstPaint	228	98	786	173	196	659
			backgroundConnect	10	5	32	5	12	24
			firstReactRender	27	19	121	11	31	37
			getState	26	13	57	10	32	45
			initialActions	1	0	4	1	1	1
			loadScripts	620	553	792	66	637	776
			setupStore	10	6	26	4	12	16
			numNetworkReqs	11	5	73	18	5	68
	Webpack	Power User Home	uiStartup	1598	1227	2233	277	1853	2136
			load	665	576	1118	94	691	888
			domContentLoaded	657	568	1108	94	680	883
			domInteractive	33	18	175	27	30	98
			firstPaint	260	102	1118	181	259	641
			backgroundConnect	100	6	632	188	33	555
			firstReactRender	58	45	79	9	64	75
			getState	180	143	720	59	188	229
			initialActions	1	0	4	1	1	2
			loadScripts	654	566	1096	92	678	875
			setupStore	17	9	48	9	15	41
			numNetworkReqs	81	63	264	36	73	149
Firefox	Browserify	Standard Home	uiStartup	1296	1069	1736	142	1359	1583
			load	1077	920	1374	92	1133	1245
			domContentLoaded	1077	920	1374	92	1132	1244
			domInteractive	59	29	163	31	83	126
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	21	225	31	44	122
			firstReactRender	23	18	40	5	23	36
			getState	14	7	214	25	10	28
			initialActions	1	0	2	0	2	2
			loadScripts	1050	903	1356	84	1102	1173
			setupStore	13	6	104	16	10	31
			numNetworkReqs	12	5	65	17	6	63
	Browserify	Power User Home	uiStartup	3114	2120	6811	948	4034	4774
			load	1422	990	5098	619	1375	2637
			domContentLoaded	1421	989	5098	619	1375	2637
			domInteractive	136	33	1058	190	109	485
			firstPaint	-	-	-	-	-	-
			backgroundConnect	252	23	1263	335	266	1183
			firstReactRender	60	36	152	23	64	114
			getState	303	73	1762	286	364	960
			initialActions	2	0	20	2	2	4
			loadScripts	1311	971	4977	526	1287	2361
			setupStore	155	5	1045	229	137	719
			numNetworkReqs	76	49	143	21	73	128
	Webpack	Standard Home	uiStartup	1555	1260	1894	152	1647	1856
			load	1273	1088	1561	108	1364	1468
			domContentLoaded	1273	1088	1561	108	1364	1468
			domInteractive	64	28	133	33	88	124
			firstPaint	-	-	-	-	-	-
			backgroundConnect	54	22	154	30	69	114
			firstReactRender	27	20	43	5	29	37
			getState	14	7	174	17	13	25
			initialActions	1	0	3	1	2	2
			loadScripts	1245	1072	1543	104	1334	1417
			setupStore	16	5	149	21	14	45
			numNetworkReqs	12	5	66	16	7	61
	Webpack	Power User Home	uiStartup	3332	2031	5766	953	4283	4912
			load	1654	1135	2931	559	2120	2856
			domContentLoaded	1653	1135	2931	559	2120	2854
			domInteractive	189	28	1185	298	151	1113
			firstPaint	-	-	-	-	-	-
			backgroundConnect	222	26	2109	361	202	1068
			firstReactRender	76	38	354	54	71	209
			getState	284	85	1518	270	278	848
			initialActions	4	0	110	12	2	7
			loadScripts	1551	1120	2894	479	1618	2556
			setupStore	88	5	806	144	94	481
			numNetworkReqs	77	53	137	22	73	126

📊 Page Load Benchmark Results

Current Commit: 22910d8 | Date: 12/4/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.09s (±50ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 762ms (±45ms) 🟢 | historical mean value: 725ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 83ms (±13ms) 🟢 | historical mean value: 79ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.09s	50ms	1.05s	1.43s	1.17s	1.43s
domContentLoaded	762ms	45ms	729ms	1.10s	820ms	1.10s
firstPaint	83ms	13ms	68ms	200ms	88ms	200ms
firstContentfulPaint	83ms	13ms	68ms	200ms	88ms	200ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 33 Bytes (0%)
common: 20 Bytes (0%)

Signed-off-by: dan437 <[email protected]>

metamaskbot · 2025-12-04T17:23:17Z

Builds ready [d773d38]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1247 ± 100 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1247	1013	1667	100	1319	1400
			load	1041	868	1397	82	1095	1180
			domContentLoaded	1035	863	1389	80	1088	1165
			domInteractive	26	15	135	20	22	84
			firstPaint	535	97	1407	414	1033	1185
			backgroundConnect	220	197	266	13	227	242
			firstReactRender	31	20	62	10	34	55
			getState	37	16	111	17	45	66
			initialActions	1	0	5	1	1	3
			loadScripts	822	658	1159	78	867	957
			setupStore	11	6	29	4	13	18
			numNetworkReqs	10	5	73	17	5	58
	Browserify	Power User Home	uiStartup	2028	1763	2922	192	2084	2410
			load	1033	910	1684	130	1053	1350
			domContentLoaded	1019	903	1625	129	1034	1340
			domInteractive	33	17	109	20	34	95
			firstPaint	506	109	1664	376	947	1182
			backgroundConnect	258	201	761	104	231	554
			firstReactRender	59	41	111	16	62	97
			getState	191	133	663	72	196	232
			initialActions	1	0	5	1	1	2
			loadScripts	810	695	1372	125	820	1133
			setupStore	19	10	40	7	23	36
			numNetworkReqs	92	62	207	23	97	135
	Webpack	Standard Home	uiStartup	825	695	1106	83	862	990
			load	643	566	847	75	676	803
			domContentLoaded	638	561	841	75	672	797
			domInteractive	27	15	100	22	22	94
			firstPaint	206	83	787	131	209	604
			backgroundConnect	10	6	44	6	13	24
			firstReactRender	27	20	44	6	32	39
			getState	26	14	63	10	34	44
			initialActions	1	0	4	1	1	2
			loadScripts	635	558	832	73	669	794
			setupStore	10	6	27	3	12	18
			numNetworkReqs	11	5	69	16	5	59
	Webpack	Power User Home	uiStartup	1678	1330	2313	235	1887	2163
			load	702	612	1177	93	711	926
			domContentLoaded	691	602	1169	94	694	913
			domInteractive	37	19	138	26	35	113
			firstPaint	301	93	947	199	330	702
			backgroundConnect	66	7	634	146	20	544
			firstReactRender	61	49	95	9	65	80
			getState	183	133	752	61	189	220
			initialActions	1	0	5	1	1	2
			loadScripts	688	600	1158	92	692	904
			setupStore	21	10	56	11	22	52
			numNetworkReqs	148	68	348	61	202	284
Firefox	Browserify	Standard Home	uiStartup	1298	1064	1663	139	1408	1534
			load	1073	917	1336	93	1128	1260
			domContentLoaded	1073	912	1336	93	1127	1260
			domInteractive	61	29	203	38	83	130
			firstPaint	-	-	-	-	-	-
			backgroundConnect	45	20	151	30	49	125
			firstReactRender	22	18	39	5	22	36
			getState	14	6	176	24	10	31
			initialActions	1	0	3	1	2	2
			loadScripts	1044	900	1309	84	1094	1218
			setupStore	12	5	83	13	10	34
			numNetworkReqs	11	5	64	16	6	60
	Browserify	Power User Home	uiStartup	2598	2020	4537	540	2630	4292
			load	1212	966	2646	313	1207	2067
			domContentLoaded	1212	966	2646	313	1207	2067
			domInteractive	111	30	548	97	106	372
			firstPaint	-	-	-	-	-	-
			backgroundConnect	178	25	1189	238	150	763
			firstReactRender	57	37	187	19	57	93
			getState	274	35	1088	224	273	827
			initialActions	2	1	7	1	2	3
			loadScripts	1134	949	2278	196	1122	1515
			setupStore	163	9	783	195	202	661
			numNetworkReqs	82	59	175	26	79	154
	Webpack	Standard Home	uiStartup	1459	1217	1990	156	1554	1766
			load	1213	1041	1640	120	1286	1424
			domContentLoaded	1212	1041	1640	120	1285	1423
			domInteractive	51	27	140	31	80	122
			firstPaint	-	-	-	-	-	-
			backgroundConnect	47	22	327	38	44	119
			firstReactRender	27	20	77	9	28	34
			getState	14	7	138	20	12	47
			initialActions	1	0	3	1	2	2
			loadScripts	1181	1027	1610	107	1258	1395
			setupStore	14	5	137	17	13	37
			numNetworkReqs	12	5	66	16	7	61
	Webpack	Power User Home	uiStartup	3002	2137	7343	875	2899	4684
			load	1580	1195	5658	650	1626	2838
			domContentLoaded	1579	1195	5658	650	1626	2837
			domInteractive	168	29	3774	396	107	395
			firstPaint	-	-	-	-	-	-
			backgroundConnect	169	27	1535	246	154	595
			firstReactRender	60	40	146	22	61	103
			getState	299	71	1216	255	403	872
			initialActions	2	0	8	1	2	3
			loadScripts	1495	1169	5635	590	1573	2724
			setupStore	127	4	724	176	138	591
			numNetworkReqs	81	60	172	24	81	139

📊 Page Load Benchmark Results

Current Commit: d773d38 | Date: 12/4/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±43ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 720ms (±62ms) 🟢 | historical mean value: 733ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 88ms (±127ms) 🟢 | historical mean value: 79ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	43ms	1.00s	1.36s	1.05s	1.36s
domContentLoaded	720ms	62ms	693ms	1.29s	740ms	1.29s
firstPaint	88ms	127ms	60ms	1.35s	88ms	1.35s
firstContentfulPaint	88ms	127ms	60ms	1.35s	88ms	1.35s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 33 Bytes (0%)
common: 20 Bytes (0%)

dan437 requested a review from a team as a code owner December 4, 2025 13:25

metamaskbot added the team-confirmations Push issues to confirmations team label Dec 4, 2025

github-actions bot added the size-XS label Dec 4, 2025

vinistevam approved these changes Dec 4, 2025

View reviewed changes

dan437 enabled auto-merge December 4, 2025 14:32

jpuri approved these changes Dec 4, 2025

View reviewed changes

dan437 disabled auto-merge December 4, 2025 15:48

dan437 enabled auto-merge December 4, 2025 15:48

dan437 added 2 commits December 4, 2025 17:47

feat: Update row key colors in Confirmations

36a18b8

Signed-off-by: dan437 <[email protected]>

Update a snapshot

d773d38

Signed-off-by: dan437 <[email protected]>

dan437 force-pushed the confirmations-ui branch from 22910d8 to d773d38 Compare December 4, 2025 16:47

dan437 added this pull request to the merge queue Dec 4, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2025

dan437 added this pull request to the merge queue Dec 5, 2025

Merged via the queue into main with commit 0765009 Dec 5, 2025
176 checks passed

dan437 deleted the confirmations-ui branch December 5, 2025 09:44

github-actions bot locked and limited conversation to collaborators Dec 5, 2025

metamaskbot added the release-13.14.0 Issue or pull request that will be included in release 13.14.0 label Dec 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Update row key colors in Confirmations #38553

feat: Update row key colors in Confirmations #38553

dan437 commented Dec 4, 2025 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Dec 4, 2025

Uh oh!

metamaskbot commented Dec 4, 2025

Uh oh!

metamaskbot commented Dec 4, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 4, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 4, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat: Update row key colors in Confirmations #38553

feat: Update row key colors in Confirmations #38553

Conversation

dan437 commented Dec 4, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Dec 4, 2025

Uh oh!

metamaskbot commented Dec 4, 2025

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Dec 4, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 4, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 4, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dan437 commented Dec 4, 2025 •

edited by cursor bot

Loading