Skip to content

Conversation

@maxime-oe
Copy link
Contributor

@maxime-oe maxime-oe commented Dec 4, 2025

Description

Bump assets controllers to v93.1.0

Changelog

CHANGELOG entry: bump assets controllers to v93.1.0

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Bumps @metamask/assets-controllers to 93.1.0 and updates its patch to adjust Codefi V2 spot-prices support and URL formatting.

  • Dependencies:
    • Update @metamask/assets-controllers from 93.0.0 to 93.1.0 in package.json; refresh related yarn.lock entries.
  • Patched module (.yarn/patches/@metamask-assets-controllers-npm-93.1.0-*.patch):
    • Token Prices Service (Codefi V2):
      • Set numerous SPOT_PRICES_SUPPORT_INFO mappings to null.
      • Build spot-prices URL with decimal chain ID: parseInt(chainId, 16) (in both codefi-v2.cjs and codefi-v2.mjs).

Written by Cursor Bugbot for commit e2df57e. This will update automatically on new commits. Configure here.

@maxime-oe maxime-oe requested a review from salimtb December 4, 2025 13:52
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented Dec 4, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@maxime-oe maxime-oe force-pushed the bump/bump-assets-controllers-v93-1-0 branch from 4eef561 to 256e822 Compare December 4, 2025 14:12
@metamaskbot
Copy link
Collaborator

Builds ready [256e822]
UI Startup Metrics (1225 ± 99 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1225103314769912941394
load103185612548710721212
domContentLoaded102585012478710661204
domInteractive2515112202186
firstPaint5188512533909791159
backgroundConnect21419426912220237
firstReactRender29197293147
getState3515116154161
initialActions108112
loadScripts817648104083856984
setupStore1253551322
numNetworkReqs1057016559
BrowserifyPower User HomeuiStartup20341624267622821902462
load1038892174413910621327
domContentLoaded1026885173413810491317
domInteractive3218139233191
firstPaint5439217484079541311
backgroundConnect297206850164246744
firstReactRender5342122105666
getState20114676397196280
initialActions109112
loadScripts81168615121358281108
setupStore1675071631
numNetworkReqs79651662274145
WebpackStandard HomeuiStartup8386971104848661019
load65356789776687834
domContentLoaded64856189375680828
domInteractive28151242423101
firstPaint24582845183227673
backgroundConnect1055261126
firstReactRender2820129123238
getState261366113347
initialActions102111
loadScripts64555988374677819
setupStore1164051220
numNetworkReqs1157316560
WebpackPower User HomeuiStartup16291287233923117422124
load6986001256104711924
domContentLoaded6905931245104699918
domInteractive36191543031128
firstPaint293105936211330720
backgroundConnect114864719993577
firstReactRender6247121106779
getState17915126423185242
initialActions104112
loadScripts6875911236102697910
setupStore181060111646
numNetworkReqs80642593074144
FirefoxBrowserifyStandard HomeuiStartup12951078196117214021645
load1069933139610611341273
domContentLoaded1068933139610711341273
domInteractive59302113484132
firstPaint------
backgroundConnect47173424252122
firstReactRender22185252334
getState1167981019
initialActions105112
loadScripts104491713689811041232
setupStore156236291052
numNetworkReqs1256517763
BrowserifyPower User HomeuiStartup31322006540192040614694
load14121034286047813822558
domContentLoaded14121033286047813812558
domInteractive1093282098108288
firstPaint------
backgroundConnect2702814273423571166
firstReactRender67372693769160
getState290691170240378832
initialActions218123
loadScripts1294981265438013192340
setupStore124792519594675
numNetworkReqs77591482375135
WebpackStandard HomeuiStartup15381305231316216291846
load1256109615979913331439
domContentLoaded1255109515979913331438
domInteractive63301993686130
firstPaint------
backgroundConnect48211482947113
firstReactRender27207772937
getState187179281352
initialActions103122
loadScripts1231108015769413041390
setupStore185184251472
numNetworkReqs1256917764
WebpackPower User HomeuiStartup34442424530688342615111
load16951190327456417393066
domContentLoaded16941190327456417393065
domInteractive1023139174106296
firstPaint------
backgroundConnect2372814042913581119
firstReactRender87413516091282
getState319831034260461903
initialActions6010217353
loadScripts15691172308441416632521
setupStore15681332266109806
numNetworkReqs78531542473130
📊 Page Load Benchmark Results

Current Commit: 256e822 | Date: 12/4/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±71ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 738ms (±69ms) 🟢 | historical mean value: 725ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 71ms 1.01s 1.34s 1.28s 1.34s
domContentLoaded 738ms 69ms 700ms 1.00s 956ms 1.00s
firstPaint 78ms 10ms 60ms 156ms 88ms 156ms
firstContentfulPaint 78ms 10ms 60ms 156ms 88ms 156ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 3.21 KiB (0.04%)
  • common: 392 Bytes (0%)

@maxime-oe maxime-oe force-pushed the bump/bump-assets-controllers-v93-1-0 branch from 256e822 to 045e1f5 Compare December 4, 2025 15:54
@metamaskbot
Copy link
Collaborator

Builds ready [045e1f5]
UI Startup Metrics (1225 ± 105 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12251007152810512941403
load102186212959110701186
domContentLoaded101585312889010641175
domInteractive2616102212194
firstPaint4677912963809501150
backgroundConnect21119324210215235
firstReactRender29195683345
getState39161492343102
initialActions104112
loadScripts810656108587860973
setupStore1163651222
numNetworkReqs1157117565
BrowserifyPower User HomeuiStartup20751665290726622902648
load1045909147013910921369
domContentLoaded1031899144313810771360
domInteractive3217119213194
firstPaint5429614513919661298
backgroundConnect266205781118242567
firstReactRender54417475868
getState19814871077202263
initialActions103112
loadScripts81768412281328521146
setupStore17116181638
numNetworkReqs81642412877152
WebpackStandard HomeuiStartup765656102274798932
load59653078460611757
domContentLoaded59252678060608753
domInteractive2415107201978
firstPaint26985773188300652
backgroundConnect1053761026
firstReactRender26195763136
getState241172103141
initialActions102112
loadScripts58952477158606745
setupStore1052641118
numNetworkReqs1156916562
WebpackPower User HomeuiStartup15931244226827018452113
load664578119397676865
domContentLoaded657572118797670859
domInteractive3116147242894
firstPaint26890890189285683
backgroundConnect1208663207115574
firstReactRender56458186273
getState17214024420181215
initialActions103112
loadScripts654570117595667850
setupStore18959111640
numNetworkReqs81642593274154
FirefoxBrowserifyStandard HomeuiStartup13681101191718314771735
load1112945162311511571331
domContentLoaded1111945162211511571331
domInteractive71312404291159
firstPaint------
backgroundConnect53222063865143
firstReactRender23194652435
getState1164571033
initialActions103122
loadScripts1082928160310811241288
setupStore137138181041
numNetworkReqs1256716660
BrowserifyPower User HomeuiStartup31542047618687937764834
load14901043349052015802735
domContentLoaded14901042348952015802735
domInteractive1243853896139361
firstPaint------
backgroundConnect224331248273260996
firstReactRender65422052865148
getState283741033234342793
initialActions51851238
loadScripts14201017332846215022556
setupStore13181005187124649
numNetworkReqs78551622771141
WebpackStandard HomeuiStartup14511269193613015221697
load1213105514679712871395
domContentLoaded1213105514679712871395
domInteractive59241823281113
firstPaint------
backgroundConnect45181652644113
firstReactRender25196452733
getState177226281445
initialActions103012
loadScripts1186102614429112611361
setupStore135160171232
numNetworkReqs1156716762
WebpackPower User HomeuiStartup333022689465108641724983
load17041194684774121542813
domContentLoaded17041194684674121542812
domInteractive165304871505101305
firstPaint------
backgroundConnect2422711823162681098
firstReactRender65402853865131
getState339542007332509968
initialActions517812237
loadScripts15831175682269115552659
setupStore12941089211103601
numNetworkReqs77531432373127
📊 Page Load Benchmark Results

Current Commit: 045e1f5 | Date: 12/4/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.10s (±122ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 786ms (±118ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.10s 122ms 1.01s 1.36s 1.32s 1.36s
domContentLoaded 786ms 118ms 695ms 1.04s 999ms 1.04s
firstPaint 78ms 12ms 60ms 172ms 92ms 172ms
firstContentfulPaint 78ms 12ms 60ms 172ms 92ms 172ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 126 Bytes (0%)

@maxime-oe maxime-oe marked this pull request as ready for review December 4, 2025 16:32
@maxime-oe maxime-oe force-pushed the bump/bump-assets-controllers-v93-1-0 branch from 045e1f5 to e2df57e Compare December 5, 2025 08:01
@metamaskbot
Copy link
Collaborator

Builds ready [e2df57e]
UI Startup Metrics (1215 ± 104 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12151022153410412841377
load101885713489210721174
domContentLoaded101385413289110661169
domInteractive2515109202181
firstPaint4218313673738751109
backgroundConnect21119826410215232
firstReactRender29205793348
getState3416115194078
initialActions104112
loadScripts807653108287857955
setupStore1165261221
numNetworkReqs271892201885
BrowserifyPower User HomeuiStartup20401776265816821042465
load1043903163613010431378
domContentLoaded1029896162413010161366
domInteractive35171272534110
firstPaint5078114264069801346
backgroundConnect260208779100241546
firstReactRender5840111136390
getState19013927327207241
initialActions105112
loadScripts81368813851278101141
setupStore20114672338
numNetworkReqs1146626547130209
WebpackStandard HomeuiStartup8146941065828551006
load62956387071662785
domContentLoaded62555986671657781
domInteractive261598212292
firstPaint20985804156192618
backgroundConnect953151025
firstReactRender2919229233137
getState261361113445
initialActions103112
loadScripts62255686470655772
setupStore1072741119
numNetworkReqs27999211889
WebpackPower User HomeuiStartup16851342249724219182085
load691605113296697949
domContentLoaded680597112796687945
domInteractive38191483233136
firstPaint297901133215299723
backgroundConnect68864615721597
firstReactRender634895106986
getState207135737118196695
initialActions105112
loadScripts677595111894685936
setupStore20771112246
numNetworkReqs1646638162217270
FirefoxBrowserifyStandard HomeuiStartup12811047165813713551562
load106090012999311291255
domContentLoaded105989612989311291253
domInteractive58291673383135
firstPaint------
backgroundConnect42191592746106
firstReactRender23175972442
getState1165571028
initialActions102112
loadScripts103588612518611011214
setupStore125113141028
numNetworkReqs281885193080
BrowserifyPower User HomeuiStartup26552031430533327993417
load12081052249517512101469
domContentLoaded12071052249517512101469
domInteractive1193342575120331
firstPaint------
backgroundConnect158281113185141513
firstReactRender62401852362119
getState29664934213377755
initialActions208237
loadScripts11701019230915511771443
setupStore19710936241302775
numNetworkReqs85602633680163
WebpackStandard HomeuiStartup15171291205015115991818
load1243107614929513151398
domContentLoaded1242107514919513151398
domInteractive64281903584129
firstPaint------
backgroundConnect47222163543119
firstReactRender26214042736
getState157113171443
initialActions102122
loadScripts1214106214528812811371
setupStore175247311487
numNetworkReqs281886192783
WebpackPower User HomeuiStartup31222428595873231224685
load15261239301340915202771
domContentLoaded15251239301340915202771
domInteractive12435478106116411
firstPaint------
backgroundConnect216301350266193953
firstReactRender65412282268102
getState305781075241424832
initialActions301031027
loadScripts14641220281034614542600
setupStore1487813195132620
numNetworkReqs86592663878165
📊 Page Load Benchmark Results

Current Commit: e2df57e | Date: 12/5/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.07s (±127ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 752ms (±149ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 89ms (±121ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.07s 127ms 1.02s 2.12s 1.33s 2.12s
domContentLoaded 752ms 149ms 704ms 2.07s 1000ms 2.07s
firstPaint 89ms 121ms 60ms 1.29s 84ms 1.29s
firstContentfulPaint 89ms 121ms 60ms 1.29s 84ms 1.29s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 126 Bytes (0%)

Copy link
Contributor

@salimtb salimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the 93.1 release doesnt invoke anything that impact to the patch file

  • TokenBalancesController
  • token-prices-service/codefi-v2
  • TokenBalancesController

so it should be fine

@maxime-oe maxime-oe added this pull request to the merge queue Dec 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2025
@stanleyyconsensys stanleyyconsensys added this pull request to the merge queue Dec 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants