-
Notifications
You must be signed in to change notification settings - Fork 5.4k
chore: bump assets-controllers to 93.1.0 #38554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
4eef561 to
256e822
Compare
Builds ready [256e822]
UI Startup Metrics (1225 ± 99 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
256e822 to
045e1f5
Compare
Builds ready [045e1f5]
UI Startup Metrics (1225 ± 105 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
045e1f5 to
e2df57e
Compare
Builds ready [e2df57e]
UI Startup Metrics (1215 ± 104 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
salimtb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stanleyyconsensys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the 93.1 release doesnt invoke anything that impact to the patch file
- TokenBalancesController
- token-prices-service/codefi-v2
- TokenBalancesController
so it should be fine
Description
Bump assets controllers to v93.1.0
Changelog
CHANGELOG entry: bump assets controllers to v93.1.0
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Bumps @metamask/assets-controllers to 93.1.0 and updates its patch to adjust Codefi V2 spot-prices support and URL formatting.
@metamask/assets-controllersfrom93.0.0to93.1.0inpackage.json; refresh relatedyarn.lockentries..yarn/patches/@metamask-assets-controllers-npm-93.1.0-*.patch):SPOT_PRICES_SUPPORT_INFOmappings tonull.parseInt(chainId, 16)(in bothcodefi-v2.cjsandcodefi-v2.mjs).Written by Cursor Bugbot for commit e2df57e. This will update automatically on new commits. Configure here.