Skip to content

Conversation

@NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Dec 4, 2025

This PR ensures that network filter modal should not auto scroll

Changelog

CHANGELOG entry:removed auto scroll from network filter modal

Related issues

Fixes:

Manual testing steps

  1. Open network filter modal
  2. It should not auto scroll

Screenshots/Recordings

Before

Screen.Recording.2025-12-04.at.2.30.22.PM.mov

After

Screen.Recording.2025-12-04.at.2.29.05.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner December 4, 2025 14:30
@metamaskbot metamaskbot added team-core-extension-ux Core Extension UX team INVALID-PR-TEMPLATE PR's body doesn't match template labels Dec 4, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (1 files, +2 -0)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 components/
          • 📁 send/
            • 📁 network-filter/
              • 📄 network-filter.tsx +2 -0

@metamaskbot
Copy link
Collaborator

Builds ready [5d9dbef]
UI Startup Metrics (1229 ± 102 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12291017152310213051424
load102686612598610711184
domContentLoaded101986312548510641176
domInteractive2514104182280
firstPaint573150127541210341189
backgroundConnect21419427013219237
firstReactRender29195683350
getState42151542646107
initialActions106112
loadScripts812660102483861964
setupStore1252851323
numNetworkReqs1056816558
BrowserifyPower User HomeuiStartup20261632274923622282426
load1023878171014510751363
domContentLoaded1011870170114310661341
domInteractive3117116213092
firstPaint59011517274249551329
backgroundConnect274199902148233691
firstReactRender5340119115665
getState18514532529201236
initialActions105112
loadScripts80367014631378451129
setupStore1765991641
numNetworkReqs80612672975152
WebpackStandard HomeuiStartup8417231114798711022
load64957792769668802
domContentLoaded64357391769663796
domInteractive2916131252396
firstPaint22891925171202630
backgroundConnect1164871125
firstReactRender2920125113239
getState271462113547
initialActions104111
loadScripts64157090967661788
setupStore1163251319
numNetworkReqs1056516558
WebpackPower User HomeuiStartup16211242245427218532102
load674586119394683894
domContentLoaded666578118594675884
domInteractive34171272631110
firstPaint28997912211261814
backgroundConnect123668121294594
firstReactRender59468186674
getState18314274761189232
initialActions104112
loadScripts663576117692673877
setupStore181059111645
numNetworkReqs79642603074145
FirefoxBrowserifyStandard HomeuiStartup12781079181714713541598
load106792913849611191252
domContentLoaded106692913849611191246
domInteractive57301582883104
firstPaint------
backgroundConnect4220257304297
firstReactRender24186692348
getState1067171018
initialActions102012
loadScripts103991213068710961201
setupStore156198291037
numNetworkReqs1256516663
BrowserifyPower User HomeuiStartup30251860514487839204552
load14171004281851414202532
domContentLoaded14171004281851414202532
domInteractive993240972106318
firstPaint------
backgroundConnect2902819233913171157
firstReactRender64361973064131
getState298781932300283972
initialActions217123
loadScripts1250984257935112972243
setupStore1366103020298647
numNetworkReqs77551422373135
WebpackStandard HomeuiStartup16171363228815916881924
load1309115615708313541470
domContentLoaded1309115615698313531469
domInteractive71252233689132
firstPaint------
backgroundConnect57222504057162
firstReactRender29224453239
getState177137191653
initialActions103122
loadScripts1276112614857513291397
setupStore2472604016101
numNetworkReqs1256716761
WebpackPower User HomeuiStartup31722111562486240484657
load16041184299349818902663
domContentLoaded16041184299349818902663
domInteractive13633982188111740
firstPaint------
backgroundConnect186261205236190929
firstReactRender65422943266109
getState309841258272409864
initialActions4166838
loadScripts15161159284143215552505
setupStore15571040225150700
numNetworkReqs77541442272132
📊 Page Load Benchmark Results

Current Commit: 5d9dbef | Date: 12/4/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±52ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 728ms (±45ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 84ms (±13ms) 🟢 | historical mean value: 80ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 52ms 984ms 1.32s 1.14s 1.32s
domContentLoaded 728ms 45ms 678ms 993ms 793ms 993ms
firstPaint 84ms 13ms 68ms 184ms 100ms 184ms
firstContentfulPaint 84ms 13ms 68ms 184ms 100ms 184ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 18 Bytes (0%)
  • common: 20 Bytes (0%)

@NidhiKJha NidhiKJha enabled auto-merge December 4, 2025 15:59
@NidhiKJha NidhiKJha added this pull request to the merge queue Dec 5, 2025
Merged via the queue into main with commit d1d78ac Dec 5, 2025
191 of 193 checks passed
@NidhiKJha NidhiKJha deleted the fix-network-list-focus branch December 5, 2025 09:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2025
@metamaskbot metamaskbot added the release-13.14.0 Issue or pull request that will be included in release 13.14.0 label Dec 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-13.14.0 Issue or pull request that will be included in release 13.14.0 size-XS team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants