fix: updated navigation for asset-detail page #38559
Open
+66
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metamaskbot
added
team-core-extension-ux
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const result = getAssetDetailsAccountUrl(address, networkWithoutExplorer); | ||
|
|
||
| expect(result).toBe(expectedUrl); | ||
| }); |
There was a problem hiding this comment.
Bug: Test expectation mismatch for missing block explorer fallback
The test at line 107 expects getAssetDetailsAccountUrl to return a URL ending with #asset-multichain when no blockExplorerUrl is configured, but the implementation simply calls getAccountLink from @metamask/etherscan-link which won't append this fragment. Either the test expectation is incorrect, or the implementation needs to detect when no block explorer is configured and add the #asset-multichain suffix to match the expected fallback behavior documented in the test name "falls back to Etherscan multichain".
Additional Locations (1)
Collaborator
Builds ready [f0cabe2]
UI Startup Metrics (1219 ± 92 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the link of "View Asset" button in asset-details page
Changelog
CHANGELOG entry:null
Related issues
Fixes: #34698
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Uses a new helper to generate asset-details explorer links (EVM uses configured explorer with fallback; non-EVM uses format URLs) and updates token asset to use it, with tests added.
getAssetDetailsAccountUrl(address, network)using@metamask/etherscan-link#getAccountLinkfor EVM (uses configuredrpcPrefs.blockExplorerUrl, falls back to Etherscan multichain) andformatBlockExplorerAddressUrlfor non-EVM.token-asset.tsxto usegetAssetDetailsAccountUrlfor non-EVM explorer links; adjust import.blockExplorer.test.tsto covergetAssetDetailsAccountUrlfor EVM with configured explorer, EVM without explorer (fallback), and non-EVM.Written by Cursor Bugbot for commit f0cabe2. This will update automatically on new commits. Configure here.