refactor: cp-13.13.0 gate `ProfileMetricsController` with `pna25Acknowledged` #38562

mikesposito · 2025-12-04T16:34:03Z

Description

The PR adds an additional check to the assertUserOptedIn function passed to the ProfileMetricsController to ensure that profile metrics are only collected after the user has acknowledged the PNA25 notice.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Gates profile metrics collection behind pna25Acknowledged and updates E2E tests to cover acknowledgment and other gating conditions.

Controller init:
- Update assertUserOptedIn in app/scripts/controller-init/profile-metrics-controller-init.ts to also require AppStateController.state.pna25Acknowledged === true alongside the feature flag and MetaMetrics opt-in.
E2E tests (test/e2e/tests/profile-metrics/profile-metrics.spec.ts):
- Positive path: include .withAppStateController({ pna25Acknowledged: true }) when MetaMetrics is enabled and the feature flag is on; verify existing and new accounts trigger API calls.
- Negative paths: parameterize cases to assert no API calls when MetaMetrics is disabled, the feature flag is off, or the user has not acknowledged the privacy change.

^{Written by Cursor Bugbot for commit 1424dce. This will update automatically on new commits. Configure here.}

metamaskbot · 2025-12-04T17:10:53Z

Builds ready [b5c6270]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1242 ± 103 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1242	1035	1552	103	1312	1415
			load	1037	864	1322	88	1097	1187
			domContentLoaded	1031	859	1313	88	1086	1179
			domInteractive	27	16	113	21	22	88
			firstPaint	501	81	1254	393	1002	1134
			backgroundConnect	218	196	259	13	226	247
			firstReactRender	32	19	135	15	36	57
			getState	40	16	120	22	46	105
			initialActions	1	0	10	1	1	2
			loadScripts	819	653	1099	85	875	977
			setupStore	11	6	24	4	13	19
			numNetworkReqs	11	5	75	18	5	65
	Browserify	Power User Home	uiStartup	2016	1643	2572	193	2113	2385
			load	1026	900	1399	122	1031	1355
			domContentLoaded	1013	891	1389	123	1023	1333
			domInteractive	34	17	131	22	35	89
			firstPaint	515	121	1403	389	946	1320
			backgroundConnect	242	199	720	77	237	336
			firstReactRender	54	38	95	10	56	74
			getState	194	133	719	60	205	250
			initialActions	1	0	6	1	1	2
			loadScripts	801	694	1141	115	808	1108
			setupStore	19	10	47	7	22	36
			numNetworkReqs	143	66	279	57	201	248
	Webpack	Standard Home	uiStartup	810	693	1133	72	849	952
			load	625	566	797	60	648	778
			domContentLoaded	621	562	792	59	643	772
			domInteractive	27	15	120	22	22	89
			firstPaint	206	86	779	146	189	652
			backgroundConnect	10	5	56	6	12	21
			firstReactRender	28	20	45	6	32	38
			getState	27	14	71	10	34	42
			initialActions	1	0	3	1	1	2
			loadScripts	618	560	784	58	641	763
			setupStore	11	6	34	4	13	19
			numNetworkReqs	10	5	67	16	5	61
	Webpack	Power User Home	uiStartup	1622	1231	2199	216	1742	2071
			load	692	584	1291	105	704	931
			domContentLoaded	681	577	1260	105	696	921
			domInteractive	38	18	284	37	33	105
			firstPaint	265	94	1290	195	251	669
			backgroundConnect	68	8	643	154	19	587
			firstReactRender	60	45	80	8	67	75
			getState	185	136	770	62	190	219
			initialActions	1	0	3	1	1	2
			loadScripts	679	575	1251	103	693	912
			setupStore	21	10	59	11	22	47
			numNetworkReqs	163	69	407	69	215	295
Firefox	Browserify	Standard Home	uiStartup	1347	1089	1754	157	1464	1637
			load	1111	943	1450	111	1167	1340
			domContentLoaded	1110	943	1450	111	1167	1340
			domInteractive	70	31	312	48	90	140
			firstPaint	-	-	-	-	-	-
			backgroundConnect	49	22	166	32	64	119
			firstReactRender	23	18	53	6	24	36
			getState	14	6	176	21	11	32
			initialActions	1	0	3	1	2	2
			loadScripts	1082	928	1411	102	1132	1290
			setupStore	13	6	119	15	11	34
			numNetworkReqs	11	5	62	16	6	59
	Browserify	Power User Home	uiStartup	2649	1896	4853	565	2708	4125
			load	1251	995	2896	358	1227	2361
			domContentLoaded	1250	995	2896	358	1227	2361
			domInteractive	118	34	502	89	117	343
			firstPaint	-	-	-	-	-	-
			backgroundConnect	151	30	1142	197	138	623
			firstReactRender	59	35	138	18	63	97
			getState	280	57	884	206	378	767
			initialActions	2	0	36	4	2	6
			loadScripts	1213	975	2857	337	1184	2219
			setupStore	124	7	730	157	137	628
			numNetworkReqs	83	62	219	29	78	157
	Webpack	Standard Home	uiStartup	1496	1305	1947	129	1548	1745
			load	1239	1098	1444	86	1297	1405
			domContentLoaded	1239	1098	1444	86	1297	1405
			domInteractive	65	31	141	32	87	126
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	21	172	24	53	97
			firstReactRender	28	19	77	9	30	51
			getState	14	5	164	19	13	36
			initialActions	1	1	3	1	2	2
			loadScripts	1212	1081	1411	81	1270	1359
			setupStore	13	6	91	14	10	37
			numNetworkReqs	12	5	68	17	7	64
	Webpack	Power User Home	uiStartup	2986	2240	4988	743	2883	4865
			load	1484	1182	3116	448	1475	2896
			domContentLoaded	1483	1182	3116	448	1475	2895
			domInteractive	121	30	1052	128	108	377
			firstPaint	-	-	-	-	-	-
			backgroundConnect	212	30	1296	298	170	1132
			firstReactRender	65	41	150	22	64	132
			getState	296	78	881	224	437	806
			initialActions	2	1	7	1	2	3
			loadScripts	1392	1159	2950	305	1427	1845
			setupStore	168	7	1265	227	159	740
			numNetworkReqs	82	47	178	26	79	144

📊 Page Load Benchmark Results

Current Commit: b5c6270 | Date: 12/4/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 970ms (±40ms) 🟢 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 674ms (±36ms) 🟢 | historical mean value: 733ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	970ms	40ms	947ms	1.26s	991ms	1.26s
domContentLoaded	674ms	36ms	653ms	924ms	692ms	924ms
firstPaint	75ms	10ms	60ms	164ms	84ms	164ms
firstContentfulPaint	75ms	10ms	60ms	164ms	84ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 116 Bytes (0%)
ui: 0 Bytes (0%)
common: 20 Bytes (0%)

test/e2e/tests/profile-metrics/profile-metrics.spec.ts

Co-authored-by: Jongsun Suh <[email protected]>

MajorLift

LGTM!

metamaskbot · 2025-12-04T19:00:42Z

Builds ready [1424dce]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1224 ± 97 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1224	1028	1607	97	1289	1385
			load	1024	853	1349	87	1075	1183
			domContentLoaded	1019	850	1345	86	1069	1177
			domInteractive	26	15	139	22	21	84
			firstPaint	478	83	1216	391	996	1160
			backgroundConnect	212	195	268	12	216	235
			firstReactRender	29	19	62	9	33	49
			getState	36	16	121	18	39	70
			initialActions	1	0	4	1	1	3
			loadScripts	812	649	1092	83	860	967
			setupStore	11	7	25	3	12	19
			numNetworkReqs	11	5	69	17	5	59
	Browserify	Power User Home	uiStartup	2212	1681	3039	222	2335	2642
			load	1113	834	1601	142	1144	1518
			domContentLoaded	1096	824	1593	143	1118	1507
			domInteractive	37	18	167	26	39	113
			firstPaint	732	123	1527	418	1093	1259
			backgroundConnect	295	189	671	95	294	561
			firstReactRender	63	42	118	14	70	88
			getState	214	151	320	31	230	275
			initialActions	1	0	4	1	1	2
			loadScripts	843	646	1300	131	853	1225
			setupStore	20	8	53	8	22	35
			numNetworkReqs	146	65	300	61	203	266
	Webpack	Standard Home	uiStartup	796	688	1019	72	826	978
			load	619	558	861	65	629	782
			domContentLoaded	615	554	857	65	626	775
			domInteractive	27	15	129	25	21	97
			firstPaint	231	104	834	170	211	619
			backgroundConnect	10	6	67	8	11	28
			firstReactRender	27	20	79	7	31	37
			getState	27	13	58	10	35	44
			initialActions	1	0	4	1	1	2
			loadScripts	612	551	849	63	624	767
			setupStore	10	6	31	4	12	18
			numNetworkReqs	11	5	71	17	5	62
	Webpack	Power User Home	uiStartup	1551	1252	2126	203	1583	2029
			load	675	583	1133	92	682	893
			domContentLoaded	664	578	1122	93	669	880
			domInteractive	38	18	219	35	35	114
			firstPaint	268	88	904	183	269	670
			backgroundConnect	52	7	563	127	19	534
			firstReactRender	57	43	85	8	62	72
			getState	173	133	228	19	183	210
			initialActions	1	0	2	1	1	2
			loadScripts	661	576	1085	89	667	870
			setupStore	20	9	60	11	22	49
			numNetworkReqs	162	69	408	67	217	286
Firefox	Browserify	Standard Home	uiStartup	1349	1078	1786	140	1432	1578
			load	1114	926	1468	100	1161	1284
			domContentLoaded	1113	925	1468	100	1161	1284
			domInteractive	63	31	133	29	86	127
			firstPaint	-	-	-	-	-	-
			backgroundConnect	49	21	241	36	53	150
			firstReactRender	23	18	51	6	23	36
			getState	15	6	192	26	10	32
			initialActions	1	0	6	1	1	2
			loadScripts	1083	904	1439	97	1124	1257
			setupStore	11	5	44	8	10	30
			numNetworkReqs	12	5	65	17	6	62
	Browserify	Power User Home	uiStartup	2722	2025	5208	595	2821	4189
			load	1253	977	2622	293	1347	1927
			domContentLoaded	1252	977	2622	293	1347	1927
			domInteractive	123	32	620	97	129	358
			firstPaint	-	-	-	-	-	-
			backgroundConnect	156	28	1194	217	131	707
			firstReactRender	63	37	283	28	65	92
			getState	301	60	1110	249	363	901
			initialActions	2	0	29	3	2	3
			loadScripts	1185	953	1950	190	1310	1516
			setupStore	165	11	854	199	163	654
			numNetworkReqs	84	63	236	27	82	145
	Webpack	Standard Home	uiStartup	1573	1299	2154	156	1642	1933
			load	1275	1100	1544	99	1338	1467
			domContentLoaded	1275	1099	1544	99	1337	1467
			domInteractive	71	28	194	37	88	146
			firstPaint	-	-	-	-	-	-
			backgroundConnect	55	21	176	34	70	121
			firstReactRender	30	20	103	10	33	42
			getState	18	7	179	30	13	80
			initialActions	1	0	3	1	2	2
			loadScripts	1242	1049	1461	92	1305	1416
			setupStore	17	6	140	20	15	58
			numNetworkReqs	12	5	67	17	7	65
	Webpack	Power User Home	uiStartup	2987	2105	5827	824	2890	4836
			load	1511	1123	3186	453	1521	2703
			domContentLoaded	1510	1123	3185	453	1521	2703
			domInteractive	113	31	484	97	105	377
			firstPaint	-	-	-	-	-	-
			backgroundConnect	174	29	1215	220	164	628
			firstReactRender	66	41	304	38	63	147
			getState	286	58	1059	229	384	788
			initialActions	2	0	7	1	2	3
			loadScripts	1445	1093	3009	397	1478	2563
			setupStore	173	7	1159	236	164	746
			numNetworkReqs	83	60	173	25	79	143

📊 Page Load Benchmark Results

Current Commit: 1424dce | Date: 12/4/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±40ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 729ms (±37ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±13ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	40ms	1.02s	1.33s	1.07s	1.33s
domContentLoaded	729ms	37ms	699ms	992ms	756ms	992ms
firstPaint	79ms	13ms	60ms	196ms	88ms	196ms
firstContentfulPaint	79ms	13ms	60ms	196ms	88ms	196ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 116 Bytes (0%)
ui: -7 Bytes (0%)
common: 735 Bytes (0.01%)

Gudahtt

LGTM!

refactor: gate ProfileMetricsController with pna25Acknowledged

1e62901

metamaskbot added the team-core-platform Core Platform team label Dec 4, 2025

github-actions bot added the size-M label Dec 4, 2025

update test titles

b5c6270

MajorLift reviewed Dec 4, 2025

View reviewed changes

test/e2e/tests/profile-metrics/profile-metrics.spec.ts Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

Update test/e2e/tests/profile-metrics/profile-metrics.spec.ts

1424dce

Co-authored-by: Jongsun Suh <[email protected]>

mikesposito dismissed MajorLift’s stale review via 1424dce December 4, 2025 18:27

mikesposito requested a review from MajorLift December 4, 2025 18:29

MajorLift approved these changes Dec 4, 2025

View reviewed changes

mikesposito changed the title ~~refactor: gate ProfileMetricsController with pna25Acknowledged~~ refactor: cp-13.13.0 gate ProfileMetricsController with pna25Acknowledged Dec 5, 2025

mikesposito enabled auto-merge December 5, 2025 13:26

Gudahtt approved these changes Dec 5, 2025

View reviewed changes

mikesposito added this pull request to the merge queue Dec 5, 2025

Merged via the queue into main with commit b7afe24 Dec 5, 2025
336 of 338 checks passed

mikesposito deleted the mikesposito/refactor/gate-profile-metrics-on-ack branch December 5, 2025 15:04

github-actions bot locked and limited conversation to collaborators Dec 5, 2025

metamaskbot added the release-13.14.0 Issue or pull request that will be included in release 13.14.0 label Dec 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: cp-13.13.0 gate `ProfileMetricsController` with `pna25Acknowledged` #38562

refactor: cp-13.13.0 gate `ProfileMetricsController` with `pna25Acknowledged` #38562

mikesposito commented Dec 4, 2025 •

edited by cursor bot

Loading

Uh oh!

metamaskbot commented Dec 4, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

MajorLift left a comment

Uh oh!

metamaskbot commented Dec 4, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Gudahtt left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

refactor: cp-13.13.0 gate ProfileMetricsController with pna25Acknowledged #38562

refactor: cp-13.13.0 gate ProfileMetricsController with pna25Acknowledged #38562

Conversation

mikesposito commented Dec 4, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Dec 4, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

MajorLift left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Dec 4, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Gudahtt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

refactor: cp-13.13.0 gate `ProfileMetricsController` with `pna25Acknowledged` #38562

refactor: cp-13.13.0 gate `ProfileMetricsController` with `pna25Acknowledged` #38562

mikesposito commented Dec 4, 2025 •

edited by cursor bot

Loading