feat(metrics): track address_alert_response when transactions are added

[imblue-dabadee]

Description

The "Transaction Added" event was missing the address_alert_response field, which made it difficult to analyze transaction flows by address security status from the initial event.

Solution
Added address_alert_response to the initial "Transaction Added" event. The field includes:

• The actual scan result if already cached (e.g., 'Benign', 'Malicious')
• 'Loading' if the scan is still in progress
• 'not_applicable' when scanning cannot be performed (security alerts disabled, no to address, or unsupported chain)

The useTrustSignalMetrics hook continues to update the event fragment with the final value once the scan completes.

Changelog

CHANGELOG entry: null

Manual testing steps

1. Start the mock Segment server:

node development/mock-segment.js

2. Start the extension with Segment enabled:

yarn start

3. Trigger a transaction (e.g., send ETH or interact with a dApp)
4. In the mock Segment terminal, observe the "Transaction Added" event
5. Verify address_alert_response is present with one of:
   • 'Loading' (scan in progress)
   • 'Benign', 'Malicious', 'Warning' (scan result)
   • 'not_applicable' (security alerts disabled or unsupported chain)
6. Approve or reject the transaction
7. Verify the "Transaction Finalized" event has the final address_alert_response value (should no longer be 'Loading')

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Adds address_alert_response to transaction event properties, sourcing cached trust-signal results when available or marking as Loading/not_applicable as needed.

• Metrics (transaction events):
  • Add address_alert_response to properties built in buildEventFragmentProperties for "added", "approved", "submitted", and "finalized" flows.
  • New helper computes value using trust-signal utils (createCacheKey, mapChainIdToSupportedEVMChain, ResultType):
    • Uses cached response result_type when present.
    • Falls back to Loading or not_applicable (security alerts disabled, missing to, or unsupported chain).
• Controller/Types:
  • Extend TransactionMetricsRequest with getAddressSecurityAlertResponse(cacheKey) and getSecurityAlertsEnabled(); expose implementations in metamask-controller.
  • Import trust-signal types (ScanAddressResponse) and utilities in metrics module.
• Tests:
  • Update metrics tests to mock new getters and expect address_alert_response in event properties.

^{Written by Cursor Bugbot for commit c898d6f. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (2 files, +58 -0)

• 📁 app/
  • 📁 scripts/
    • 📁 lib/
      • 📁 transaction/
        • 📄 metrics.test.ts +5 -0
        • 📄 metrics.ts +53 -0

[metamaskbot]

Builds ready [865e80c]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1201 ± 102 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1201	1009	1430	102	1275	1378
			load	1001	837	1205	85	1066	1154
			domContentLoaded	995	832	1199	84	1060	1147
			domInteractive	25	15	156	22	20	85
			firstPaint	618	77	1217	406	1017	1146
			backgroundConnect	207	182	244	12	211	231
			firstReactRender	30	20	60	9	35	48
			getState	35	14	134	19	41	64
			initialActions	1	0	8	1	1	2
			loadScripts	794	645	997	81	847	932
			setupStore	12	7	29	4	13	21
			numNetworkReqs	10	5	68	16	5	58
	Browserify	Power User Home	uiStartup	2153	1779	2883	218	2277	2599
			load	1070	921	1671	132	1083	1405
			domContentLoaded	1055	916	1659	132	1066	1397
			domInteractive	37	20	133	24	37	106
			firstPaint	538	92	1440	407	1005	1302
			backgroundConnect	268	211	747	107	246	615
			firstReactRender	60	43	106	14	64	95
			getState	211	141	761	94	216	261
			initialActions	1	0	4	1	1	2
			loadScripts	831	704	1445	129	832	1162
			setupStore	21	10	73	10	25	42
			numNetworkReqs	155	66	341	57	206	271
	Webpack	Standard Home	uiStartup	819	701	1081	81	851	984
			load	639	568	866	76	657	812
			domContentLoaded	634	561	859	75	651	806
			domInteractive	27	15	154	25	23	101
			firstPaint	232	88	826	160	214	609
			backgroundConnect	11	6	56	7	11	26
			firstReactRender	27	20	41	6	32	39
			getState	27	14	61	11	35	49
			initialActions	1	0	4	1	1	1
			loadScripts	631	559	850	74	649	796
			setupStore	11	6	35	4	12	19
			numNetworkReqs	11	5	71	17	5	59
	Webpack	Power User Home	uiStartup	1563	1267	2185	209	1629	2029
			load	674	578	1054	91	687	875
			domContentLoaded	664	574	1048	91	674	863
			domInteractive	35	17	166	27	35	102
			firstPaint	267	96	915	190	268	690
			backgroundConnect	50	7	622	123	19	458
			firstReactRender	58	41	93	8	63	69
			getState	191	131	742	97	184	219
			initialActions	1	0	2	1	1	2
			loadScripts	662	572	1039	90	672	859
			setupStore	20	6	58	10	23	45
			numNetworkReqs	164	52	327	60	216	279
Firefox	Browserify	Standard Home	uiStartup	1321	1099	1812	141	1404	1581
			load	1092	945	1348	88	1150	1254
			domContentLoaded	1091	945	1348	88	1146	1254
			domInteractive	63	33	146	29	86	116
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	22	145	29	59	124
			firstReactRender	23	18	46	5	24	36
			getState	12	5	105	12	11	24
			initialActions	1	0	2	1	1	2
			loadScripts	1064	928	1271	77	1121	1197
			setupStore	12	4	71	11	10	34
			numNetworkReqs	12	5	68	17	6	64
	Browserify	Power User Home	uiStartup	2674	2081	4437	464	2768	3953
			load	1263	1000	2552	287	1244	1750
			domContentLoaded	1262	993	2552	287	1244	1750
			domInteractive	143	33	1024	144	126	432
			firstPaint	-	-	-	-	-	-
			backgroundConnect	143	28	1112	155	157	456
			firstReactRender	57	39	113	13	62	86
			getState	303	66	953	223	346	792
			initialActions	2	1	7	1	2	3
			loadScripts	1218	982	2398	253	1215	1703
			setupStore	154	8	882	201	144	743
			numNetworkReqs	83	53	167	25	79	147
	Webpack	Standard Home	uiStartup	1532	1281	1890	150	1626	1841
			load	1260	1074	1618	105	1332	1424
			domContentLoaded	1259	1073	1611	105	1332	1424
			domInteractive	63	27	165	35	86	139
			firstPaint	-	-	-	-	-	-
			backgroundConnect	54	19	196	33	67	122
			firstReactRender	27	21	87	8	29	38
			getState	14	7	155	17	14	47
			initialActions	1	0	3	1	1	2
			loadScripts	1231	1060	1594	99	1309	1387
			setupStore	13	5	82	11	14	37
			numNetworkReqs	12	5	66	17	7	63
	Webpack	Power User Home	uiStartup	2998	2205	5444	754	2933	4709
			load	1479	1197	2997	422	1458	2797
			domContentLoaded	1479	1196	2997	421	1458	2797
			domInteractive	108	32	479	93	106	351
			firstPaint	-	-	-	-	-	-
			backgroundConnect	197	39	1286	259	163	1052
			firstReactRender	68	38	213	32	66	154
			getState	267	71	833	203	362	727
			initialActions	2	0	7	1	2	3
			loadScripts	1402	1098	2841	319	1436	2061
			setupStore	151	6	1088	213	122	685
			numNetworkReqs	84	60	258	31	79	153

📊 Page Load Benchmark Results

Current Commit: 865e80c | Date: 12/4/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.03s (±43ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
• domContentLoaded-> current mean value: 717ms (±39ms) 🟢 | historical mean value: 732ms ⬇️ (historical data)
• firstContentfulPaint-> current mean value: 76ms (±15ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	43ms	1.00s	1.35s	1.08s	1.35s
domContentLoaded	717ms	39ms	696ms	1.01s	737ms	1.01s
firstPaint	76ms	15ms	56ms	208ms	88ms	208ms
firstContentfulPaint	76ms	15ms	56ms	208ms	88ms	208ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 960 Bytes (0.02%)
• ui: 0 Bytes (0%)
• common: 20 Bytes (0%)

[metamaskbot]

Builds ready [c898d6f]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1251 ± 96 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1251	1032	1474	96	1318	1409
			load	1038	850	1249	82	1104	1177
			domContentLoaded	1032	845	1241	81	1100	1171
			domInteractive	21	15	39	6	21	37
			firstPaint	482	95	1238	395	1006	1154
			backgroundConnect	210	193	255	11	215	230
			firstReactRender	46	31	101	14	52	75
			getState	38	17	123	19	42	74
			initialActions	1	0	5	1	1	3
			loadScripts	829	655	1047	78	891	965
			setupStore	12	6	34	4	14	21
			numNetworkReqs	8	6	31	6	6	30
	Browserify	Power User Home	uiStartup	1913	1554	2262	125	1998	2161
			load	1098	913	1327	100	1157	1303
			domContentLoaded	1084	908	1310	99	1144	1278
			domInteractive	27	18	88	9	27	45
			firstPaint	602	91	1335	431	1067	1223
			backgroundConnect	268	206	737	113	253	640
			firstReactRender	46	36	86	7	49	56
			getState	199	148	285	32	222	263
			initialActions	1	0	2	1	1	2
			loadScripts	864	697	1102	100	924	1062
			setupStore	17	11	65	8	16	37
			numNetworkReqs	69	58	115	14	67	110
	Webpack	Standard Home	uiStartup	801	704	949	43	824	869
			load	623	558	731	48	665	709
			domContentLoaded	618	554	726	48	661	704
			domInteractive	21	14	41	6	21	37
			firstPaint	199	88	671	135	193	619
			backgroundConnect	11	5	30	7	13	28
			firstReactRender	54	33	155	32	46	122
			getState	23	13	47	9	29	44
			initialActions	1	0	2	1	1	1
			loadScripts	616	552	724	47	659	702
			setupStore	10	6	21	3	11	18
			numNetworkReqs	8	6	31	6	6	29
	Webpack	Power User Home	uiStartup	1483	1184	2088	161	1590	1732
			load	733	593	933	90	821	881
			domContentLoaded	726	588	926	89	811	874
			domInteractive	27	16	78	11	27	49
			firstPaint	271	102	829	193	263	769
			backgroundConnect	52	7	574	121	22	503
			firstReactRender	48	39	97	8	50	61
			getState	202	142	668	64	232	310
			initialActions	1	0	2	0	1	2
			loadScripts	723	585	923	89	809	872
			setupStore	14	8	53	7	14	32
			numNetworkReqs	68	58	208	17	66	97
Firefox	Browserify	Standard Home	uiStartup	1259	1091	2101	141	1325	1527
			load	1036	923	1929	119	1070	1220
			domContentLoaded	1035	923	1929	119	1070	1219
			domInteractive	52	31	194	27	72	104
			firstPaint	-	-	-	-	-	-
			backgroundConnect	38	21	120	20	41	91
			firstReactRender	37	28	71	9	38	57
			getState	12	7	65	8	10	24
			initialActions	1	0	2	0	1	2
			loadScripts	1012	910	1904	114	1040	1194
			setupStore	10	5	24	4	10	21
			numNetworkReqs	8	6	32	6	7	25
	Browserify	Power User Home	uiStartup	2628	1564	3453	576	3097	3340
			load	1588	963	2438	545	2127	2371
			domContentLoaded	1588	963	2438	545	2127	2371
			domInteractive	97	32	1073	195	69	252
			firstPaint	-	-	-	-	-	-
			backgroundConnect	180	25	1145	264	180	1097
			firstReactRender	54	34	103	14	59	88
			getState	151	82	349	49	179	241
			initialActions	2	1	34	4	2	3
			loadScripts	1497	940	2335	503	2002	2266
			setupStore	66	5	1102	164	40	326
			numNetworkReqs	69	54	114	13	72	106
	Webpack	Standard Home	uiStartup	1668	1441	2048	134	1740	1941
			load	1349	1172	1517	73	1395	1495
			domContentLoaded	1349	1171	1517	73	1395	1494
			domInteractive	76	31	205	39	97	144
			firstPaint	-	-	-	-	-	-
			backgroundConnect	52	22	182	28	53	124
			firstReactRender	49	38	114	13	52	91
			getState	19	8	254	32	16	63
			initialActions	1	1	4	1	2	2
			loadScripts	1321	1155	1486	71	1365	1464
			setupStore	18	7	173	24	14	61
			numNetworkReqs	8	6	26	5	7	24
	Webpack	Power User Home	uiStartup	2833	1813	4087	575	3255	3526
			load	1897	1149	2691	514	2347	2508
			domContentLoaded	1897	1146	2690	514	2347	2508
			domInteractive	132	31	1112	250	80	1008
			firstPaint	-	-	-	-	-	-
			backgroundConnect	179	25	1056	229	211	1014
			firstReactRender	56	35	139	13	61	82
			getState	136	84	319	47	169	227
			initialActions	3	1	44	6	2	3
			loadScripts	1813	1124	2489	479	2248	2416
			setupStore	33	4	339	61	27	204
			numNetworkReqs	69	51	118	15	69	111

📊 Page Load Benchmark Results

Current Commit: c898d6f | Date: 12/5/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.03s (±43ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
• domContentLoaded-> current mean value: 719ms (±40ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
• firstContentfulPaint-> current mean value: 77ms (±14ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	43ms	1.01s	1.38s	1.06s	1.38s
domContentLoaded	719ms	40ms	698ms	1.04s	739ms	1.04s
firstPaint	77ms	14ms	60ms	200ms	84ms	200ms
firstContentfulPaint	77ms	14ms	60ms	200ms	84ms	200ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

• background: -27.21 KiB (-0.51%)
• ui: 4.45 KiB (0.06%)
• common: -188.57 KiB (-2.07%)