fix: account list in SRP reveal flow #39005
Merged
+457
−312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (9 files, +446 -310)
👨🔧 @MetaMask/core-extension-ux (8 files, +410 -309)
🧪 @MetaMask/qa (1 files, +10 -1)
|
Contributor
Builds ready [b7cfca3]
UI Startup Metrics (1276 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [1d839dc]
UI Startup Metrics (1250 ± 86 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [5e3e2fb]
UI Startup Metrics (1312 ± 111 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [877ffa0]
UI Startup Metrics (1246 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Builds ready [4709bd7]
UI Startup Metrics (1295 ± 96 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vinnyhoward
previously approved these changes
Jan 7, 2026
Contributor
Builds ready [b8fec12]
UI Startup Metrics (1288 ± 101 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
chloeYue
approved these changes
Jan 7, 2026
Contributor
Builds ready [e09bda0]
UI Startup Metrics (1272 ± 104 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vinnyhoward
approved these changes
Jan 7, 2026
metamaskbot
added
the
release-13.14.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The account list displayed on the SRP reveal flow was outdated by showing the UI pre-BIP44. This PR updates the UI to show the correct multichain account list.
Changelog
CHANGELOG entry: Update SRP flow to display multichain accounts
Related issues
Fixes: #35731
Fixes: #38115
Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1363
Manual testing steps
Screenshots/Recordings
Before
Review linked issues for before screenshots
After
Screen.Recording.2025-12-31.at.10.25.21.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Modernizes the SRP reveal flow to correctly display multichain accounts and balances.
SrpCardand simplifiesSrpListto source wallet IDs viagetWalletIdsByType(AccountWalletType.Entropy)and render accounts fromuseWalletInfoSrpListItemAPI toaccountId/accountName/balance, usesPreferredAvatarseeded bygetIconSeedAddressByAccountGroupId, and displays provided fiat balancegetWalletIdsByTypeinselectors/multichain-accounts/account-treesrp-list.test.tsx,srp-card.test.tsx, andsrp-list-item.test.tsxto match new data flow and UIsrp-list__account-namemax width to 120px and exportsSrpListItemWritten by Cursor Bugbot for commit e09bda0. This will update automatically on new commits. Configure here.