-
Notifications
You must be signed in to change notification settings - Fork 5.5k
test: Mmqa 1217 btc e2e tests #39175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [6571bcd]
UI Startup Metrics (1258 ± 97 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
6571bcd to
678bb3e
Compare
Builds ready [678bb3e]
UI Startup Metrics (1280 ± 98 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [59a9a64]
UI Startup Metrics (1301 ± 134 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (6 files, +62 -177)
🔄 @MetaMask/swaps-engineers (1 files, +23 -2)
|
Builds ready [f81315e]
UI Startup Metrics (1313 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [3ce8028]
UI Startup Metrics (1348 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [987ddde]
UI Startup Metrics (1297 ± 110 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [9699e22]
UI Startup Metrics (1310 ± 114 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
racitores
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some comments to discuss before merge 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
| json: [{ bridgeConfig: BTC_BRIDGE_FEATURE_FLAGS }], | ||
| }; | ||
| }); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicting feature flag mocks may cause test failures
Medium Severity
Two mock functions register handlers for the same feature flags URL (https://client-config.api.cx.metamask.io/v1/flags). mockBridgeFeatureFlags uses .always() without query filtering, while mockBitcoinFeatureFlag filters by specific query parameters. When both mocks are registered (when mockSwap=true), the .always() mock in mockBridgeFeatureFlags may intercept requests intended for mockBitcoinFeatureFlag, causing the Bitcoin feature flags to not be returned correctly.
Additional Locations (1)
Builds ready [ae454b6]
UI Startup Metrics (1353 ± 116 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
davibroc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM


Description
BTC e2e tests:
Changes:
-->
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk because it rewires BTC E2E setup (onboarding/feature flags/mocks) and adds extensive new mocking for Bitcoin Esplora + Bridge APIs, which can introduce test flakiness and false positives/negatives.
Overview
Adds new Bitcoin E2E coverage for Send and Swap (Bridge). New tests cover BTC send validation + submit flow (including activity list
pendingstatus) and BTC→ETH bridge flows (open bridge, fetch quote, insufficient funds, no-route, and submit).Revamps the BTC test harness and mocks. The BTC snap fixture helper is moved under
test/e2e/tests/btcand now uses onboarding + network switching, configurable swap/bridge mocking, and a much more complete Esplora/Infura mock (blocks/txs/utxos/tx details/outspends/broadcast), plus new Bridge API mocks (tokens/quotes/status/feature flags) and expanded price/exchange-rate mocks.Updates page objects for new selectors/flows. Bitcoin homepage selectors are aligned to
coin-overview-*test IDs and balance formatting, the BTC review screen assertions now use snap confirmation buttons and updated fee/total displays, the bridge quote page gets acheckPageIsLoadedhelper and adjusts quote entry ordering, and activity status waiting now supports apendingstate.Written by Cursor Bugbot for commit ae454b6. This will update automatically on new commits. Configure here.