feat: add platform and install_type as MetaMetrics user traits #39606
+113
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add platform (browser type) and install_type (installation source) as user traits sent via identify() instead of as properties on every event. This is the appropriate approach for static installation properties. - Add initInstallType() to cache install type from browser.management API - Add Platform and InstallType to MetaMetricsUserTrait enum - Update _buildUserTraitsObject to include these traits - Update unit test expectations
gauthierpetetin
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
gauthierpetetin
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
Builds ready [74448f0]
UI Startup Metrics (1388 ± 119 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
gauthierpetetin
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
MajorLift
reviewed
Jan 29, 2026
Contributor
MajorLift
left a comment
MajorLift
left a comment
There was a problem hiding this comment.
Looks good! Thoughts on enforcing + documenting the range of platform and install types with types?
Add type-safe constants and types for platform and install_type user traits instead of using plain strings. This provides compile-time validation and better IDE support. - Add PLATFORM and INSTALL_TYPE const objects in shared/constants/app.ts - Export Platform and InstallType types derived from these objects - Update getPlatform() and getInstallType() to use proper return types - Update MetaMetricsUserTraits to use typed fields Co-authored-by: Cursor <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
gauthierpetetin
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Remove duplicated install type fetching logic from setupSentry.js and use the shared functions from util.ts instead. This ensures a single source of truth for install type caching and eliminates redundant API calls to browser.management.getSelf(). Co-authored-by: Cursor <[email protected]>
gauthierpetetin
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Move install type caching logic to a separate lightweight module (install-type.ts) that only imports webextension-polyfill and constants. This prevents the sentry bundle from pulling in heavy dependencies like reselect through util.ts, which was causing browserify parsing errors. - Create app/scripts/lib/install-type.ts with initInstallType/getInstallType - Update setupSentry.js to import from install-type instead of util - Re-export from util.ts for backward compatibility
gauthierpetetin
had a problem deploying
to
pr-comment
GitHub Actions
Error
gauthierpetetin
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
gauthierpetetin
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
Builds ready [f526ca5]
UI Startup Metrics (1378 ± 117 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gauthierpetetin
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
gauthierpetetin
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
gauthierpetetin
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
Builds ready [cbb9c64]
UI Startup Metrics (1355 ± 87 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
9 tasks
MajorLift
approved these changes
Feb 2, 2026
This was
linked to
issues
Feb 2, 2026
Open
sleepytanya
approved these changes
Feb 2, 2026
github-project-automation
bot
moved this from Needs dev review
to Review finalised - Ready to be merged
in PR review queue
github-project-automation
bot
moved this from Review finalised - Ready to be merged
to Merged, Closed or Archived
in PR review queue
metamaskbot
added
the
release-13.18.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add platform (browser type) and install_type (installation source) as user traits sent via identify() instead of as properties on every event. This is the appropriate approach for static installation properties.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
platformandinstall_typedefined in its user profile propertiesScreenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk because it touches analytics trait generation and Sentry error-tagging, plus adds an early background initialization side-effect via
browser.management.getSelf()(albeit fire-and-forget). Functionality is additive but could impact telemetry correctness and startup behavior across browsers.Overview
Adds
platformandinstall_typeas new MetaMetrics user traits (viaidentify()), and wiresMetaMetricsController._buildUserTraitsObjectto populate them usinggetPlatform()and a new cachedgetInstallType().Introduces a dedicated
install-typehelper (withinitInstallType()+ cached value) and initializes it early in bothbackground.jsstartup and Sentry setup; Sentry reports now tag/includeinstallTypevia the cache rather than an inline async fetch. Updates shared constants/types to formalizePlatform/InstallTypeand adjusts MetaMetrics controller tests accordingly.Written by Cursor Bugbot for commit cbb9c64. This will update automatically on new commits. Configure here.