fix: Replace `metamask_sendDomainMetadata` with a no-op #39642

FrederikBolding · 2026-01-29T15:56:51Z

Description

Replace metamask_sendDomainMetadata with a no-op as we no longer need the provider to report metadata for sites. The SubjectMetadataController is populated already using the tabs API. The RPC method is kept around for backwards compatibility.

Changelog

CHANGELOG entry: Calling the RPC method metamask_sendDomainMetadata no longer has any effect.

Manual testing steps

Connect to any dapp
See that the name and icon for a site is populated in the connection screen

Note

Medium Risk
Disables domain-metadata reporting from the inpage provider and removes the backend hook that persisted this metadata, which could affect any flows still relying on metamask_sendDomainMetadata for site name/icon display.

Overview
Stops the inpage provider from sending site metadata by setting shouldSendMetadata: false during initializeProvider.

Replaces the metamask_sendDomainMetadata (MESSAGE_TYPE.SEND_METADATA) RPC handler with a no-op that always returns true, removing subject-metadata persistence hooks (addSubjectMetadata/subjectType) from middleware wiring and updating the unit test to match.

^{Written by Cursor Bugbot for commit cf06db4. This will update automatically on new commits. Configure here.}

metamaskbotv2 · 2026-01-29T15:58:05Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/wallet-integrations (2 files, +9 -59)

📁 app/
- 📁 scripts/
  - 📁 lib/
    - 📁 rpc-method-middleware/
      - 📁 handlers/
        
        📄 send-metadata.test.ts +4 -18
        
        📄 send-metadata.ts +5 -41

app/scripts/lib/rpc-method-middleware/handlers/send-metadata.ts

metamaskbotv2 · 2026-01-29T17:37:29Z

Builds ready [b4906b8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1332 ± 117 ms)

Platform	BuildType	Page	Metric	Test Title (ms)	Persona (ms)	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1332	1062	1688	117	1393	1530
			load	-	-	1126	904	1484	117	1196	1302
			domContentLoaded	-	-	1118	897	1476	116	1185	1297
			domInteractive	-	-	28	16	96	19	24	83
			firstPaint	-	-	194	65	1143	219	203	1057
			backgroundConnect	-	-	236	215	276	12	240	265
			firstReactRender	-	-	17	11	34	4	18	26
			initialActions	-	-	1	0	6	1	1	3
			loadScripts	-	-	898	692	1260	115	966	1086
			setupStore	-	-	13	6	29	6	16	26
			numNetworkReqs	-	-	22	15	82	17	15	74
			19	-	-	-	-	-	-	-	-
	Browserify	Power User Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	2821	1516	8181	1289	4229	4866
			load	-	-	1130	963	1697	135	1189	1422
			domContentLoaded	-	-	1111	950	1660	131	1176	1415
			domInteractive	-	-	37	19	291	34	33	99
			firstPaint	-	-	212	78	1505	187	261	433
			backgroundConnect	-	-	865	278	3177	868	1388	3122
			firstReactRender	-	-	23	16	53	6	24	36
			initialActions	-	-	1	0	4	1	1	3
			loadScripts	-	-	876	734	1233	116	934	1172
			setupStore	-	-	14	6	50	7	16	23
			numNetworkReqs	-	-	134	54	337	52	162	236
			19	-	-	-	-	-	-	-	-
	Webpack	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
2			-	-	-	-	-	-	-	-
3			-	-	-	-	-	-	-	-
4			-	-	-	-	-	-	-	-
5			-	-	-	-	-	-	-	-
6			-	-	-	-	-	-	-	-
7			-	-	-	-	-	-	-	-
8			-	-	-	-	-	-	-	-
9			-	-	-	-	-	-	-	-
10			-	-	-	-	-	-	-	-
11			-	-	-	-	-	-	-	-
12			-	-	-	-	-	-	-	-
13			-	-	-	-	-	-	-	-
14			-	-	-	-	-	-	-	-
15			-	-	-	-	-	-	-	-
16			-	-	-	-	-	-	-	-
17			-	-	-	-	-	-	-	-
18			-	-	-	-	-	-	-	-
uiStartup			-	-	825	671	1145	93	869	1030
load			-	-	682	586	922	78	724	888
domContentLoaded			-	-	676	582	916	77	719	881
domInteractive			-	-	25	14	97	18	22	74
firstPaint			-	-	106	58	345	56	116	225
backgroundConnect			-	-	37	18	114	20	44	80
firstReactRender			-	-	15	10	38	5	17	27
initialActions			-	-	1	0	7	1	1	2
loadScripts			-	-	674	580	914	76	717	879
setupStore			-	-	12	6	63	7	13	24
numNetworkReqs			-	-	22	15	81	18	15	76
19			-	-	-	-	-	-	-	-
Webpack	Power User Home	0	-	-	-	-	-	-	-	-
		1	-	-	-	-	-	-	-	-
		2	-	-	-	-	-	-	-	-
		3	-	-	-	-	-	-	-	-
		4	-	-	-	-	-	-	-	-
		5	-	-	-	-	-	-	-	-
		6	-	-	-	-	-	-	-	-
		7	-	-	-	-	-	-	-	-
		8	-	-	-	-	-	-	-	-
		9	-	-	-	-	-	-	-	-
		10	-	-	-	-	-	-	-	-
		11	-	-	-	-	-	-	-	-
		12	-	-	-	-	-	-	-	-
		13	-	-	-	-	-	-	-	-
		14	-	-	-	-	-	-	-	-
		15	-	-	-	-	-	-	-	-
		16	-	-	-	-	-	-	-	-
		17	-	-	-	-	-	-	-	-
		18	-	-	-	-	-	-	-	-
		uiStartup	-	-	1285	869	2485	286	1461	1716
		load	-	-	706	616	1221	118	688	1007
		domContentLoaded	-	-	696	610	1215	118	681	1000
		domInteractive	-	-	35	18	179	29	32	110
		firstPaint	-	-	155	66	514	102	192	467
		backgroundConnect	-	-	159	131	574	66	148	349
		firstReactRender	-	-	23	17	38	4	24	31
		initialActions	-	-	1	0	3	1	1	1
		loadScripts	-	-	693	608	1207	116	679	992
		setupStore	-	-	12	4	38	5	13	20
		numNetworkReqs	-	-	127	53	313	53	142	257
		19	-	-	-	-	-	-	-	-
Firefox	Browserify	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1502	1179	2138	185	1618	1817
			load	-	-	1194	988	1492	108	1265	1394
			domContentLoaded	-	-	1193	988	1492	108	1265	1393
			domInteractive	-	-	81	34	293	51	112	163
			firstPaint	-	-	-	-	-	-	-	-
			backgroundConnect	-	-	64	23	214	43	85	162
			firstReactRender	-	-	14	10	47	6	14	25
			initialActions	-	-	1	0	3	1	2	2
			loadScripts	-	-	1159	972	1422	93	1233	1315
			setupStore	-	-	17	4	220	27	13	69
			numNetworkReqs	-	-	23	12	83	18	18	76
			19	-	-	-	-	-	-	-	-
	Browserify	Power User Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	2864	1972	7253	731	3076	3956
			load	-	-	1345	1094	5016	439	1400	1739
			domContentLoaded	-	-	1345	1093	5016	439	1400	1739
			domInteractive	-	-	155	54	998	127	177	355
			firstPaint	-	-	-	-	-	-	-	-
			backgroundConnect	-	-	452	132	1891	351	663	1182
			firstReactRender	-	-	22	14	62	7	23	30
			initialActions	-	-	2	0	3	1	2	2
			loadScripts	-	-	1286	1035	4968	425	1330	1610
			setupStore	-	-	126	15	753	151	134	529
			numNetworkReqs	-	-	91	42	235	45	92	221
			19	-	-	-	-	-	-	-	-
	Webpack	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
2			-	-	-	-	-	-	-	-
3			-	-	-	-	-	-	-	-
4			-	-	-	-	-	-	-	-
5			-	-	-	-	-	-	-	-
6			-	-	-	-	-	-	-	-
7			-	-	-	-	-	-	-	-
8			-	-	-	-	-	-	-	-
9			-	-	-	-	-	-	-	-
10			-	-	-	-	-	-	-	-
11			-	-	-	-	-	-	-	-
12			-	-	-	-	-	-	-	-
13			-	-	-	-	-	-	-	-
14			-	-	-	-	-	-	-	-
15			-	-	-	-	-	-	-	-
16			-	-	-	-	-	-	-	-
17			-	-	-	-	-	-	-	-
18			-	-	-	-	-	-	-	-
uiStartup			-	-	1635	1359	2005	153	1756	1912
load			-	-	1398	1181	1707	117	1463	1661
domContentLoaded			-	-	1397	1181	1707	117	1463	1661
domInteractive			-	-	87	28	232	42	125	141
firstPaint			-	-	-	-	-	-	-	-
backgroundConnect			-	-	69	26	202	44	87	167
firstReactRender			-	-	14	11	29	2	15	19
initialActions			-	-	1	0	2	1	2	2
loadScripts			-	-	1357	1168	1637	97	1433	1548
setupStore			-	-	16	5	145	23	12	43
numNetworkReqs			-	-	23	12	85	19	19	83
19			-	-	-	-	-	-	-	-
Webpack	Power User Home	0	-	-	-	-	-	-	-	-
		1	-	-	-	-	-	-	-	-
		2	-	-	-	-	-	-	-	-
		3	-	-	-	-	-	-	-	-
		4	-	-	-	-	-	-	-	-
		5	-	-	-	-	-	-	-	-
		6	-	-	-	-	-	-	-	-
		7	-	-	-	-	-	-	-	-
		8	-	-	-	-	-	-	-	-
		9	-	-	-	-	-	-	-	-
		10	-	-	-	-	-	-	-	-
		11	-	-	-	-	-	-	-	-
		12	-	-	-	-	-	-	-	-
		13	-	-	-	-	-	-	-	-
		14	-	-	-	-	-	-	-	-
		15	-	-	-	-	-	-	-	-
		16	-	-	-	-	-	-	-	-
		17	-	-	-	-	-	-	-	-
		18	-	-	-	-	-	-	-	-
		uiStartup	-	-	3049	2272	4807	505	3308	4178
		load	-	-	1577	1271	2613	258	1712	2220
		domContentLoaded	-	-	1577	1271	2612	258	1711	2219
		domInteractive	-	-	174	43	922	156	239	546
		firstPaint	-	-	-	-	-	-	-	-
		backgroundConnect	-	-	508	130	1620	332	735	1246
		firstReactRender	-	-	22	16	71	7	24	31
		initialActions	-	-	2	0	3	1	2	2
		loadScripts	-	-	1537	1235	2465	252	1659	2178
		setupStore	-	-	143	14	784	169	160	535
		numNetworkReqs	-	-	94	45	281	46	94	196
		19	-	-	-	-	-	-	-	-

📊 Page Load Benchmark Results

Current Commit: b4906b8 | Date: 1/29/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±39ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 730ms (±37ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±10ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	39ms	1.02s	1.33s	1.08s	1.33s
domContentLoaded	730ms	37ms	704ms	1.00s	755ms	1.00s
firstPaint	79ms	10ms	64ms	172ms	88ms	172ms
firstContentfulPaint	79ms	10ms	64ms	172ms	88ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 4.55 KiB (0.08%)
ui: 3 Bytes (0%)
common: 3.69 KiB (0.04%)

metamaskbotv2 · 2026-01-29T20:45:50Z

Builds ready [cf06db4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1349 ± 121 ms)

Platform	BuildType	Page	Metric	Test Title (ms)	Persona (ms)	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1349	1060	1624	121	1419	1566
			load	-	-	1155	899	1432	118	1228	1378
			domContentLoaded	-	-	1148	894	1425	118	1215	1370
			domInteractive	-	-	27	15	99	19	23	84
			firstPaint	-	-	169	65	1155	162	190	324
			backgroundConnect	-	-	239	216	300	14	243	270
			firstReactRender	-	-	18	11	39	5	21	27
			initialActions	-	-	1	0	6	1	1	2
			loadScripts	-	-	924	681	1206	118	989	1147
			setupStore	-	-	14	6	38	6	18	26
			numNetworkReqs	-	-	22	15	82	18	15	78
			19	-	-	-	-	-	-	-	-
	Browserify	Power User Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	3408	1662	8133	1536	4379	7448
			load	-	-	1235	1048	1852	139	1305	1497
			domContentLoaded	-	-	1214	1019	1841	138	1269	1485
			domInteractive	-	-	40	20	149	28	41	114
			firstPaint	-	-	252	89	1456	214	281	446
			backgroundConnect	-	-	1134	309	4663	1006	1769	2823
			firstReactRender	-	-	26	18	61	7	27	40
			initialActions	-	-	1	0	8	1	1	2
			loadScripts	-	-	961	790	1547	127	997	1203
			setupStore	-	-	16	6	64	8	18	31
			numNetworkReqs	-	-	109	58	223	35	117	190
			19	-	-	-	-	-	-	-	-
	Webpack	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
2			-	-	-	-	-	-	-	-
3			-	-	-	-	-	-	-	-
4			-	-	-	-	-	-	-	-
5			-	-	-	-	-	-	-	-
6			-	-	-	-	-	-	-	-
7			-	-	-	-	-	-	-	-
8			-	-	-	-	-	-	-	-
9			-	-	-	-	-	-	-	-
10			-	-	-	-	-	-	-	-
11			-	-	-	-	-	-	-	-
12			-	-	-	-	-	-	-	-
13			-	-	-	-	-	-	-	-
14			-	-	-	-	-	-	-	-
15			-	-	-	-	-	-	-	-
16			-	-	-	-	-	-	-	-
17			-	-	-	-	-	-	-	-
18			-	-	-	-	-	-	-	-
uiStartup			-	-	838	669	1338	103	904	1007
load			-	-	695	585	1218	93	752	848
domContentLoaded			-	-	690	580	1212	92	746	839
domInteractive			-	-	25	16	123	19	21	76
firstPaint			-	-	111	60	619	82	134	278
backgroundConnect			-	-	36	18	132	22	40	99
firstReactRender			-	-	16	10	118	11	18	27
initialActions			-	-	1	0	4	1	1	1
loadScripts			-	-	687	578	1204	91	739	836
setupStore			-	-	11	5	43	5	11	20
numNetworkReqs			-	-	22	15	91	18	15	71
19			-	-	-	-	-	-	-	-
Webpack	Power User Home	0	-	-	-	-	-	-	-	-
		1	-	-	-	-	-	-	-	-
		2	-	-	-	-	-	-	-	-
		3	-	-	-	-	-	-	-	-
		4	-	-	-	-	-	-	-	-
		5	-	-	-	-	-	-	-	-
		6	-	-	-	-	-	-	-	-
		7	-	-	-	-	-	-	-	-
		8	-	-	-	-	-	-	-	-
		9	-	-	-	-	-	-	-	-
		10	-	-	-	-	-	-	-	-
		11	-	-	-	-	-	-	-	-
		12	-	-	-	-	-	-	-	-
		13	-	-	-	-	-	-	-	-
		14	-	-	-	-	-	-	-	-
		15	-	-	-	-	-	-	-	-
		16	-	-	-	-	-	-	-	-
		17	-	-	-	-	-	-	-	-
		18	-	-	-	-	-	-	-	-
		uiStartup	-	-	1310	867	2593	286	1506	1695
		load	-	-	726	636	1348	119	725	1017
		domContentLoaded	-	-	715	625	1342	120	712	1007
		domInteractive	-	-	39	17	156	27	38	112
		firstPaint	-	-	159	78	968	117	197	351
		backgroundConnect	-	-	155	129	424	44	155	238
		firstReactRender	-	-	22	17	31	3	24	28
		initialActions	-	-	1	0	3	1	1	1
		loadScripts	-	-	712	623	1334	119	710	1002
		setupStore	-	-	11	5	31	4	14	18
		numNetworkReqs	-	-	166	89	332	54	176	309
		19	-	-	-	-	-	-	-	-
Firefox	Browserify	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1406	1110	1912	171	1532	1720
			load	-	-	1136	949	1606	119	1236	1336
			domContentLoaded	-	-	1136	949	1606	119	1232	1336
			domInteractive	-	-	65	30	217	39	88	144
			firstPaint	-	-	-	-	-	-	-	-
			backgroundConnect	-	-	64	24	226	46	77	167
			firstReactRender	-	-	13	9	40	5	13	19
			initialActions	-	-	1	0	3	1	2	2
			loadScripts	-	-	1102	934	1483	101	1169	1261
			setupStore	-	-	14	5	221	26	10	36
			numNetworkReqs	-	-	23	12	86	19	18	81
			19	-	-	-	-	-	-	-	-
	Browserify	Power User Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	3117	2112	9362	895	3252	4758
			load	-	-	1460	1128	2934	312	1558	2069
			domContentLoaded	-	-	1459	1128	2934	312	1554	2064
			domInteractive	-	-	193	52	1073	171	221	498
			firstPaint	-	-	-	-	-	-	-	-
			backgroundConnect	-	-	725	139	7293	785	916	1434
			firstReactRender	-	-	22	15	52	5	24	32
			initialActions	-	-	2	0	8	1	2	3
			loadScripts	-	-	1380	1096	2911	283	1492	1994
			setupStore	-	-	105	22	824	125	116	292
			numNetworkReqs	-	-	94	40	250	45	97	222
			19	-	-	-	-	-	-	-	-
	Webpack	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
2			-	-	-	-	-	-	-	-
3			-	-	-	-	-	-	-	-
4			-	-	-	-	-	-	-	-
5			-	-	-	-	-	-	-	-
6			-	-	-	-	-	-	-	-
7			-	-	-	-	-	-	-	-
8			-	-	-	-	-	-	-	-
9			-	-	-	-	-	-	-	-
10			-	-	-	-	-	-	-	-
11			-	-	-	-	-	-	-	-
12			-	-	-	-	-	-	-	-
13			-	-	-	-	-	-	-	-
14			-	-	-	-	-	-	-	-
15			-	-	-	-	-	-	-	-
16			-	-	-	-	-	-	-	-
17			-	-	-	-	-	-	-	-
18			-	-	-	-	-	-	-	-
uiStartup			-	-	1525	1280	2028	143	1584	1833
load			-	-	1320	1104	1801	112	1386	1534
domContentLoaded			-	-	1319	1104	1800	112	1383	1534
domInteractive			-	-	74	27	162	38	107	140
firstPaint			-	-	-	-	-	-	-	-
backgroundConnect			-	-	68	24	219	41	96	152
firstReactRender			-	-	13	10	38	3	13	18
initialActions			-	-	1	0	2	0	1	2
loadScripts			-	-	1280	1089	1696	95	1335	1457
setupStore			-	-	14	4	266	28	11	33
numNetworkReqs			-	-	22	12	82	16	19	70
19			-	-	-	-	-	-	-	-
Webpack	Power User Home	0	-	-	-	-	-	-	-	-
		1	-	-	-	-	-	-	-	-
		2	-	-	-	-	-	-	-	-
		3	-	-	-	-	-	-	-	-
		4	-	-	-	-	-	-	-	-
		5	-	-	-	-	-	-	-	-
		6	-	-	-	-	-	-	-	-
		7	-	-	-	-	-	-	-	-
		8	-	-	-	-	-	-	-	-
		9	-	-	-	-	-	-	-	-
		10	-	-	-	-	-	-	-	-
		11	-	-	-	-	-	-	-	-
		12	-	-	-	-	-	-	-	-
		13	-	-	-	-	-	-	-	-
		14	-	-	-	-	-	-	-	-
		15	-	-	-	-	-	-	-	-
		16	-	-	-	-	-	-	-	-
		17	-	-	-	-	-	-	-	-
		18	-	-	-	-	-	-	-	-
		uiStartup	-	-	3131	2093	7944	706	3366	3789
		load	-	-	1657	1289	6215	592	1751	2118
		domContentLoaded	-	-	1657	1289	6214	592	1747	2118
		domInteractive	-	-	160	46	703	129	182	511
		firstPaint	-	-	-	-	-	-	-	-
		backgroundConnect	-	-	529	139	1378	330	798	1148
		firstReactRender	-	-	22	15	32	4	24	30
		initialActions	-	-	2	1	3	1	2	2
		loadScripts	-	-	1618	1265	6179	591	1682	2086
		setupStore	-	-	143	15	1013	183	147	597
		numNetworkReqs	-	-	95	36	280	49	93	223
		19	-	-	-	-	-	-	-	-

📊 Page Load Benchmark Results

Current Commit: cf06db4 | Date: 1/29/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±38ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 729ms (±36ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	38ms	1.02s	1.33s	1.07s	1.33s
domContentLoaded	729ms	36ms	709ms	1.00s	753ms	1.00s
firstPaint	78ms	10ms	60ms	160ms	84ms	160ms
firstContentfulPaint	78ms	10ms	60ms	160ms	84ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 4.77 KiB (0.09%)
ui: 4.71 KiB (0.06%)
common: 3.73 KiB (0.04%)

adonesky1

LGTM

## **Description** Replace `metamask_sendDomainMetadata` with a no-op as we no longer need the provider to report metadata for sites. The `SubjectMetadataController` is populated already using the tabs API. The RPC method is kept around for backwards compatibility. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/39642?quickstart=1) ## **Changelog** CHANGELOG entry: Calling the RPC method `metamask_sendDomainMetadata` no longer has any effect. ## **Manual testing steps** 1. Connect to any dapp 2. See that the name and icon for a site is populated in the connection screen  --- > [!NOTE] > **Medium Risk** > Disables domain-metadata reporting from the inpage provider and removes the backend hook that persisted this metadata, which could affect any flows still relying on `metamask_sendDomainMetadata` for site name/icon display. > > **Overview** > Stops the inpage provider from sending site metadata by setting `shouldSendMetadata: false` during `initializeProvider`. > > Replaces the `metamask_sendDomainMetadata` (`MESSAGE_TYPE.SEND_METADATA`) RPC handler with a **no-op** that always returns `true`, removing subject-metadata persistence hooks (`addSubjectMetadata`/`subjectType`) from middleware wiring and updating the unit test to match. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit cf06db4. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>

FrederikBolding temporarily deployed to pr-comment January 29, 2026 15:56 — with GitHub Actions Inactive

metamaskbot added team-core-platform Core Platform team INVALID-PR-TEMPLATE PR's body doesn't match template labels Jan 29, 2026

github-actions bot added the size-M label Jan 29, 2026

FrederikBolding had a problem deploying to pr-comment January 29, 2026 16:14 — with GitHub Actions Failure

FrederikBolding had a problem deploying to pr-comment January 29, 2026 16:16 — with GitHub Actions Error

fix: Replace metamask_sendDomainMetadata with a no-op

4507ee6

FrederikBolding force-pushed the fb/remove-send-domain-metadata branch from d5ac62f to 4507ee6 Compare January 29, 2026 16:17

FrederikBolding temporarily deployed to pr-comment January 29, 2026 16:17 — with GitHub Actions Inactive

FrederikBolding changed the title ~~fix: Remove metamask_sendDomainMetadata~~ fix: Replace metamask_sendDomainMetadata with a no-op Jan 29, 2026

github-actions bot added size-S and removed size-M labels Jan 29, 2026

Clean up a bit

7a7290b

FrederikBolding temporarily deployed to pr-comment January 29, 2026 16:20 — with GitHub Actions Inactive

FrederikBolding had a problem deploying to pr-comment January 29, 2026 16:38 — with GitHub Actions Failure

FrederikBolding had a problem deploying to pr-comment January 29, 2026 16:39 — with GitHub Actions Failure

Fix lint

601dc13

FrederikBolding temporarily deployed to pr-comment January 29, 2026 16:39 — with GitHub Actions Inactive

FrederikBolding had a problem deploying to pr-comment January 29, 2026 16:58 — with GitHub Actions Failure

FrederikBolding had a problem deploying to pr-comment January 29, 2026 16:59 — with GitHub Actions Error

Remove unused hooks

b4906b8

FrederikBolding temporarily deployed to pr-comment January 29, 2026 17:03 — with GitHub Actions Inactive

adonesky1 reviewed Jan 29, 2026

View reviewed changes

app/scripts/lib/rpc-method-middleware/handlers/send-metadata.ts Outdated Show resolved Hide resolved

FrederikBolding temporarily deployed to pr-comment January 29, 2026 17:33 — with GitHub Actions Inactive

Remove params validation

4636564

FrederikBolding marked this pull request as ready for review January 29, 2026 19:57

FrederikBolding requested review from a team as code owners January 29, 2026 19:57

FrederikBolding requested review from adonesky1 and jiexi January 29, 2026 19:57

FrederikBolding temporarily deployed to pr-comment January 29, 2026 19:57 — with GitHub Actions Inactive

Delete unused import

cf06db4

FrederikBolding temporarily deployed to pr-comment January 29, 2026 20:11 — with GitHub Actions Inactive

FrederikBolding temporarily deployed to pr-comment January 29, 2026 20:41 — with GitHub Actions Inactive

adonesky1 approved these changes Jan 29, 2026

View reviewed changes

FrederikBolding enabled auto-merge January 30, 2026 08:41

Mrtenz approved these changes Jan 30, 2026

View reviewed changes

FrederikBolding added this pull request to the merge queue Jan 30, 2026

Mrtenz mentioned this pull request Jan 30, 2026

fix: Don't use subject metadata controller for Snaps install origin #39634

Closed

7 tasks

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2026

FrederikBolding added this pull request to the merge queue Jan 30, 2026

Merged via the queue into main with commit 29f9591 Jan 30, 2026
179 checks passed

FrederikBolding deleted the fb/remove-send-domain-metadata branch January 30, 2026 12:02

github-actions bot locked and limited conversation to collaborators Jan 30, 2026

metamaskbot added the release-13.18.0 Issue or pull request that will be included in release 13.18.0 label Jan 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Replace `metamask_sendDomainMetadata` with a no-op #39642

fix: Replace `metamask_sendDomainMetadata` with a no-op #39642

FrederikBolding commented Jan 29, 2026 •

edited by cursor bot

Loading

Uh oh!

metamaskbotv2 bot commented Jan 29, 2026 •

edited

Loading

Uh oh!

Uh oh!

metamaskbotv2 bot commented Jan 29, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Jan 29, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

adonesky1 left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fix: Replace metamask_sendDomainMetadata with a no-op #39642

fix: Replace metamask_sendDomainMetadata with a no-op #39642

Conversation

FrederikBolding commented Jan 29, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Manual testing steps

Uh oh!

metamaskbotv2 bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

Uh oh!

metamaskbotv2 bot commented Jan 29, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Jan 29, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

adonesky1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fix: Replace `metamask_sendDomainMetadata` with a no-op #39642

fix: Replace `metamask_sendDomainMetadata` with a no-op #39642

FrederikBolding commented Jan 29, 2026 •

edited by cursor bot

Loading

metamaskbotv2 bot commented Jan 29, 2026 •

edited

Loading