Skip to content

Conversation

@sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Jan 29, 2026

Description

PR to upgrade assets-controllers to v99

Open in GitHub Codespaces

Changelog

CHANGELOG entry: upgrades assets-controllers to v99; no user functionality update.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Medium risk because it changes TokenListController initialization/polling behavior by removing the preventPollingOnNetworkRestart toggle and adds a migration that mutates persisted state, which could impact token list refresh and startup behavior if assumptions differ.

Overview
Upgrades @metamask/assets-controllers to v99 and removes the deprecated TokenListController option/state field preventPollingOnNetworkRestart across initialization, Sentry masking/types, and test fixtures.

Deletes the preference-driven logic and runtime toggling (including toggleExternalServices) that previously enabled/disabled token list polling, and tightens the token list controller messenger permissions accordingly.

Adds migration 191 to strip preventPollingOnNetworkRestart from persisted TokenListController state and bumps stored migration/version metadata and related snapshot/fixture expectations.

Written by Cursor Bugbot for commit 5379ebf. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 29, 2026

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/extension-platform (1 files, +2 -5)
  • 📁 test/
    • 📁 e2e/
      • 📁 fixtures/
        • 📄 onboarding-fixture.json +2 -5

🕵️ @MetaMask/extension-privacy-reviewers (1 files, +0 -1)
  • 📁 test/
    • 📁 e2e/
      • 📁 tests/
        • 📁 settings/
          • 📄 state-logs.json +0 -1

🧪 @MetaMask/qa (2 files, +2 -6)
  • 📁 test/
    • 📁 e2e/
      • 📁 fixtures/
        • 📄 onboarding-fixture.json +2 -5
      • 📁 tests/
        • 📁 settings/
          • 📄 state-logs.json +0 -1

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 29, 2026

Builds ready [c29f0b8]
UI Startup Metrics (1326 ± 111 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13261094162911113911533
load--1133933141710811941334
domContentLoaded--1126926141010811871329
domInteractive--271795172579
firstPaint--1616632767202291
backgroundConnect--23922037519246271
firstReactRender--16104051725
initialActions--104113
loadScripts--90369211861089671111
setupStore--1263441419
numNetworkReqs--211578161571
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--2326152212300140621294755
load--1084930150313811161443
domContentLoaded--1068917146013511031428
domInteractive--38182863635103
firstPaint--186691129129238389
backgroundConnect--55128174668623611793
firstReactRender--24164552635
initialActions--107112
loadScripts--83469212271288701189
setupStore--1674471832
numNetworkReqs--1244943660147237
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--828668107484883973
load--68660086071749804
domContentLoaded--68159684871743800
domInteractive--251694172178
firstPaint--1036033751129213
backgroundConnect--3618139214089
firstReactRender--15103451728
initialActions--104112
loadScripts--67859483370740792
setupStore--1153541218
numNetworkReqs--221583171574
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--12861001193522414691707
load--71762310761117171033
domContentLoaded--70761810691117061026
domInteractive--36181312735116
firstPaint--15568990118203293
backgroundConnect--16513337855162337
firstReactRender--22164342430
initialActions--102111
loadScripts--70461610601107041018
setupStore--1253441418
numNetworkReqs--1234828555151240
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--14561143214117115491757
load--1175956172913612531409
domContentLoaded--1175956172913612531408
domInteractive--783324747101152
firstPaint--------
backgroundConnect--69264185879173
firstReactRender--1498591335
initialActions--102012
loadScripts--1137938169812112021371
setupStore--11494111030
numNetworkReqs--231288191982
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--28671973890478331063541
load--13911084730963213851846
domContentLoaded--13911084730963213851845
domInteractive--14340592104148373
firstPaint--------
backgroundConnect--40412717453295711076
firstReactRender--22154052433
initialActions--216123
loadScripts--13251057727561713441672
setupStore--15514779194204646
numNetworkReqs--82392494788215
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16881350221019618142100
load--14501166194914915481684
domContentLoaded--14501166194914915481684
domInteractive--943023144131161
firstPaint--------
backgroundConnect--752823049118173
firstReactRender--14115041418
initialActions--102012
loadScripts--14081153192913114921599
setupStore--184222371171
numNetworkReqs--231286181877
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--30192086427847033644005
load--15921301261128317032322
domContentLoaded--15911301261028317022322
domInteractive--14941799128152440
firstPaint--------
backgroundConnect--49112715783617611220
firstReactRender--22166562430
initialActions--203123
loadScripts--15351269252125816582221
setupStore--1109769149130414
numNetworkReqs--83382714693184
19--------
📊 Page Load Benchmark Results

Current Commit: c29f0b8 | Date: 1/29/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±54ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 731ms (±51ms) 🟢 | historical mean value: 725ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 54ms 1.01s 1.34s 1.10s 1.34s
domContentLoaded 731ms 51ms 703ms 1.01s 769ms 1.01s
firstPaint 78ms 11ms 60ms 168ms 88ms 168ms
firstContentfulPaint 78ms 11ms 60ms 168ms 88ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 188 Bytes (0%)
  • ui: 101 Bytes (0%)
  • common: 1.24 KiB (0.01%)

@sahar-fehri sahar-fehri marked this pull request as ready for review January 30, 2026 00:07
@sahar-fehri sahar-fehri requested review from a team as code owners January 30, 2026 00:07
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 30, 2026

Builds ready [b592a93]
UI Startup Metrics (1306 ± 125 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13061050174712513901535
load--1117890147711811841335
domContentLoaded--1110887147311811781323
domInteractive--251583172275
firstPaint--171641322172192325
backgroundConnect--22820426711231250
firstReactRender--17104061833
initialActions--109114
loadScripts--89868312321169671113
setupStore--1363451624
numNetworkReqs--211584161572
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--19081548266217219862202
load--1080947182615610731506
domContentLoaded--1065943181515110621488
domInteractive--36191922936101
firstPaint--190731589168237406
backgroundConnect--32828454142339428
firstReactRender--23165272435
initialActions--107112
loadScripts--82371215241378061210
setupStore--1675171731
numNetworkReqs--1305026654154243
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--827670112390877992
load--686599101680743812
domContentLoaded--681596100980738807
domInteractive--241690162275
firstPaint--996226045127190
backgroundConnect--42172783449102
firstReactRender--14103041625
initialActions--104112
loadScripts--678594100779736805
setupStore--1164451120
numNetworkReqs--211582171574
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1260889178022414631681
load--71061110951156971035
domContentLoaded--70060610881156901024
domInteractive--35171992932103
firstPaint--1476449686198308
backgroundConnect--16313134451160307
firstReactRender--22172822228
initialActions--101011
loadScripts--69760410811136881016
setupStore--1143441317
numNetworkReqs--1285226759157256
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--14971179213716916221777
load--12031016152311512971402
domContentLoaded--12021016152311512971402
domInteractive--783527148101145
firstPaint--------
backgroundConnect--69262645177200
firstReactRender--15104861434
initialActions--103122
loadScripts--11671000145810212621334
setupStore--166273281154
numNetworkReqs--231285181879
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--26181993399142227003814
load--12501027229522712451711
domContentLoaded--12491027229522712451711
domInteractive--1253757596124354
firstPaint--------
backgroundConnect--3361111539283393926
firstReactRender--2214112112328
initialActions--217123
loadScripts--12021007226519212101609
setupStore--1318873180126614
numNetworkReqs--1024025653133195
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16421384210217017491968
load--13981190175512114911626
domContentLoaded--13971190175512114911626
domInteractive--863023243118158
firstPaint--------
backgroundConnect--72272094689181
firstReactRender--15104941522
initialActions--102012
loadScripts--13611174164610214231537
setupStore--144157211255
numNetworkReqs--231287181879
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29992145522754431464160
load--16671342327636317772462
domContentLoaded--16661341327136317772461
domInteractive--12837710123129418
firstPaint--------
backgroundConnect--3121241381256288903
firstReactRender--23176882533
initialActions--207123
loadScripts--16041306296532716812313
setupStore--1778867224213717
numNetworkReqs--69382194180173
19--------
📊 Page Load Benchmark Results

Current Commit: b592a93 | Date: 1/30/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±82ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 732ms (±103ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 83ms (±73ms) 🟢 | historical mean value: 79ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 82ms 1.01s 1.65s 1.26s 1.65s
domContentLoaded 732ms 103ms 696ms 1.60s 934ms 1.60s
firstPaint 83ms 73ms 56ms 808ms 88ms 808ms
firstContentfulPaint 83ms 73ms 56ms 808ms 88ms 808ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 607 Bytes (0.01%)
  • ui: 6.84 KiB (0.08%)
  • common: 1.24 KiB (0.01%)

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 30, 2026

Builds ready [5f8d904]
UI Startup Metrics (1296 ± 99 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1296107415609913471480
load--110389313569611591291
domContentLoaded--109789113479611521285
domInteractive--251687162378
firstPaint--156631253147186262
backgroundConnect--23521532215241264
firstReactRender--17114361928
initialActions--108114
loadScripts--8766821139959281069
setupStore--1464061724
numNetworkReqs--221586171572
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--250715617382115825955110
load--1091947176613711431398
domContentLoaded--1076937175213511201379
domInteractive--3419145243299
firstPaint--187731286135239333
backgroundConnect--67328035617665602846
firstReactRender--25165682942
initialActions--104112
loadScripts--84372014111218781108
setupStore--1554461828
numNetworkReqs--935123743109204
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--828672126195886991
load--69259296485761847
domContentLoaded--68758995585749841
domInteractive--2515112182272
firstPaint--1086159767132214
backgroundConnect--40161252748116
firstReactRender--15103041528
initialActions--105113
loadScripts--68458794684746833
setupStore--1154151221
numNetworkReqs--221585181578
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1294891177621914741722
load--75363311571157591068
domContentLoaded--74262811511157491059
domInteractive--40182073140109
firstPaint--16966927120212327
backgroundConnect--16513435246165311
firstReactRender--24164752534
initialActions--102011
loadScripts--73962511431147471049
setupStore--1353951519
numNetworkReqs--1455233157163252
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13751087194317014681736
load--1110942165313111581365
domContentLoaded--1109942165313111581364
domInteractive--60332223671137
firstPaint--------
backgroundConnect--57241863972145
firstReactRender--1394451322
initialActions--103122
loadScripts--1078929162712011211280
setupStore--154181271067
numNetworkReqs--231290191879
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--27961915974895728853376
load--12751038214521212881795
domContentLoaded--12751038214521212871795
domInteractive--14134664117141444
firstPaint--------
backgroundConnect--46312359067694891032
firstReactRender--22153852430
initialActions--204123
loadScripts--12261020205918312571721
setupStore--14612736181155625
numNetworkReqs--79372484692183
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16251360221819216812071
load--13851180167910714411604
domContentLoaded--13851180167810714401604
domInteractive--872918839123136
firstPaint--------
backgroundConnect--73232455599207
firstReactRender--14102631420
initialActions--103112
loadScripts--1347116215648714091494
setupStore--194245391197
numNetworkReqs--231385191882
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29322216502146331463791
load--15681294258124116772150
domContentLoaded--15681293258124116772150
domInteractive--13939694111145388
firstPaint--------
backgroundConnect--35812413932953451083
firstReactRender--21155652430
initialActions--213122
loadScripts--15271274255022916411974
setupStore--1369935184158611
numNetworkReqs--79372964889182
19--------
📊 Page Load Benchmark Results

Current Commit: 5f8d904 | Date: 1/30/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.02s (±38ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 713ms (±36ms) 🟢 | historical mean value: 725ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.02s 38ms 1.00s 1.30s 1.06s 1.30s
domContentLoaded 713ms 36ms 692ms 974ms 745ms 974ms
firstPaint 76ms 10ms 56ms 160ms 88ms 160ms
firstContentfulPaint 76ms 10ms 56ms 160ms 88ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 867 Bytes (0.02%)
  • ui: 6.97 KiB (0.08%)
  • common: 1.24 KiB (0.01%)

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 30, 2026

Builds ready [0149055]
UI Startup Metrics (1320 ± 123 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13201064174812313871517
load--1132902153111511941311
domContentLoaded--1124896152311511861305
domInteractive--251681172074
firstPaint--183631241184204331
backgroundConnect--22921128213232261
firstReactRender--17113451828
initialActions--106113
loadScripts--90968613161149741099
setupStore--1373651523
numNetworkReqs--211577161570
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--21601697542552321952682
load--11561009197516411451555
domContentLoaded--1140997195216311291543
domInteractive--40191993038127
firstPaint--218811555172261537
backgroundConnect--4162993237368370555
firstReactRender--26175072844
initialActions--109113
loadScripts--88574816241508811259
setupStore--1875881935
numNetworkReqs--1285325953146243
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--8396741077929031006
load--69960489982771861
domContentLoaded--69360188980766846
domInteractive--241687162274
firstPaint--1066031151131218
backgroundConnect--41181322548107
firstReactRender--1594051630
initialActions--103112
loadScripts--69059988779764844
setupStore--1263661225
numNetworkReqs--221584181574
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1212815179423713951667
load--71762511081117131048
domContentLoaded--70761810971117041037
domInteractive--38172453335120
firstPaint--14665643114138480
backgroundConnect--16112835444162256
firstReactRender--22163742329
initialActions--102011
loadScripts--70561610901097021029
setupStore--1142241418
numNetworkReqs--914823345120181
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15501238239219116561843
load--12431028191513313161485
domContentLoaded--12421028191413313161485
domInteractive--923822141128150
firstPaint--------
backgroundConnect--842629052121180
firstReactRender--15105061522
initialActions--103122
loadScripts--11921013188011612491385
setupStore--177159221485
numNetworkReqs--241287201883
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--26191916397442627293750
load--12551058232426212111774
domContentLoaded--12551057232426212111774
domInteractive--13035653119114520
firstPaint--------
backgroundConnect--3051221398250300891
firstReactRender--21147582329
initialActions--203122
loadScripts--12031032230224111771690
setupStore--1817837239232757
numNetworkReqs--73372374489178
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16451355231619917722089
load--14131182194715415041657
domContentLoaded--14121181194715415001657
domInteractive--862923342128143
firstPaint--------
backgroundConnect--722524949106169
firstReactRender--14112731421
initialActions--103122
loadScripts--13661166190913514361576
setupStore--134156171235
numNetworkReqs--231286181877
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29172107425551130094035
load--15821221269533117282349
domContentLoaded--15821220269433117282349
domInteractive--12231697129109484
firstPaint--------
backgroundConnect--3521101348289401945
firstReactRender--22164762532
initialActions--206122
loadScripts--15201197260429216842208
setupStore--1648775212218707
numNetworkReqs--72362104292175
19--------
📊 Page Load Benchmark Results

Current Commit: 0149055 | Date: 1/30/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 998ms (±70ms) 🟢 | historical mean value: 1.03s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 696ms (±68ms) 🟢 | historical mean value: 718ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±10ms) 🟢 | historical mean value: 76ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 998ms 70ms 952ms 1.26s 1.22s 1.26s
domContentLoaded 696ms 68ms 660ms 956ms 911ms 956ms
firstPaint 76ms 10ms 64ms 156ms 88ms 156ms
firstContentfulPaint 76ms 10ms 64ms 156ms 88ms 156ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 188 Bytes (0%)
  • ui: 1 Bytes (0%)
  • common: -1.3 KiB (-0.01%)

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 30, 2026

Builds ready [76d8eb5]
UI Startup Metrics (1434 ± 131 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--14341140189013115091681
load--1206956169313912761460
domContentLoaded--1198949168313912671451
domInteractive--291894182582
firstPaint--192661233166225324
backgroundConnect--25022632116255287
firstReactRender--2110112122435
initialActions--105114
loadScripts--966725145314010421222
setupStore--1573861629
numNetworkReqs--221592181576
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--19231581286817320372201
load--1070939193516010631486
domContentLoaded--1053931189914910461416
domInteractive--36191602635100
firstPaint--202721536180237416
backgroundConnect--32128250432333390
firstReactRender--24164572837
initialActions--107113
loadScripts--81570015911368081168
setupStore--1775591939
numNetworkReqs--1244826755152244
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--8276641089858731004
load--68059785869726820
domContentLoaded--67559285069723813
domInteractive--2616106192180
firstPaint--1086137156142226
backgroundConnect--41181272646112
firstReactRender--16103461929
initialActions--106112
loadScripts--67259084368721805
setupStore--1162841121
numNetworkReqs--221580181575
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1261859193923414611722
load--71561510931147021054
domContentLoaded--70660910861146951046
domInteractive--35181522534102
firstPaint--14768586102161450
backgroundConnect--16013236746156285
firstReactRender--23165042430
initialActions--105111
loadScripts--70360710761126921037
setupStore--1252541420
numNetworkReqs--1285127159157251
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--14581148245920915341866
load--1176967216817412311466
domContentLoaded--1175967216717412301465
domInteractive--843496810297183
firstPaint--------
backgroundConnect--66252865283204
firstReactRender--13104351321
initialActions--103122
loadScripts--1136951203515011841374
setupStore--134113151037
numNetworkReqs--231291201883
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--26701936756167027393923
load--12831056245926812781817
domContentLoaded--12831056245926812781817
domInteractive--12438599103114357
firstPaint--------
backgroundConnect--3491324672498353958
firstReactRender--22147082328
initialActions--216123
loadScripts--12271037242423712291627
setupStore--1448744188155604
numNetworkReqs--70371884089176
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16401303222219117701998
load--14121186192214814881688
domContentLoaded--14121179192214814881688
domInteractive--842825548124178
firstPaint--------
backgroundConnect--712320045101162
firstReactRender--14102631422
initialActions--103112
loadScripts--13691166179612514401612
setupStore--164176281275
numNetworkReqs--231285181882
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--30372166808771534074026
load--16391166260034418072411
domContentLoaded--16381161260034418072411
domInteractive--14032956165127569
firstPaint--------
backgroundConnect--35811314203183571078
firstReactRender--22156262431
initialActions--203123
loadScripts--15661151258231917402300
setupStore--21074488484225705
numNetworkReqs--69371834288177
19--------
📊 Page Load Benchmark Results

Current Commit: 76d8eb5 | Date: 1/30/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.07s (±38ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 745ms (±36ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±10ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.07s 38ms 1.05s 1.34s 1.08s 1.34s
domContentLoaded 745ms 36ms 723ms 1.01s 756ms 1.01s
firstPaint 79ms 10ms 60ms 160ms 88ms 160ms
firstContentfulPaint 79ms 10ms 60ms 160ms 88ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 188 Bytes (0%)
  • ui: 1 Bytes (0%)
  • common: -1.3 KiB (-0.01%)

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sahar-fehri sahar-fehri enabled auto-merge February 2, 2026 07:31
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 2, 2026

Builds ready [5379ebf]
UI Startup Metrics (1343 ± 113 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13431071170711314201515
load--1146910134410712161322
domContentLoaded--1139906133610612131307
domInteractive--261686172476
firstPaint--165661271165190306
backgroundConnect--23521031816239264
firstReactRender--18115162032
initialActions--106114
loadScripts--91970011271069911092
setupStore--1352951622
numNetworkReqs--211584161571
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--20101543463148420003266
load--1086951175115610771488
domContentLoaded--1068944174014610621427
domInteractive--39191773137127
firstPaint--226741752278225509
backgroundConnect--3562851406163342645
firstReactRender--24166382644
initialActions--103112
loadScripts--82868814561338301158
setupStore--1563961730
numNetworkReqs--1255224451157226
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--83666711441008791028
load--68558799890725945
domContentLoaded--68058498989718929
domInteractive--2615156212282
firstPaint--1086035560134226
backgroundConnect--37181282146100
firstReactRender--16103561730
initialActions--108112
loadScripts--67758298188716926
setupStore--1374061424
numNetworkReqs--221583181577
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1241895189121914411681
load--7076021037103716985
domContentLoaded--6975961032103706979
domInteractive--35171932932106
firstPaint--167611029152198465
backgroundConnect--15113135033150213
firstReactRender--22173032329
initialActions--102111
loadScripts--6945941024101704971
setupStore--1243741418
numNetworkReqs--874720942107173
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--14211158204120815511916
load--1149958178417412261552
domContentLoaded--1148958178417412261551
domInteractive--67333254892144
firstPaint--------
backgroundConnect--64252464785169
firstReactRender--1494371338
initialActions--102122
loadScripts--1115943173915811801461
setupStore--154133231079
numNetworkReqs--231290181875
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--25121884360736826293442
load--12441027216627112052036
domContentLoaded--12441027216627112052036
domInteractive--1203650285112326
firstPaint--------
backgroundConnect--2741021185204296819
firstReactRender--20146252126
initialActions--203123
loadScripts--11931006214123911661936
setupStore--11510732158108597
numNetworkReqs--773821446100187
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16421364221517217511949
load--14101178194514014861672
domContentLoaded--14101178194514114861672
domInteractive--863017939121153
firstPaint--------
backgroundConnect--712623447110170
firstReactRender--14103441422
initialActions--103112
loadScripts--13651158182512414341606
setupStore--144129211159
numNetworkReqs--231288171876
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--30442289632457033804017
load--16681318413339618202342
domContentLoaded--16681318413339618192335
domInteractive--14434758144134549
firstPaint--------
backgroundConnect--3451211621294314959
firstReactRender--23163652532
initialActions--203123
loadScripts--16011257410238017502183
setupStore--1588789217169718
numNetworkReqs--74382214288180
19--------
📊 Page Load Benchmark Results

Current Commit: 5379ebf | Date: 2/2/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±59ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 714ms (±58ms) 🟢 | historical mean value: 721ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±14ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 59ms 1.01s 1.34s 1.24s 1.34s
domContentLoaded 714ms 58ms 687ms 998ms 897ms 998ms
firstPaint 77ms 14ms 60ms 204ms 84ms 204ms
firstContentfulPaint 77ms 14ms 60ms 204ms 84ms 204ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 186 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: -1.29 KiB (-0.01%)

@sahar-fehri sahar-fehri added this pull request to the merge queue Feb 2, 2026
Merged via the queue into main with commit 64d9287 Feb 2, 2026
332 of 339 checks passed
@sahar-fehri sahar-fehri deleted the chore/upgrade-assets-controller-v99 branch February 2, 2026 08:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2026
@metamaskbot metamaskbot added the release-13.18.0 Issue or pull request that will be included in release 13.18.0 label Feb 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.18.0 Issue or pull request that will be included in release 13.18.0 size-M team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants