-
Notifications
You must be signed in to change notification settings - Fork 5.5k
chore: upgrade assets-controllers to v99 #39646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/extension-platform (1 files, +2 -5)
🕵️ @MetaMask/extension-privacy-reviewers (1 files, +0 -1)
🧪 @MetaMask/qa (2 files, +2 -6)
|
Builds ready [c29f0b8]
UI Startup Metrics (1326 ± 111 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [b592a93]
UI Startup Metrics (1306 ± 125 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [5f8d904]
UI Startup Metrics (1296 ± 99 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [0149055]
UI Startup Metrics (1320 ± 123 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [76d8eb5]
UI Startup Metrics (1434 ± 131 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Gudahtt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
app/scripts/controller-init/messengers/token-list-controller-messenger.ts
Show resolved
Hide resolved
Builds ready [5379ebf]
UI Startup Metrics (1343 ± 113 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Description
PR to upgrade assets-controllers to v99
Changelog
CHANGELOG entry: upgrades assets-controllers to v99; no user functionality update.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk because it changes
TokenListControllerinitialization/polling behavior by removing thepreventPollingOnNetworkRestarttoggle and adds a migration that mutates persisted state, which could impact token list refresh and startup behavior if assumptions differ.Overview
Upgrades
@metamask/assets-controllersto v99 and removes the deprecatedTokenListControlleroption/state fieldpreventPollingOnNetworkRestartacross initialization, Sentry masking/types, and test fixtures.Deletes the preference-driven logic and runtime toggling (including
toggleExternalServices) that previously enabled/disabled token list polling, and tightens the token list controller messenger permissions accordingly.Adds migration
191to strippreventPollingOnNetworkRestartfrom persistedTokenListControllerstate and bumps stored migration/version metadata and related snapshot/fixture expectations.Written by Cursor Bugbot for commit 5379ebf. This will update automatically on new commits. Configure here.