-
Notifications
You must be signed in to change notification settings - Fork 5.5k
chore: update swap MM fee disclaimer #39653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers (1 files, +4 -16)
|
Builds ready [0e92735]
UI Startup Metrics (1315 ± 118 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Builds ready [bb0f509]
UI Startup Metrics (1354 ± 119 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Builds ready [834a00c]
UI Startup Metrics (1352 ± 106 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Description
Updates the MM fee disclaimer condition to check the MM feeData amount
Changelog
CHANGELOG entry: chore: check MM feeData amount to determine swap MM fee disclaimer visibility
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-3249
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: only changes when a UI disclaimer renders and updates localized string copy, with no auth/security or state mutation changes.
Overview
Updates the bridge “no MetaMask fee” disclaimer to render based on
activeQuote.quote.feeData.metabridge.amount === 0instead of a destination-asset allowlist, and removes the token-symbol interpolation.Adjusts
noMMFeeSwappinglocale strings (en/en_GB) to the new static copy: "No MetaMask fee".Written by Cursor Bugbot for commit 834a00c. This will update automatically on new commits. Configure here.