Skip to content

Conversation

@micaelae
Copy link
Member

@micaelae micaelae commented Jan 29, 2026

Description

Updates the MM fee disclaimer condition to check the MM feeData amount

Open in GitHub Codespaces

Changelog

CHANGELOG entry: chore: check MM feeData amount to determine swap MM fee disclaimer visibility

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-3249

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: only changes when a UI disclaimer renders and updates localized string copy, with no auth/security or state mutation changes.

Overview
Updates the bridge “no MetaMask fee” disclaimer to render based on activeQuote.quote.feeData.metabridge.amount === 0 instead of a destination-asset allowlist, and removes the token-symbol interpolation.

Adjusts noMMFeeSwapping locale strings (en/en_GB) to the new static copy: "No MetaMask fee".

Written by Cursor Bugbot for commit 834a00c. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Jan 29, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 29, 2026

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (1 files, +4 -16)
  • 📁 ui/
    • 📁 pages/
      • 📁 bridge/
        • 📁 prepare/
          • 📄 bridge-no-fee-message.tsx +4 -16

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 29, 2026

Builds ready [0e92735]
UI Startup Metrics (1315 ± 118 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13151081165211813811523
load--1127918144111711931353
domContentLoaded--1120914143311711821346
domInteractive--2716111202377
firstPaint--163661207153191285
backgroundConnect--23521629812241259
firstReactRender--1793751923
initialActions--104113
loadScripts--90068912021169571127
setupStore--1363351522
numNetworkReqs--221580181577
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--313216288856155843636033
load--1146964180112812001415
domContentLoaded--1128956178912811821403
domInteractive--38182103334105
firstPaint--205791175130241358
backgroundConnect--10942836376108221932732
firstReactRender--25165972837
initialActions--105112
loadScripts--89073514331139351120
setupStore--1555081829
numNetworkReqs--1065126845111228
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--84867912601139011099
load--702590101391759898
domContentLoaded--696585100690755893
domInteractive--2516103172273
firstPaint--1166076387139261
backgroundConnect--3818123204588
firstReactRender--16103761633
initialActions--106112
loadScripts--693583100489750890
setupStore--1266571221
numNetworkReqs--221584181575
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1300863253228315011848
load--73163413281277211034
domContentLoaded--71962613181277061026
domInteractive--38191492536103
firstPaint--149701149119161281
backgroundConnect--16913278989159332
firstReactRender--22173732430
initialActions--103111
loadScripts--71762513081267041020
setupStore--1252641520
numNetworkReqs--1647035455176312
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13861097184515914811645
load--1123943163912912141354
domContentLoaded--1123943163912912141354
domInteractive--72342353993147
firstPaint--------
backgroundConnect--702319251112180
firstReactRender--1294251215
initialActions--1023212
loadScripts--1084928161211011551246
setupStore--11397111034
numNetworkReqs--241285201881
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29341895773876531563911
load--13471079342637313941841
domContentLoaded--13461074342637313941841
domInteractive--15156668115155424
firstPaint--------
backgroundConnect--46711016333456881197
firstReactRender--21145052328
initialActions--203122
loadScripts--12871030339435713181668
setupStore--209161053223341640
numNetworkReqs--93422615197230
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--17351446252020218412140
load--14771232228615815531755
domContentLoaded--14771232228615815531755
domInteractive--883124349130183
firstPaint--------
backgroundConnect--73272894898165
firstReactRender--16115951622
initialActions--103122
loadScripts--14371211225614315131665
setupStore--215258431296
numNetworkReqs--231285181978
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--30971991697474033764182
load--16711275545357517112444
domContentLoaded--16711275545357517112444
domInteractive--155331085157173466
firstPaint--------
backgroundConnect--49311513333067291079
firstReactRender--23156382432
initialActions--203123
loadScripts--16111253541757016532418
setupStore--1329738162136552
numNetworkReqs--92392584897217
19--------
📊 Page Load Benchmark Results

Current Commit: 0e92735 | Date: 1/29/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±37ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 709ms (±35ms) 🟢 | historical mean value: 724ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±12ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 37ms 1.02s 1.32s 1.06s 1.32s
domContentLoaded 709ms 35ms 688ms 976ms 729ms 976ms
firstPaint 75ms 12ms 56ms 168ms 84ms 168ms
firstContentfulPaint 75ms 12ms 56ms 168ms 84ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 3.83 KiB (0.05%)
  • common: 8 Bytes (0%)

@micaelae micaelae marked this pull request as ready for review January 29, 2026 23:01
@micaelae micaelae requested a review from a team as a code owner January 29, 2026 23:01
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 30, 2026

Builds ready [bb0f509]
UI Startup Metrics (1354 ± 119 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13541060167511914261582
load--1151900141111912311387
domContentLoaded--1143893140511912261380
domInteractive--271688182481
firstPaint--1526632568207286
backgroundConnect--24222029915248278
firstReactRender--17123441923
initialActions--104113
loadScripts--91668211871199981164
setupStore--1373451523
numNetworkReqs--221581171573
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--319816288329157742997563
load--1145976169213211921408
domContentLoaded--1128964168412811671400
domInteractive--37182092934111
firstPaint--1888253695243391
backgroundConnect--1025286287390818672640
firstReactRender--25174452834
initialActions--1010112
loadScripts--89374014221199181141
setupStore--1654881931
numNetworkReqs--1075525340113197
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--8587001212949141054
load--71361097384778875
domContentLoaded--70760695983774869
domInteractive--2617103192383
firstPaint--1106342359122202
backgroundConnect--41181592942116
firstReactRender--16113451831
initialActions--104112
loadScripts--70460495682772866
setupStore--1244461325
numNetworkReqs--221582181574
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1315894260531315392028
load--72863912251107221012
domContentLoaded--71662912201107091004
domInteractive--36171532635103
firstPaint--166691027142185340
backgroundConnect--15512935634158213
firstReactRender--23173442530
initialActions--102111
loadScripts--7146271203108707997
setupStore--1344151521
numNetworkReqs--1618235056172284
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--14001093205617314941764
load--1140947165012112091348
domContentLoaded--1139947165012112091348
domInteractive--763123646104155
firstPaint--------
backgroundConnect--61242174273154
firstReactRender--1398271315
initialActions--104122
loadScripts--110393315109811721241
setupStore--155129211162
numNetworkReqs--231287181877
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--317220278927109932116579
load--14871086324637616042222
domContentLoaded--14871085324537516032221
domInteractive--196591319190275574
firstPaint--------
backgroundConnect--61214056686717381536
firstReactRender--24155162732
initialActions--203123
loadScripts--13911058321831914602047
setupStore--11212878148122467
numNetworkReqs--984130250103229
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16521378212016317721961
load--14161195175713114921648
domContentLoaded--14151195175713114881648
domInteractive--783024047111148
firstPaint--------
backgroundConnect--782721951129170
firstReactRender--15112631520
initialActions--102122
loadScripts--13681173172111614361616
setupStore--194266391174
numNetworkReqs--231281171876
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29702223409937831673768
load--15731297212419817321994
domContentLoaded--15731297212319717321994
domInteractive--17052744137230496
firstPaint--------
backgroundConnect--43312311582906741001
firstReactRender--22153342430
initialActions--213122
loadScripts--15201277209018716491904
setupStore--15316809180159619
numNetworkReqs--93372834997238
19--------
📊 Page Load Benchmark Results

Current Commit: bb0f509 | Date: 1/30/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±38ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 718ms (±36ms) 🟢 | historical mean value: 722ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 38ms 1.01s 1.32s 1.06s 1.32s
domContentLoaded 718ms 36ms 701ms 992ms 745ms 992ms
firstPaint 77ms 11ms 60ms 164ms 88ms 164ms
firstContentfulPaint 77ms 11ms 60ms 164ms 88ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: -486 Bytes (-0.01%)
  • common: 8 Bytes (0%)

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 30, 2026

Builds ready [834a00c]
UI Startup Metrics (1352 ± 106 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13521123165910614361498
load--1154935148010812351293
domContentLoaded--1147929147410812261285
domInteractive--2816112192587
firstPaint--201661258213211329
backgroundConnect--24222328011246273
firstReactRender--18115062029
initialActions--107124
loadScripts--920690124710910041065
setupStore--1363461627
numNetworkReqs--211581161570
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--21051532513858921313702
load--1106926187716711391444
domContentLoaded--1085922187115811151435
domInteractive--43183384636162
firstPaint--198721043134246460
backgroundConnect--3982872609301382697
firstReactRender--23155372738
initialActions--107113
loadScripts--84869715801488771164
setupStore--1655981930
numNetworkReqs--1255427852159237
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--88271113851009311079
load--734637100779789869
domContentLoaded--728633100179785863
domInteractive--2817136202486
firstPaint--1076133849117217
backgroundConnect--36181182141101
firstReactRender--18103672034
initialActions--106112
loadScripts--72563199278782860
setupStore--1374561328
numNetworkReqs--221586181574
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1248938231823514191705
load--70561312681156991009
domContentLoaded--69560812581146861003
domInteractive--3318149233385
firstPaint--1426152185187312
backgroundConnect--15012633237153248
firstReactRender--22163032327
initialActions--102111
loadScripts--6926061249113684994
setupStore--1243741417
numNetworkReqs--1425332762171279
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13651101198916414511671
load--1100937146912011741341
domContentLoaded--1099937146912011731341
domInteractive--65331894089162
firstPaint--------
backgroundConnect--62252955077171
firstReactRender--1294031216
initialActions--102122
loadScripts--1068924144710611271310
setupStore--12491131237
numNetworkReqs--231284181880
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--27521914904292128633875
load--13381065643655713141789
domContentLoaded--13381064643655713141783
domInteractive--1253752497123375
firstPaint--------
backgroundConnect--2941181482231306873
firstReactRender--21153042328
initialActions--214123
loadScripts--12811038639854312671649
setupStore--207111236255306749
numNetworkReqs--78402364693192
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16181276213919517621995
load--13831148178014114771685
domContentLoaded--13821148178014114771685
domInteractive--792823644115143
firstPaint--------
backgroundConnect--712326451107176
firstReactRender--13103831417
initialActions--102012
loadScripts--13401130166911413921551
setupStore--184245351288
numNetworkReqs--231289181976
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29492110856875932433958
load--16201243711064316822414
domContentLoaded--16191243710964316822414
domInteractive--122321320156113341
firstPaint--------
backgroundConnect--3231231410235346919
firstReactRender--21154142328
initialActions--207123
loadScripts--15671218708063316382331
setupStore--1598792205222687
numNetworkReqs--75382204685192
19--------
📊 Page Load Benchmark Results

Current Commit: 834a00c | Date: 1/30/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±127ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 737ms (±151ms) 🟢 | historical mean value: 717ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 98ms (±220ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 127ms 1.01s 2.29s 1.06s 2.29s
domContentLoaded 737ms 151ms 701ms 2.22s 747ms 2.22s
firstPaint 98ms 220ms 60ms 2.28s 88ms 2.28s
firstContentfulPaint 98ms 220ms 60ms 2.28s 88ms 2.28s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: -486 Bytes (-0.01%)
  • common: 8 Bytes (0%)

@micaelae micaelae added this pull request to the merge queue Feb 2, 2026
Merged via the queue into main with commit f2670f2 Feb 2, 2026
334 of 343 checks passed
@micaelae micaelae deleted the swaps3249-no-fee-disclaimer branch February 2, 2026 18:07
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2026
@metamaskbot metamaskbot added the release-13.18.0 Issue or pull request that will be included in release 13.18.0 label Feb 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.18.0 Issue or pull request that will be included in release 13.18.0 size-S team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants