-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix: restore swap/bridge quote if using extension in popup mode #39654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Builds ready [ed4a86d]
UI Startup Metrics (1337 ± 107 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [5fc28c5]
UI Startup Metrics (1299 ± 118 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Builds ready [27a3c04]
UI Startup Metrics (1318 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Description
This fixes a bug in which the extension could get in an invalid state when it's open both in fullscreen and sidepanel mode.
Changelog
CHANGELOG entry: fix: restore swap quote only when using extension in popup mode
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-3598
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Changes routing logic that controls automatic navigation into swap/bridge flows, which could alter user navigation behavior across fullscreen/notification/popup environments. Risk is moderate because it affects swap/bridge UX but does not touch security-sensitive code.
Overview
Popup-only swap/bridge restoration: Updates
ConfirmationHandlerto detectENVIRONMENT_TYPE_POPUPand only auto-redirect to the cross-chain swap prepare route when bridge quotes exist in popup mode.This removes the prior auto-redirect into
PREPARE_SWAP_ROUTEbased on swap quotes/fetch params, reducing unexpected navigation in non-popup contexts while preserving the awaiting-swap redirect and approval-routing behavior.Written by Cursor Bugbot for commit 27a3c04. This will update automatically on new commits. Configure here.