-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix: reset authentication session data upon wallet lock and reset - cp-13.17.0 #39665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [e861a13]
UI Startup Metrics (1311 ± 110 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
LeVinhGithub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm QA
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Builds ready [df41e4f]
UI Startup Metrics (1351 ± 126 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Builds ready [62dd230]
UI Startup Metrics (1280 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
325d8f1
|
Hi @lwin-kyaw Could you please help me check the video below with the strange behavior: Steps:
Screenshare.-.2026-02-02.5_42_55.PM.mp4 |
Builds ready [325d8f1]
UI Startup Metrics (1312 ± 118 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Description
Explicitly sign out from profile-service when
Reset Walletis started.Changelog
CHANGELOG entry: purge profile service on resetting wallet.
Related issues
Fixes: #39627
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk because it changes wallet lock/reset behavior and introduces unconditional auth sign-out plus extra state clearing/polling stops, which could affect session continuity and onboarding flows if misused.
Overview
Ensures authentication session data is purged when the wallet is locked or reset by explicitly calling
authenticationController.performSignOut()(guarded on lock, unconditional on reset).Extends
resetWalletto accept arestoreOnlyflag used by the SRP restore flow to clear subscription/shield/claims state and stop polling while skipping onboarding reset; wires this through the Redux action andRestoreVaultPage(with updated test coverage).Written by Cursor Bugbot for commit 325d8f1. This will update automatically on new commits. Configure here.