Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jan 30, 2026

Description

The update-onboarding-fixture workflow was running the check-status step every single time it was triggered (i.e. for all comments). This was wasting resources, and made it difficult to tell in the UI which runs were the "real" ones.

The workflow has been updated to skip the check-status step if the workflow was not actually run, or if it was cancelled.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: only adjusts GitHub Actions job gating/needs for the fixture update workflow, with no product code changes. Main risk is misconfigured conditions causing check-status/downstream notifications to be skipped unexpectedly.

Overview
Avoids running the check-status job in update-onboarding-fixture.yml when the workflow is cancelled or the comment is on a fork PR.

This updates check-status to depend on is-fork-pull-request and adds a stricter if condition (!cancelled() and non-fork), reducing noisy runs and wasted CI resources.

Written by Cursor Bugbot for commit 900c834. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-core-platform Core Platform team label Jan 30, 2026
@Gudahtt Gudahtt force-pushed the skip-unnecessary-oboarding-fixture-update-status-check branch from 5dcbebb to e04664a Compare January 30, 2026 22:02
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 30, 2026

Builds ready [e04664a]
UI Startup Metrics (1336 ± 102 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13361100169210213961496
load--112192514059911921269
domContentLoaded--111592213969911841263
domInteractive--271788162572
firstPaint--176681404205193297
backgroundConnect--23721829012241259
firstReactRender--18113142026
initialActions--105114
loadScripts--8926961169989641041
setupStore--1365261623
numNetworkReqs--221585171574
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--21151527659680420634479
load--1071929167315710821491
domContentLoaded--1053918166214810741474
domInteractive--36181622933110
firstPaint--222701496232244491
backgroundConnect--44727829864773551557
firstReactRender--23155162438
initialActions--104112
loadScripts--81969813801368381209
setupStore--1563861729
numNetworkReqs--1284528853159243
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--85767712061029211033
load--71060795287761878
domContentLoaded--70460394686756872
domInteractive--261597182377
firstPaint--1066235452119207
backgroundConnect--38181462443100
firstReactRender--16104061734
initialActions--1015212
loadScripts--70160194485754870
setupStore--1264361225
numNetworkReqs--221582181874
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1309881277928415011664
load--72061712551157151032
domContentLoaded--70960912471157031027
domInteractive--37182143234118
firstPaint--1466455899175422
backgroundConnect--15513134937160223
firstReactRender--22173332429
initialActions--101011
loadScripts--70660712381137011018
setupStore--1242031317
numNetworkReqs--1364634258167249
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--14011109206917114901737
load--1134944166212012001359
domContentLoaded--1133940165812012001359
domInteractive--753322842100141
firstPaint--------
backgroundConnect--66252885074177
firstReactRender--1395371233
initialActions--102122
loadScripts--1098931163710311621263
setupStore--133181191040
numNetworkReqs--231285181876
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--27391999757373728573737
load--13011047596751212371735
domContentLoaded--13011047596751212361734
domInteractive--1213645283119388
firstPaint--------
backgroundConnect--3421141377281418994
firstReactRender--22157882332
initialActions--213123
loadScripts--12511030593850312051595
setupStore--13417874178126648
numNetworkReqs--77362304597185
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16341367238518817301963
load--14041195203614414841612
domContentLoaded--14031191203614414841612
domInteractive--73262284594171
firstPaint--------
backgroundConnect--702420845103172
firstReactRender--14103431418
initialActions--106122
loadScripts--13631179192313014391563
setupStore--164175251339
numNetworkReqs--241291201883
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--30122189597766031114270
load--16421318445144017422657
domContentLoaded--16411317445144117422657
domInteractive--12934596118119475
firstPaint--------
backgroundConnect--39311120053325061098
firstReactRender--24155362835
initialActions--203122
loadScripts--15821231440441416912550
setupStore--13271102194113552
numNetworkReqs--73362064481191
19--------
📊 Page Load Benchmark Results

Current Commit: e04664a | Date: 1/30/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 722ms (±36ms) 🟢 | historical mean value: 717ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 39ms 1.01s 1.33s 1.05s 1.33s
domContentLoaded 722ms 36ms 702ms 998ms 730ms 998ms
firstPaint 76ms 11ms 60ms 168ms 84ms 168ms
firstContentfulPaint 76ms 11ms 60ms 168ms 84ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@HowardBraham
Copy link
Contributor

@Gudahtt @seaona I know this workflow was based on another imperfect workflow (update-attributions.yml), but both of these workflows should actually be just one job, not seven.

The `update-onboarding-fixture` workflow was running the `check-status`
step every single time it was triggered (i.e. for all comments). This
was wasting resources, and made it difficult to tell in the UI which
runs were the "real" ones.

The workflow has been updated to skip the `check-status` step if the
workflow was not actually run, or if it was cancelled.
@Gudahtt Gudahtt force-pushed the skip-unnecessary-oboarding-fixture-update-status-check branch from e04664a to 900c834 Compare January 31, 2026 18:22
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 31, 2026

Builds ready [900c834]
UI Startup Metrics (1318 ± 105 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13181069157910513721522
load--1126907140110911871351
domContentLoaded--1119901139710711811320
domInteractive--271792162468
firstPaint--170681188155193293
backgroundConnect--23621528213242263
firstReactRender--17104451927
initialActions--109215
loadScripts--89968511831099631102
setupStore--1364051622
numNetworkReqs--211581161571
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--18861535256916519912146
load--1053934201615110451396
domContentLoaded--1038927187514310281385
domInteractive--35181382534103
firstPaint--174681043126221368
backgroundConnect--31928049038325403
firstReactRender--24145882543
initialActions--107113
loadScripts--80269815481307981123
setupStore--1574871827
numNetworkReqs--1305326054152249
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--83466312171099051014
load--6925861123100759868
domContentLoaded--687581111799754860
domInteractive--241683162275
firstPaint--1125931254152207
backgroundConnect--39171362442113
firstReactRender--15103851627
initialActions--104112
loadScripts--684579111598752857
setupStore--1164551121
numNetworkReqs--221586181575
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1190841174521113861607
load--6775711090116688986
domContentLoaded--6675641075116675977
domInteractive--3117173243090
firstPaint--14662982110179311
backgroundConnect--15513940928160184
firstReactRender--21163942328
initialActions--102111
loadScripts--6655621066114673970
setupStore--1141931217
numNetworkReqs--1275327560149254
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13871085221417814981677
load--1124940188814511931344
domContentLoaded--1124938188814511921344
domInteractive--65332233689136
firstPaint--------
backgroundConnect--61243115081136
firstReactRender--1394651318
initialActions--105112
loadScripts--1092925185813111481292
setupStore--12493131140
numNetworkReqs--231280181976
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--25641930400243226483701
load--12861042233329112612065
domContentLoaded--12861042233229212562064
domInteractive--138391190158122480
firstPaint--------
backgroundConnect--240103860175221801
firstReactRender--22147482229
initialActions--207123
loadScripts--1240991225327212221949
setupStore--1419697180203591
numNetworkReqs--71411894390186
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16361406203515317141955
load--13951212164410114701596
domContentLoaded--13951212164310114691596
domInteractive--933223948132184
firstPaint--------
backgroundConnect--65252474178152
firstReactRender--15114641518
initialActions--102122
loadScripts--1356119716099214051554
setupStore--195155281389
numNetworkReqs--241290211885
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29802334480149631134047
load--16431245264834018192469
domContentLoaded--16431245264734018192469
domInteractive--13532716146113585
firstPaint--------
backgroundConnect--2911191340215302874
firstReactRender--23156662531
initialActions--216123
loadScripts--15911228262631817222387
setupStore--1347759196148667
numNetworkReqs--70382174387181
19--------
📊 Page Load Benchmark Results

Current Commit: 900c834 | Date: 1/31/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±41ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 721ms (±38ms) 🟢 | historical mean value: 721ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±10ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 41ms 1.01s 1.32s 1.05s 1.32s
domContentLoaded 721ms 38ms 699ms 997ms 737ms 997ms
firstPaint 77ms 10ms 60ms 160ms 84ms 160ms
firstContentfulPaint 77ms 10ms 60ms 160ms 84ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@Gudahtt Gudahtt marked this pull request as ready for review February 2, 2026 12:54
@Gudahtt Gudahtt enabled auto-merge February 2, 2026 12:55
@Gudahtt Gudahtt added this pull request to the merge queue Feb 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 2, 2026
@HowardBraham HowardBraham added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit 7fc9619 Feb 3, 2026
184 checks passed
@HowardBraham HowardBraham deleted the skip-unnecessary-oboarding-fixture-update-status-check branch February 3, 2026 12:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2026
@metamaskbot metamaskbot added the release-13.18.0 Issue or pull request that will be included in release 13.18.0 label Feb 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.18.0 Issue or pull request that will be included in release 13.18.0 size-XS team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants