-
Notifications
You must be signed in to change notification settings - Fork 5.5k
ci: Skip check-status step when workflow was not run
#39684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
HowardBraham
merged 1 commit into
main
from
skip-unnecessary-oboarding-fixture-update-status-check
Feb 3, 2026
Merged
ci: Skip check-status step when workflow was not run
#39684
HowardBraham
merged 1 commit into
main
from
skip-unnecessary-oboarding-fixture-update-status-check
Feb 3, 2026
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5dcbebb to
e04664a
Compare
Contributor
Builds ready [e04664a]
UI Startup Metrics (1336 ± 102 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
The `update-onboarding-fixture` workflow was running the `check-status` step every single time it was triggered (i.e. for all comments). This was wasting resources, and made it difficult to tell in the UI which runs were the "real" ones. The workflow has been updated to skip the `check-status` step if the workflow was not actually run, or if it was cancelled.
e04664a to
900c834
Compare
Contributor
Builds ready [900c834]
UI Startup Metrics (1318 ± 105 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
seaona
approved these changes
Feb 2, 2026
HowardBraham
approved these changes
Feb 2, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-13.18.0
Issue or pull request that will be included in release 13.18.0
size-XS
team-core-platform
Core Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
update-onboarding-fixtureworkflow was running thecheck-statusstep every single time it was triggered (i.e. for all comments). This was wasting resources, and made it difficult to tell in the UI which runs were the "real" ones.The workflow has been updated to skip the
check-statusstep if the workflow was not actually run, or if it was cancelled.Changelog
CHANGELOG entry: null
Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: only adjusts GitHub Actions job gating/
needsfor the fixture update workflow, with no product code changes. Main risk is misconfigured conditions causingcheck-status/downstream notifications to be skipped unexpectedly.Overview
Avoids running the
check-statusjob inupdate-onboarding-fixture.ymlwhen the workflow is cancelled or the comment is on a fork PR.This updates
check-statusto depend onis-fork-pull-requestand adds a stricterifcondition (!cancelled()and non-fork), reducing noisy runs and wasted CI resources.Written by Cursor Bugbot for commit 900c834. This will update automatically on new commits. Configure here.