-
Notifications
You must be signed in to change notification settings - Fork 5.5k
chore: wrap tab contents in error boundary #39685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (1 files, +18 -12)
👨🔧 @MetaMask/core-extension-ux (1 files, +18 -12)
|
Builds ready [6cf1fd2]
UI Startup Metrics (1316 ± 110 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gantunesr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for Accounts CO
vinnyhoward
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Builds ready [7aaddba]
UI Startup Metrics (1308 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Wrap each home screen tab in their own error boundaries
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI resilience change: it mainly adds error isolation and Sentry reporting around tab content. Main concern is masking underlying UI errors behind a generic fallback message in individual tabs.
Overview
Adds a new
ErrorBoundarycomponent that catches render errors, reports them viacaptureException, and displays a localizedsomethingWentWrongfallback.Wraps each Account Overview tab’s content (
tokens,perps,defi,nfts,activity) in its ownErrorBoundaryso a crash in one tab doesn’t take down the entire home screen.Written by Cursor Bugbot for commit 7aaddba. This will update automatically on new commits. Configure here.